| 26 Jun 2022 |
 firefrommoonlight | The naive approach of using #[cfg or the cfg_if macro is not working | 22:44:18 |
| firefrommoonlight | The way I can do it now is:
#[task(binds = DMA1_CH3, shared = [rotor_timer_a], priority = 6)]
// #[task(binds = DMA1_STR3, shared = [rotor_timer_a], priority = 6)]
| 22:44:39 |
| firefrommoonlight | And swap the commented lined when I change which MCU I'm flashing, but thisn't ideal | 22:44:56 |
| firefrommoonlight | Dirbao probably has this solved by making all the NVIC names the same lol | 22:45:12 |
| firefrommoonlight | * Dirbaio probably has this solved by making all the NVIC names the same lol | 22:45:24 |
| firefrommoonlight | (Its' not just DMA; the names vary significantly among STM32 variants in PAC) | 22:45:38 |
| firefrommoonlight | USB names vary widely etc | 22:45:44 |
| firefrommoonlight | * USB and timer names vary widely etc | 22:45:49 |
 dirbaio | In reply to @firefrommoonlight:matrix.org
Dirbaio probably has this solved by making all the NVIC names the same lol nope! some mcus have irqs shared between multiple dma channels, or even between DMA and non-DMA stuff! | 22:46:09 |
| firefrommoonlight | :( | 22:48:05 |
| dirbaio | my favourite is stm32g0c1ve's DMA1_Ch4_7_DMA2_Ch1_5_DMAMUX1_OVR | 22:48:24 |
| dirbaio | 👌 | 22:48:27 |
| firefrommoonlight | UH fuck that | 22:48:44 |
| firefrommoonlight | Also, this doesn't work:
#[cfg(featuer = "g4")]
#[task(binds = DMA1_CH3, shared = [rotor_timer_a], priority = 6)]
#[cfg(featuer = "h7")]
#[task(binds = DMA1_STR3, shared = [rotor_timer_a], priority = 6)]
| 22:48:52 |
 Hmvp | dont you need to feature gate the actual function? | 22:49:20 |
| Hmvp | so shim functions that call the actual relevant functions? | 22:49:36 |
| dirbaio | #[cfg_attr(feature="g4", task(binds = DMA1_CH3, shared = [rotor_timer_a], priority = 6))] maybe? though that probably needs the macro to opt-in to parse that properly.. | 22:49:37 |
| firefrommoonlight | I think What I posted is feature gating the fn? | 22:50:39 |
| dirbaio | feature-gating the fn would be
#[cfg(featuer = "g4")]
#[task(binds = DMA1_CH3, shared = [rotor_timer_a], priority = 6)]
fn dma1_ch3_task(...) { ... }
#[cfg(featuer = "h7")]
#[task(binds = DMA1_STR3, shared = [rotor_timer_a], priority = 6)]
fn dma1_ch3_task(...) { ... }
| 22:51:12 |
| dirbaio | ie copypasting the code | 22:51:15 |
| firefrommoonlight | Sort of? At least when you do
#[repr(u8)]
#[cfg_if(feature = "asdf")]
fn myfn() {
| 22:51:20 |
| firefrommoonlight | All the #[ applies to teh fn | 22:51:26 |
| firefrommoonlight | yea - that's where I copy pasted from; jsut didn't include the fn lines below | 22:51:51 |
| dirbaio | and it doesn't work? :S
file an issue I guess, then | 22:52:20 |
| firefrommoonlight | *Just tried your example; no work, but worth a shot! | 22:52:36 |
| dirbaio | at the very least, you can definitely do it by #[cfg]ing and duplicating the whole mod app, lol | 22:52:48 |
| Hmvp | Maybe write a macro that generates the shim functions...🤐 | 22:52:53 |
| firefrommoonlight | haha true! | 22:52:58 |
| firefrommoonlight | Macro could work | 22:53:05 |
| firefrommoonlight | Yea good call re issue | 22:53:20 |
