18 Jul 2024 |
kitsune | Almost the same as returning a reference to a local object from a function… | 12:02:08 |
kitsune | I prefer to store ids in the model; I already have a room pointer anyway, no need to store it for each member individually. | 12:03:19 |
Tobias Fella | maybe we shouldn't have such an object at all | 12:04:49 |
Tobias Fella | treat the user id as a handle that clients can use to query all properties from the room | 12:05:08 |
kitsune | But yes, that means that all member attributes have to be calculated via a Room object, or a temporary RoomMember object should be created.
| 12:05:22 |
kitsune | I guess we have it the wrong name. It does not represent a member, it represents the member state at a given moment in a timeline. | 12:06:18 |
kitsune | * | 12:06:38 |
kitsune | And for that, it’s actually handy. Just don’t store it long term :) | 12:06:58 |
Tobias Fella | a bit annoying, since it's fundamentally quite useful in qml | 12:08:24 |
Tobias Fella | but i think i have an idea... | 12:08:33 |
kitsune | Well, if it’s useful I don’t mind having RoomMember encapsulating a room/userid pair, and separately RoomMemberState for what RoomMember is right now.
| 12:10:09 |
kitsune | But again, I don’t think it’s prudent to store these new RoomMember objects in the model.
| 12:10:52 |
Tobias Fella | right, i think I'll undo that for now | 12:11:19 |
kitsune | You can create them on the fly extremely cheaply. | 12:11:27 |
kitsune | Even cheaper than RoomMemberState
| 12:11:59 |
Tobias Fella | i think i can get something working that requires only changes in neochat, which is good since we can't raise the dependency on libquotient for the next release | 12:12:41 |
Tobias Fella | Carl Schwan: nvrwhere can i interest you in https://2024.matrix.org/ ? | 12:16:19 |
Carl Schwan | I will be there :) | 12:23:19 |
nvrwhere | I'll try and make it over for some of it. Will have to figure out annual leave with Akademy being just before | 12:27:46 |
nvrwhere | In reply to @kitsune:matrix.org
Well, if it’s useful I don’t mind having RoomMember encapsulating a room/userid pair, and separately RoomMemberState for what RoomMember is right now.
While the footguns we've been discovering are annoying the object itself is too useful to fully get rid of. Treating as a convenient set of helpers is workable. I like the idea of having a simple shim with an Id and room that we can pass to qml safely. It can then grab a roommember to grab the properties in a safe manner | 12:32:01 |
kitsune | I have an idea to append && to all RoomMember methods but that’s probably too nasty :)
| 12:50:04 |
kitsune | In reply to @tobiasfella:kde.org Carl Schwan: nvrwhere can i interest you in https://2024.matrix.org/ ? The Quotient workshop is approved to happen on 22nd morning, just in case. | 12:51:15 |
Tobias Fella | cool | 12:51:43 |
Tobias Fella | do you know when the schedule will be released? | 12:51:52 |
kitsune | I don’t. But they started sending the confirmations for accepted sessions at least. | 12:52:23 |
19 Jul 2024 |
GitHub | 🔵 KitsuneRal opened a new PR quotient-im/libQuotient#778: "Bug/regression fixes and a piece of cleanup" with labels enhancement regression | 17:00:59 |
GitHub | 🔴 KitsuneRal changes_requested quotient-im/libQuotient#777 "Prepare libQuotient for operating without being able to reach the server" | 18:55:48 |
Tobias Fella | @kitsune feel free to push stuff onto the branch | 19:07:54 |
20 Jul 2024 |
GitHub | ✅ TobiasFella approved quotient-im/libQuotient#778 "Bug/regression fixes and some cleanup" | 15:55:31 |
GitHub | 🔬 TobiasFella has marked quotient-im/libQuotient#774 as ready to review "Keep cache of messages in database" | 16:27:04 |