| 21 Apr 2024 |
 unixfox | will send my review then | 13:58:32 |
 TheFrenchGhosty | In reply to @wardpearce:matrix.org
i think using poetry would be "best practice" for the docker file & for general install to avoid MITM attacks & malicious packages from being install Poetry is non-standard + curl-ing a script then executing it is absolutely disgusting | 14:04:05 |
 Ward | yea that is true, maybe via the docker file install poetry via pipx | 14:04:46 |
| TheFrenchGhosty | pip/pipx exist for a reason | 14:04:49 |
| TheFrenchGhosty | If you want to really make the script better, you should just make it work with a `pipx install git+` (or compile to a binary) | 14:05:48 |
| TheFrenchGhosty | * If you want to really make the script better, you should just make it work with a `pipx install git+<URL>` (or even better: compile to a binary) | 14:06:55 |
 Samantaz Fox | Ward the code is super clean btw ^^ | 14:08:56 |
| Ward | In reply to @samantazfox:pussthecat.org
Ward the code is super clean btw ^^ thank u 💌 | 14:09:08 |
| Ward | In reply to @thefrenchghosty:pussthecat.org
If you want to really make the script better, you should just make it work with a `pipx install git+<URL>` (or even better: compile to a binary) yea agreed, installation should be improved | 14:09:43 |
| unixfox | In reply to @samantazfox:pussthecat.org
Ward the code is super clean btw ^^ true!!! | 14:10:12 |
| Samantaz Fox | absidue you're on a rampage today or what x) 4 PRs in one day lol | 14:11:08 |
| TheFrenchGhosty | In reply to @thefrenchghosty:pussthecat.org
If you want to really make the script better, you should just make it work with a `pipx install git+<URL>` (or even better: compile to a binary) Ward: I hope you don't take it the wrong way by the way | 14:14:08 |
| TheFrenchGhosty | it's just that basically no one other than unixfox works on the script, so it should be as simple as possible, I'm absolutely against poetry | 14:14:41 |
| TheFrenchGhosty | * it's just that basically no one other than unixfox works on the script, so it should be as simple as possible + use good practices I'm absolutely against poetry | 14:14:52 |
 absidue | In reply to @samantazfox:pussthecat.org
absidue you're on a rampage today or what x) 4 PRs in one day lol All opened within the last 24 hours yes, but I had most of it figured out months ago, I just had never got round to setting up a Linux VM to be able to write the code and test it. | 14:14:57 |
| TheFrenchGhosty | * it's just that basically no one other than unixfox works on the script, so it should be as simple as possible + use good practices (eg: I'm absolutely against poetry) | 14:14:58 |
| Ward | In reply to @thefrenchghosty:pussthecat.org
Ward: I hope you don't take it the wrong way by the way nah is important to make installing shit well | 14:15:41 |
| TheFrenchGhosty | I just checked the PR, with the way you split the script it should make it easy to support pipx | 14:18:13 |
| Ward | pipx install git+https://github.com/WardPearce/smart-ipv6-rotator works | 14:18:14 |
| TheFrenchGhosty | In reply to @wardpearce:matrix.org
pipx install git+https://github.com/WardPearce/smart-ipv6-rotator works is the "binary" properly created in .local/bin ? | 14:18:40 |
| Ward | ye seems so | 14:19:26 |
| Ward | wrote a small script to convert poetry requirements into a requirements.txt file
https://github.com/WardPearce/smart-ipv6-rotator/blob/master/poetry_to_requirements.py | 14:19:47 |
| Ward | ideally could have a small bash script to install pipx for all major operating systems & then install smart-ipv6-rotator via the repo via pipx | 14:23:18 |
| TheFrenchGhosty | So here's my opinion: https://github.com/iv-org/smart-ipv6-rotator/pull/21#issuecomment-2068063098 | 14:23:45 |
| Ward | * ideally could have a small bash script to install pipx for all major operating systems (supported by pipx via the os package manger) & then install smart-ipv6-rotator via the repo via pipx | 14:23:47 |
| TheFrenchGhosty | In reply to @wardpearce:matrix.org
ideally could have a small bash script to install pipx for all major operating systems (supported by pipx via the os package manger) & then install smart-ipv6-rotator via the repo via pipx let's not do that no, pipx installation should be done by the user | 14:24:28 |
| TheFrenchGhosty | If the user isn't able to install a package they shouldn't use the script, let's not lower the barrier to entry to "noobs" | 14:24:53 |
| TheFrenchGhosty | * If the user isn't able to install a package they shouldn't use the script, let's not lower the barrier to entry to "noobs", it should be reasonably high since it's mostly made for public instances (and public instances should be administrated by someone "competent") | 14:25:36 |
| Ward | haha ye true | 14:25:51 |
| Ward | stop the script kiddes | 14:25:59 |
