4 Jan 2022 |
TheFrenchGhosty | In reply to @farmerman:matrix.org I arrived 🙂 👀 | 22:16:49 |
Samantaz Fox | kavin oof | 22:20:53 |
Samantaz Fox | yeah, the DB is quite a problem | 22:21:00 |
Samantaz Fox | I'll see if some stuff can't be optimized (e.g, compacting multiple queries in one when a bunch of videos are added to the DB) | 22:21:49 |
TheFrenchGhosty | Samantaz Fox: storing json is such a bad idea | 22:22:01 |
Samantaz Fox | that's not really the problem, though. | 22:22:39 |
TheFrenchGhosty | it's not? | 22:23:06 |
TheFrenchGhosty | we're literally storing "garbage" | 22:23:17 |
kavin | The biggest problem is the refresh materialzed view thing | 22:23:30 |
Samantaz Fox | ^ | 22:23:39 |
Samantaz Fox | We've had a PR open for this for quite some time | 22:23:55 |
Samantaz Fox | Once we have a migration framework (I need to work on that) then it will be much easier | 22:24:46 |
TheFrenchGhosty | In reply to @samantazfox:pussthecat.org
We've had a PR open for this for quite some time we just need to merge it | 22:24:46 |
TheFrenchGhosty | In reply to @samantazfox:pussthecat.org Once we have a migration framework (I need to work on that) then it will be much easier hasn't it already been done? | 22:24:56 |
Samantaz Fox | hahahahah. no. | 22:25:10 |
Samantaz Fox | that's the problem | 22:25:15 |
Samantaz Fox | and if we want updates to go smoothly, we have to automate that. | 22:25:38 |
TheFrenchGhosty | In reply to @samantazfox:pussthecat.org and if we want updates to go smoothly, we have to automate that. yes, there's a PR for that, no? | 22:25:49 |
Samantaz Fox | not yet | 22:25:56 |
Samantaz Fox | I've only cleaned up the DB code atm | 22:26:11 |
TheFrenchGhosty | https://github.com/iv-org/invidious/pull/1678 wait it wasn't this? | 22:26:49 |
Samantaz Fox | nope | 22:27:23 |
TheFrenchGhosty | something more is needed? | 22:27:32 |
Samantaz Fox | yeah. That person mentioned a migration framework | 22:27:52 |
Samantaz Fox | and I've opened an issue for the different frameworks available in Crystal | 22:28:17 |
Samantaz Fox | https://github.com/iv-org/invidious/issues/2620 | 22:28:37 |
TheFrenchGhosty | In reply to @samantazfox:pussthecat.org
https://github.com/iv-org/invidious/issues/2620 avram seems to be the best | 22:30:19 |
Samantaz Fox | not really | 22:30:43 |
TheFrenchGhosty | and Lucky seems to be going to be the goto framework | 22:30:45 |
Samantaz Fox | if we use avram, we will have to 1) rewrite all SQL statements to their own abstraction language and 2) drop the idea of supporting other SQL databases | 22:31:38 |