!yAXokUArOJxHEACeib:pussthecat.org

Invidious

653 Members
https://invidious.io/ | Instances: https://instances.invidious.io/ | Documentation: https://docs.invidious.io | SourceCode: https://git.invidious.io | Instances API: https://api.invidious.io/ | ToDo: https://todo.invidious.io/ | Bridged to #invidious on Libera.Chat134 Servers

You have reached the beginning of time (for this room).


SenderMessageTime
1 Apr 2024
@samantazfox:pussthecat.orgSamantaz FoxA problem I often encounter myself is "Oh, I'm fixing this, and I see this nearby code that can be fixed in a similar way, so let put the two together". And repeat that until ending with a PR that rewrites a lot of code.14:03:30
@ibicha:matrix.orgibichaI'm loving this conversation btw! On the topic of big PRs, I frequently ask folks to split things up into smaller changes, because it drastically increases the time to approval, simplifies reviews, and increases overall attention of the reviewer. I agree with MOST of what's being said here https://google.github.io/eng-practices/review/developer/small-cls.html14:07:16

Show newer messages


Back to Room ListRoom Version: 7