Invidious | 653 Members | https://invidious.io/ | Instances: https://instances.invidious.io/ | Documentation: https://docs.invidious.io | SourceCode: https://git.invidious.io | Instances API: https://api.invidious.io/ | ToDo: https://todo.invidious.io/ | Bridged to #invidious on Libera.Chat | 134 Servers |
You have reached the beginning of time (for this room).
Sender | Message | Time |
---|
1 Apr 2024 |
Samantaz Fox | A problem I often encounter myself is "Oh, I'm fixing this, and I see this nearby code that can be fixed in a similar way, so let put the two together". And repeat that until ending with a PR that rewrites a lot of code. | 14:03:30 |
ibicha | I'm loving this conversation btw!
On the topic of big PRs, I frequently ask folks to split things up into smaller changes, because it drastically increases the time to approval, simplifies reviews, and increases overall attention of the reviewer. I agree with MOST of what's being said here https://google.github.io/eng-practices/review/developer/small-cls.html | 14:07:16 |
Back to Room ListRoom Version: 7