| 4 Apr 2020 |
| 17:22:08 |  headius | CodeRangeType maybe? |
| 17:22:17 | headius | Entry is fine too |
| 17:27:19 |  lopex | headius: i'll commit to master since it wont break anything for now |
| 17:27:30 | lopex | headius: that's a lot of enum classes though |
| 17:27:46 | lopex | then there's another question |
| 17:28:01 | lopex | where we should put that in api ? |
| 17:28:11 | headius | It's only one enum class |
| 17:28:37 | headius | Well I guess a method like isCType |
| 17:29:00 | lopex | oh right, wrt enums |
| 17:29:20 | lopex | but it should be a static field on unicode encoding then ? |
| 17:29:35 | lopex | since it doesnt depend on unicode encoding type |
| 17:30:37 | lopex | isInRange or something ? |
| 17:30:51 | lopex | hmm UnicodeProperties.CodeRangeEntry.TITLECASELETTER |
| 17:31:49 | lopex | UnicodeProperties is public, so we cant remove that |
| 17:32:53 | lopex | headius: it's not used though in joni and in jruby |
| 17:34:58 | lopex | I'd happily rename UnicodeProperties to UnicodeCodeRange and make it a bit shallower |
| 17:38:06 | lopex | headius: ? |
| 17:38:23 | lopex | UnicodeProperties is just a holder for that table |
| 17:38:52 | headius | Sounds good to me, I felt weird about that too |
| 17:39:06 | lopex | ok |
| 17:46:22 | lopex | headius: UnicodeEncoding.isInCodeRange(UnicodeCodeRange.TITLECASELETTER, 498) ? |
| 17:47:59 | lopex | or, actually move that to UnicodeCodeRAnge ? |
| 17:49:16 | lopex | headius: UnicodeCodeRange.TITLECASELETTER.contains(498) ? |
| 17:49:35 | lopex | it's the best as it can get |
| 18:03:28 |  travis-ci | jruby/jruby (master:0af1b09 by Phil Pirozhkov): The build failed. https://travis-ci.org/jruby/jruby/builds/671012245 [173 min 3 sec] |
| 18:17:03 | lopex | headius: https://github.com/jruby/jcodings/blob/master/src/org/jcodings/unicode/UnicodeCodeRange.java |
| 18:19:32 | lopex | this will simplify things in some places too |
| 18:19:40 | lopex | there are some lookups there |
| 18:20:15 | lopex | like grapheme clusters |
| 18:57:19 |  olleolleolle | https://github.com/rubygems/rubygems/blob/master/.github/workflows/jruby-bundler.yml This YAML configuration points out 9.2.11.0 - is it worth updating to .1? |
