| 1 Jun 2024 |
 nyxholas | It was only documented on the website a few months ago https://www.audiobookshelf.org/faq#how-do-i-help-with-translations | 04:22:55 |
| nyxholas | We had talked about a shared repository to keep translations between the apps and web client in sync, but everything we came up with made it more difficult for actually working on the code (additional scripts/commands). We took a look at GitLocalize in the past and I went through and got it all set up with a test repo, but didn't notice that it needed full access to advplyr's GH account to actually work. We could probably do Weblate, but that's probably something advplyr needs to look into since they own the repos (could maybe do it under the audiobookshelf GH organization, but still need to migrate the repositories and make sure nothing breaks during that process) | 04:26:41 |
| nyxholas | * We had talked about a shared repository to keep translations between the apps and web client in sync, but everything we came up with made it more difficult for actually working on the code (additional scripts/commands). We took a look at GitLocalize in the past and I went through and got it all set up with a test repo, but didn't notice that it needed full access to advplyr's GH account to actually work. We could probably do Weblate, but that's probably something advplyr needs to look into since the repos are under their account (could maybe do it under the audiobookshelf GH organization, but still need to migrate the repositories and make sure nothing breaks during that process) | 04:27:01 |
| nyxholas | * It was only documented on the website a month or two ago https://www.audiobookshelf.org/faq#how-do-i-help-with-translations | 04:28:48 |
 sandreas | nyxholas: Yeah. As a migration strategy, we could a simple npm JavaScript add-translation.js to both of the repositories, that can be used by developers to add translations. | 04:29:09 |
| nyxholas | Yeah, that would be an option, but advplyr has asked that PRs don't modify the other language files so there are less files to review. We do have a GH workflow that checks all of the language files are following the format, though | 04:32:27 |
| nyxholas | (such as when PRs sit for a while because then there are merge conflicts) | 04:33:04 |
| nyxholas | * (such as when PRs sit for a while because then there can bemerge conflicts) | 04:33:17 |
| nyxholas | * (such as when PRs sit for a while because then there can be merge conflicts) | 04:33:22 |
| sandreas | In reply to @_discord_476196266183884800:t2bot.io
Yeah, that would be an option, but advplyr has asked that PRs don't modify the other language files so there are less files to review. We do have a GH workflow that checks all of the language files are following the format, though Ah crap, I did not know that. I added the translations to all files in mine :-/ | 04:37:06 |
| sandreas | Maybe a pre-commit-hook would be a good idea then... | 04:37:36 |
| nyxholas | I don't think it is as big of a deal now, we added a GH workflow for commits/PRs that checks the language files are well formed | 04:38:29 |
| sandreas | Oh, this seems to have passed now. | 04:38:57 |
| nyxholas | So it's less effort for advplyr to verify the PR has everything in the right order because it shows up as an automatic check instead of having to pull and check | 04:39:18 |
| sandreas | As soon as https://github.com/advplyr/audiobookshelf-app/pull/1218 is through, I plan to add a dev.md to audiobookshelf-app with instructions on how to submit a PR | 04:40:26 |
| nyxholas | What do you think the pre-commit-hook would do? Just make sure the other files are not modified or something? | 04:40:32 |
| nyxholas | I'm not super familiar with workflows, I have only made some basic ones for checking things (like the i18n checker) | 04:41:08 |
| sandreas | In reply to @_discord_476196266183884800:t2bot.io
What do you think the pre-commit-hook would do? Just make sure the other files are not modified or something? It could check, if the en-us.json is in a valid state and fail the commit, if not | 05:59:49 |
| sandreas | But it would also mean a pretty complex check... It may be necessary to delete or modify translations and therefore it cannot fail based on other translation files, but only do some basic checks like alphabetical order, duplicate keys, etc. | 06:01:22 |
| sandreas | Maybe this is too much work and to less benefit... | 06:01:37 |
| nyxholas | Does that work for local things or does it only run on a push? | 06:38:53 |
| nyxholas | I think having the alphabetical check happening locally provides benefit, right now it's only when pushed or on a PR, but those checks don't run for new contributors (so they don't get the automatic feedback when starting to help translate) | 06:40:19 |
| nyxholas | * I think having the alphabetical check happening locally provides benefit, right now it's only when pushed or on a PR, but those checks don't run for new contributors until approved (so they don't get the automatic feedback when starting to help translate) | 06:40:42 |
| sandreas | In reply to @_discord_476196266183884800:t2bot.io
Does that work for local things or does it only run on a push? https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks | 09:43:12 |
| sandreas |
The pre-commit hook is run first, before you even type in a commit message. It’s used to inspect the snapshot that’s about to be committed, to see if you’ve forgotten something, to make sure tests run, or to examine whatever you need to inspect in the code.
| 09:43:39 |
| sandreas | Something else that kept me busy is that ABS app does not support navigating to the last listened track on START. Why the heck do I always have to perform 3 clicks with loading waits after an app crash to get back to a locally stored audiobook? :-/ | 09:59:36 |
| sandreas | Should not take ANY time to load something ;) | 10:00:46 |
| nyxholas | It used to automatically open the last book, but there were sync issues with progress being lost so it was removed. I don't think anyone has looked at it since then | 15:08:37 |
 advplyr | If the last thing you listened to was a streamed book we have to wait for the connection to establish before opening the stream again.
One of the issues was some users have servers that take 10 seconds to connect to. We don't want to block the usage of the app for downloaded items while waiting to connect.
There are solutions that make sense but haven't been build out yet | 15:22:42 |
| sandreas | In reply to @_discord_920732593710841917:t2bot.io
If the last thing you listened to was a streamed book we have to wait for the connection to establish before opening the stream again.
One of the issues was some users have servers that take 10 seconds to connect to. We don't want to block the usage of the app for downloaded items while waiting to connect.
There are solutions that make sense but haven't been build out yet Understandable, but: In my opinion caching the original stream data would be better to show everything of the last book. Then, clicking on stream could wait on the successful connection or show an error. | 16:17:23 |
