!vjxoehfkjwElRXCAGz:matrix.org

dev-chat

1719 Members
20 Servers

Load older messages


SenderMessageTime
25 Feb 2024
@_discord_193809216954171392:t2bot.iosapd Also small thing but not related: The api docs currently say that the server will generate a state parameter. With the latest update you should do it by yourselves (just generate some random string and pass it as state parameter to /auth/openid then check it in subsequent calls) 21:36:52
@_discord_657675443838910503:t2bot.ioimbarticus changed their display name from imbarticus#0 to imbarticus.21:57:03
@_discord_693184550330695681:t2bot.ionalegsos Can someone direct me to the API call that is made to download an audiobook item for offline listening? 22:33:24
@_discord_693184550330695681:t2bot.ionalegsos 22:33:28
26 Feb 2024
@_discord_193809216954171392:t2bot.iosapd use https? 11:47:03
@_discord_476196266183884800:t2bot.ionyxholas Or don't open that port so you force them to go through the reverse proxy? 14:02:37
@_discord_920732593710841917:t2bot.ioadvplyr I was going to link the API docs but it doesn't look like that endpoint is in there. You can look in the LibraryItemController.js file for that 14:13:41
@_discord_476196266183884800:t2bot.ionyxholas * And don't open that port so you force them to go through the reverse proxy? 14:28:04
@_discord_391628959735087106:t2bot.iogh0stiIMG_8881.png
Download IMG_8881.png
17:58:48
@_discord_391628959735087106:t2bot.iogh0sti Was this change added that I have to leave the GitHub app to fill out a request? 17:58:51
@_discord_476196266183884800:t2bot.ionyxholas Like reporting issues? Mine just goes to a new page in the Android GH app to fill out the information 18:08:51
@_discord_476196266183884800:t2bot.ionyxholas Oh, yeah the main server repo makes me open it in a browser, the app repo lets me do it within the GH app 18:10:16
@_discord_920732593710841917:t2bot.ioadvplyr I didn't realize github had a mobile app 18:42:05
@_discord_476196266183884800:t2bot.ionyxholas Yeah, it's really nice. Doesn't let you do a lot of management but good enough for searching and commenting things real quick 18:43:47
@_discord_391628959735087106:t2bot.iogh0sti I just don't get why I have to leave the app to sumit a feature or bug report? 19:31:37
@_discord_336088571410907136:t2bot.iodieseltech issue templates are a beta feature 20:43:02
@_discord_336088571410907136:t2bot.iodieseltechimage.png
Download image.png
20:43:04
@_discord_336088571410907136:t2bot.iodieseltech Because that's how software works in the real world. Why wouldn't you leave the app to do something unrelated to the apps core functions 20:43:54
@_discord_336088571410907136:t2bot.iodieseltech People need to loose this obsession with wanting 1 app to do everything 20:44:11
@_discord_336088571410907136:t2bot.iodieseltech It's not only not practical, but totally unfeasible from a dev standpoint 20:44:37
@_discord_391628959735087106:t2bot.iogh0sti that was it I was going to submit a request in the github app but it was sending me to safari web browser to do the request. 22:05:09
@_discord_920732593710841917:t2bot.ioadvplyr sapd What do you think a reasonable request timeout would be for the oidc requests that passport makes? This is in response to https://github.com/advplyr/audiobookshelf/issues/2669 that hit the default timeout limit of 3500ms set by openid-client. A PR was put in also making the global timeout adjustment shown in the readme https://github.com/panva/node-openid-client/blob/main/docs/README.md#customizing 23:10:44
@_discord_920732593710841917:t2bot.ioadvplyr The only downside I see of a long timeout is if the oidc server is actually down the user would have to wait to find out. Waiting 30s or w/e 23:12:38
@_discord_193809216954171392:t2bot.iosapd Hard to tell. I would say maximum 10s. Everything above really is a problem with the setup/performance of the Identity provider 23:13:27
@_discord_193809216954171392:t2bot.iosapd 10s would be already quite a lot 23:14:07
@_discord_920732593710841917:t2bot.ioadvplyr Yeah and at 6 seconds I would already be thinking some performance improvement needs to be made 23:15:02
@_discord_920732593710841917:t2bot.ioadvplyr 10s seems fair 23:15:27
@_discord_193809216954171392:t2bot.iosapd Yep 23:15:35
27 Feb 2024
@_discord_476196266183884800:t2bot.ionyxholas Just opened my PR for the initial OpenAPI spec. It's probably not great, so if anyone has any feedback that would be appreciated 01:41:16
@_discord_476196266183884800:t2bot.ionyxholas * Just opened my PR for the initial OpenAPI spec. It's probably not great, so if anyone has any feedback that would be appreciated
https://github.com/advplyr/audiobookshelf/pull/2671
01:45:24

There are no newer messages yet.


Back to Room ListRoom Version: 9