| 16 Jan 2025 |
 David Blackman | related question: is there a way to just build the rust (and see the errors from it) without running poetry install -v where I need to scroll back through tons of python errors to see the rust error I need? | 12:05:03 |
 clokep | Maybe maturin develop? Unsure if that still works. | 13:53:43 |
| 17 Jan 2025 |
 Erik | maturin develop should work and actually build the shared library, cargo check should also work to just see if there are any rust errors | 10:19:37 |
|  @nspace:0x4141.eu joined the room. | 13:23:56 |
|  d_k joined the room. | 22:06:33 |
| d_k set a profile picture. | 22:13:13 |
| 18 Jan 2025 |
| @nspace:0x4141.eu left the room. | 01:16:54 |
|  @secretname.basis:matrix.org joined the room. | 13:18:54 |
| @secretname.basis:matrix.org left the room. | 13:39:57 |
|  Mona changed their profile picture. | 14:44:15 |
| 20 Jan 2025 |
|  Shay changed their display name from Shay to Shay [MLK Day, back Tuesday]. | 01:29:08 |
|  nex (-> @nex:transgender.ing) changed their display name from nex (she/it) 🐟🐟 to nex (she/it). | 18:07:17 |
| 21 Jan 2025 |
| nex (-> @nex:transgender.ing) changed their profile picture. | 01:43:49 |
 Till | Can I have some eyes on the changelog for 1.123.0rc1 please: https://github.com/element-hq/synapse/blob/release-v1.123/CHANGES.md
(looking at it, reword the feature Add a unit test [..], to something like "Add a query param type to the Room State Admin API that filters the state event")
| 13:52:32 |
 Emma [it/its] | the way its currently worded makes it sound like it already existed before, while the new wording would imply that it's a new feature | 13:53:43 |
| Till | Yea, the PR adds the filter, not only adds a UT for it | 13:55:47 |
| clokep | In reply to @s7evink:matrix.org
Can I have some eyes on the changelog for 1.123.0rc1 please: https://github.com/element-hq/synapse/blob/release-v1.123/CHANGES.md
(looking at it, reword the feature Add a unit test [..], to something like "Add a query param type to the Room State Admin API that filters the state event")
Any chance you can add that I contributed the implementation for 4133? It ended up being a lot of work and I wouldn’t mind credit for it! | 13:56:18 |
| clokep | Sorry for missing it in the Pr | 13:56:27 |
| Till | Sure, can do that | 13:56:38 |
| clokep | I was expecting it to be a quick thing… four months later. 🙄 | 13:57:06 |
| Till | both things updated | 13:59:15 |
 Andrew Morgan (anoa) {he/him} [@ FOSDEM] | Till LGTM other than a tiny nitpick!
- "query param" -> "query parameter"
| 14:00:50 |
 MatMaul | related to being credited: I am not sure why but I never appear in the contributors section even when I have commits in a release. I can often see Patrick there and some other people, so I guess my nickname is in a list somewhere where it shouldn't be, as an ex member of the synapse team. don't spend time on that it's not bothering me much, but if someone notice my name somewhere... | 15:53:55 |
| Andrew Morgan (anoa) {he/him} [@ FOSDEM] | MatMaul contributors have to add their own name to the newsfile: https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog:~:text=Adding%20credits%20to%20the%20changelog%20is%20encouraged%2C%20we%20value%20your%20contributions%20and%20would%20like%20to%20have%20you%20shouted%20out%20in%20the%20release%20notes! | 15:54:47 |
| clokep | In reply to @mat:tout.im
related to being credited: I am not sure why but I never appear in the contributors section even when I have commits in a release. I can often see Patrick there and some other people, so I guess my nickname is in a list somewhere where it shouldn't be, as an ex member of the synapse team. don't spend time on that it's not bothering me much, but if someone notice my name somewhere... Do you tag your GitHub username in contributions? | 15:54:49 |
| MatMaul | ohhh ok I thought it was calculated from the commits (minus core team). I'll do that next time thanks. | 15:56:24 |
| clokep | Idk why GitHub doesn’t use commits, but it uses tagged usernames in the release (the thing you put into the GitHub release page for a tag) | 15:57:49 |
| MatMaul | I didn't even get that it was a GH stuff, I thought it was done by a synapse releng script. | 15:58:43 |
| clokep | Probably could update the release script to add it automatically, but some folks like to mention who they made the contribution on behalf of. (Beeper often does this.) | 15:59:17 |
| Andrew Morgan (anoa) {he/him} [@ FOSDEM] | For full clarity we use towncrier to generate the changelog. Newsfile entries are taken verbatim, with a link to the PR appended to the end.
We'll then update the changelog manually at release time if there's anything obviously wrong or missing. In this case, we added credit for Patrick as he asked in the room during the changelog review, but that's only as he forgot to include it in the newsfile during the (long) PR review period.
| 16:01:18 |
