| 16 Sep 2019 |
 @gitter_bradrydzewski:matrix.org | it might be vendored, in which case would produce a plugin that cannot be used with Drone 0.5 or higher | 18:17:32 |
 @gitter_tboerger:matrix.org | I know | 18:18:06 |
| @gitter_tboerger:matrix.org | I will prepare it to be ready for merging a pr that brings this plugin back to life. I just need to discuss the attributes with @arcolife as the nested attributes suck pretty much :) | 18:20:26 |
| @gitter_bradrydzewski:matrix.org | ok gotcha! | 18:25:16 |
| @gitter_bradrydzewski:matrix.org | yes, the nested attributes was the big issue | 18:26:08 |
| @gitter_tboerger:matrix.org | What do you think? Execute the plugin for every different upload instead of the nested attributes? | 18:31:29 |
| @gitter_tboerger:matrix.org | Is he afraid now? 😝 | 18:35:16 |
| @gitter_bradrydzewski:matrix.org | yes, execute for each upload | 18:49:58 |
| @gitter_bradrydzewski:matrix.org | or for multi-upload in a single step load the configuration from file | 18:50:07 |
| @gitter_bradrydzewski:matrix.org | the best practice I would like to enforce are that anything super complex should define and use its own configuration file | 18:50:45 |
| @gitter_bradrydzewski:matrix.org | (edited) ... enforce are that ... => ... enforce is that ... | 18:50:54 |
| @gitter_bradrydzewski:matrix.org | so a plugin could support both this: - name: upload
settings:
token:
from_secret: token
bucket: foo
files:
- bar.tar.gz
- baz.tar.gz
and this: - name: upload
settings:
token:
from_secret: token
from_file: path/to/file.yaml
| 18:52:36 |
| @gitter_bradrydzewski:matrix.org | (edited) ... this:
```
- name: upload
settings:
token:
from_secret: token
bucket: foo
files:
- bar.tar.gz
- baz.tar.gz
```
and this:
```
- ... => ... this:
```text
- name: upload
settings:
token:
from_secret: token
bucket: foo
files:
- bar.tar.gz
- baz.tar.gz
```
and this:
```text
- ... | 18:52:44 |
| @gitter_bradrydzewski:matrix.org | (edited) ... settings:
token:
from_secret: token
from_file: path/to/file.yaml
``` ... => ... settings:
import: path/to/file.yaml
token:
from_secret: token
``` ... | 18:52:57 |
| @gitter_bradrydzewski:matrix.org | (edited) so a plugin could support both this:
```text
- name: upload
settings:
token:
from_secret: token
bucket: foo
files:
- bar.tar.gz
- baz.tar.gz
```
and this:
```text
- name: upload
settings:
import: path/to/file.yaml
token:
from_secret: token
```
=> the best practice I would like to enforce is that a plugin with super-complex configuration should define its own configuration file | 18:53:37 |
| @gitter_tboerger:matrix.org | Sounds valid | 18:55:08 |
| @gitter_tboerger:matrix.org | Need to check if globs could make sense as well | 18:55:25 |
| @gitter_bradrydzewski:matrix.org | very possible | 18:57:42 |
| @gitter_tboerger:matrix.org | i have prepared the pipeline via drone-plugins/drone-bintray#24, it will anyway fail which is expected because trying the executeable will fail until it’s migrated to 1.x.x | 19:21:20 |
| @gitter_tboerger:matrix.org | @bradrydzewski @arcolife | 19:21:59 |
 @gitter_arcolife:matrix.org | @tboerger @bradrydzewski wow thanks so much for answering my questions patiently. I'm in! Sorry I didn't get all the messages in my gitter app. But I'm here now | 20:22:16 |
| @gitter_arcolife:matrix.org | Catching up on your messages. If either of you is up for a small session, I can do this now or we can schedule this tomorrow? It's 1:53 am at my place ;) | 20:23:22 |
| @gitter_arcolife:matrix.org | Btw how do I interact with the plug-in build pipeline? Or is it upto the owners here? | 20:25:36 |
| @gitter_tboerger:matrix.org | i think https://github.com/drone-plugins/drone-webhook/blob/master/main.go could be a well starting point. the biggest difference between 0.4 and plugins for >= 0.6 is that the old plugins required a json payload via stdin while newer plugins are simply listening to env variables. | 20:27:13 |
| @gitter_tboerger:matrix.org | the nested array had been a poor design decision, that should be replaced by multiple calls of the bintray plugin instead. so keep the parameters as simple as possible, best would be plain types like int, float, string, boolean or slices of these simple types. | 20:28:18 |
| @gitter_tboerger:matrix.org | if something is unclear just write here, i will try to answer asap | 20:33:22 |
| 17 Sep 2019 |
| @gitter_arcolife:matrix.org | Sure! | 03:04:57 |
|  @gitter_laughing_z_twitter:matrix.org joined the room. | 07:38:05 |
| @gitter_laughing_z_twitter:matrix.org | @RabeaWahab I have the same problem | 07:38:05 |
|  @gitter_laughingmoon:matrix.org joined the room. | 07:54:26 |
