!ozfxFAWEEDbVgXoYVA:matrix.org

Astropy general

372 Members
General discussion about astropy31 Servers

Load older messages


SenderMessageTime
17 Sep 2020
@slack_astropy_U0LE97SBD:openastronomy.orgtomaldcroft
In reply to@slack_astropy_U774ARTKR:openastronomy.org
Perhaps E. M. Bray will have ideas.
And of course in https://github.com/astropy/astropy/pull/10743 I just tried [docs-only] but it is still running the full travis CI, and for bonus it is failing now for reasons that should be unrelated to my trivial docs update. Sigh.
13:50:48
@slack_astropy_U774ARTKR:openastronomy.orgpllim
In reply to@slack_astropy_U0LE97SBD:openastronomy.org
And of course in https://github.com/astropy/astropy/pull/10743 I just tried [docs-only] but it is still running the full travis CI, and for bonus it is failing now for reasons that should be unrelated to my trivial docs update. Sigh.
Yeah, bleach 3.2.0 broke stuff. I am working on that one.
13:51:39
@slack_astropy_U774ARTKR:openastronomy.orgpllim
In reply to@slack_astropy_U774ARTKR:openastronomy.org
Yeah, bleach 3.2.0 broke stuff. I am working on that one.
p.s. Use [ci skip] for docs only. RTD doesn't understand it yet.
13:52:00
@slack_astropy_U0LE97SBD:openastronomy.orgtomaldcroft
In reply to@slack_astropy_U774ARTKR:openastronomy.org
p.s. Use [ci skip] for docs only. RTD doesn't understand it yet.
Ugh, always something! I didn't even know about that CONTRIBUTING.md. For me at least this information should be in the developer docs.
13:54:51
@slack_astropy_U0160UQFTLK:openastronomy.orgastrochun
In reply toundefined
Yea, as a newbie I was confused between "skip ci" and "ci skip" in the documentation.
15:55:03
@slack_astropy_U0160UQFTLK:openastronomy.orgastrochun
In reply toundefined
(edited) ... "ci skip" => ... "ci skip" in the documentation.
15:55:28
@slack_astropy_U774ARTKR:openastronomy.orgpllim
In reply to@slack_astropy_U0160UQFTLK:openastronomy.org
Yea, as a newbie I was confused between "skip ci" and "ci skip" in the documentation.
They are the same thing, no dash though. ๐Ÿ™‚
15:55:51
@slack_astropy_U0160UQFTLK:openastronomy.orgastrochun
In reply to@slack_astropy_U774ARTKR:openastronomy.org
They are the same thing, no dash though. ๐Ÿ™‚
Right, but I vaguely remember that the documentation had used it interchangeably.
15:57:59
18 Sep 2020
@slack_astropy_U01AHJH463Z:openastronomy.orgJielai Zhang joined the room.08:56:39
@slack_astropy_U01AHJH463Z:openastronomy.orgJielai Zhang changed their display name from slack_astropy_U01AHJH463Z to Jielai Zhang.09:16:28
@slack_astropy_U01AHJH463Z:openastronomy.orgJielai Zhang set a profile picture.09:16:29
@slack_astropy_U01AHJH463Z:openastronomy.orgJielai Zhang changed their profile picture.09:17:36
@astrojuanlu:matrix.orgastrojuanluquestion: I am a maintaner of a certain subpackage, and two other co-maintainers have given their explicit Approval โœ”๏ธ on an apparently non-controversial pull request. should I wait for someone else to merge it, or should I merge it myself? (case in point: https://github.com/astropy/astropy/pull/10727)13:02:59
@astrojuanlu:matrix.orgastrojuanlu * question: I am a maintaner of a certain subpackage, and two other co-maintainers have given their explicit Approval โœ”๏ธ on an apparently non-controversial pull request. should I wait for someone else to merge it, or should I merge it myself? (case in point: https://github.com/astropy/astropy/pull/10727)13:03:07
@slack_astropy_U75UFQL6P:openastronomy.orgadrn I usually still wait for (or prod) someone else to merge (feel free to ping me on slack ๐Ÿ™‚) 13:05:37
@astrojuanlu:matrix.orgastrojuanlu thanks adrn ! just force pushed to fix the conflict, will ping you when the CI is green 13:06:19
@slack_astropy_U75UFQL6P:openastronomy.orgadrn But if it's a non-controversial PR, I think it's ok to merge if no one else responds or takes action over a few days, or if there is some other time urgency (like, a fix needed for other PRs). All of that conditional on having a few approvals on the PR! 13:07:02
@slack_astropy_U774ARTKR:openastronomy.orgpllim Before your CI will pass again, you need to approve and merge my https://github.com/astropy/astropy/pull/10744 first ๐Ÿ˜œ 13:12:01
@astrojuanlu:matrix.orgastrojuanlu will wait for a response from this comment of yours from 25 seconds ago ๐Ÿ˜‚ https://github.com/mozilla/bleach/pull/558#issuecomment-694861882 13:17:49
@astrojuanlu:matrix.orgastrojuanlu
In reply to @slack_astropy_U774ARTKR:openastronomy.org
Before your CI will pass again, you need to approve and merge my https://github.com/astropy/astropy/pull/10744 first ๐Ÿ˜œ
* will wait for a response from this comment of yours from 25 seconds ago ๐Ÿ˜‚ https://github.com/mozilla/bleach/pull/558#issuecomment-694861882
13:17:52
@cadair:cadair.comCadair
In reply to @slack_astropy_U75UFQL6P:openastronomy.org
But if it's a non-controversial PR, I think it's ok to merge if no one else responds or takes action over a few days, or if there is some other time urgency (like, a fix needed for other PRs). All of that conditional on having a few approvals on the PR!
imo, if it's been approved it should be merged. If you don't want it to be merged don't approve it ๐Ÿ˜› (I see no issues with self-merge)
13:18:29
@slack_astropy_U8PV7G5G8:openastronomy.orgastrojuanluScreenshot_2020-09-18 Release v3 2 1 Security fixes ยท mozilla bleach.png
Download Screenshot_2020-09-18 Release v3 2 1 Security fixes ยท mozilla bleach.png
13:26:40
@slack_astropy_U8PV7G5G8:openastronomy.orgastrojuanlu yes ๐Ÿ˜‰ 13:26:40
@slack_astropy_U774ARTKR:openastronomy.orgpllim In that case, after it is on PyPI, you can restart the jobs and see what happens. ๐Ÿคž 13:33:32
21 Sep 2020
@slack_astropy_U8PV7G5G8:openastronomy.orgastrojuanlu I know there's an issue where changelog tools have been discussed recently, but can't find it now. anyway, just saw this on Twitter https://github.com/nedbat/scriv 00:55:47
@slack_astropy_U07529085:openastronomy.orgastrofrog There was a thread on astropy-dev 12:07:43
@slack_astropy_U07529085:openastronomy.orgastrofrog Sorry several threads! 12:23:33
@slack_astropy_U07529085:openastronomy.orgastrofrog Probably one of the longest running unresolved infrastructure discussions ๐Ÿ˜‚ 12:24:25
@slack_astropy_U07529085:openastronomy.orgastrofrog Scirv looks similar to town crier? 12:25:46
@slack_astropy_U774ARTKR:openastronomy.orgpllim There is also an issue at https://github.com/astropy/astropy/issues/10334 12:48:40

There are no newer messages yet.


Back to Room List