| 17 Sep 2020 |
 tomaldcroft | In reply to@slack_astropy_U774ARTKR:openastronomy.org
Perhaps E. M. Bray will have ideas. And of course in https://github.com/astropy/astropy/pull/10743 I just tried [docs-only] but it is still running the full travis CI, and for bonus it is failing now for reasons that should be unrelated to my trivial docs update. Sigh. | 13:50:48 |
 pllim | In reply to@slack_astropy_U0LE97SBD:openastronomy.org
And of course in https://github.com/astropy/astropy/pull/10743 I just tried [docs-only] but it is still running the full travis CI, and for bonus it is failing now for reasons that should be unrelated to my trivial docs update. Sigh. Yeah, bleach 3.2.0 broke stuff. I am working on that one. | 13:51:39 |
| pllim | In reply to@slack_astropy_U774ARTKR:openastronomy.org
Yeah, bleach 3.2.0 broke stuff. I am working on that one. p.s. Use [ci skip] for docs only. RTD doesn't understand it yet. | 13:52:00 |
| tomaldcroft | In reply to@slack_astropy_U774ARTKR:openastronomy.org
p.s. Use [ci skip] for docs only. RTD doesn't understand it yet. Ugh, always something! I didn't even know about that CONTRIBUTING.md. For me at least this information should be in the developer docs. | 13:54:51 |
 astrochun | In reply toundefined
Yea, as a newbie I was confused between "skip ci" and "ci skip" in the documentation. | 15:55:03 |
| astrochun | In reply toundefined
(edited) ... "ci skip" => ... "ci skip" in the documentation. | 15:55:28 |
| pllim | In reply to@slack_astropy_U0160UQFTLK:openastronomy.org
Yea, as a newbie I was confused between "skip ci" and "ci skip" in the documentation. They are the same thing, no dash though. 🙂 | 15:55:51 |
| astrochun | In reply to@slack_astropy_U774ARTKR:openastronomy.org
They are the same thing, no dash though. 🙂 Right, but I vaguely remember that the documentation had used it interchangeably. | 15:57:59 |
| 18 Sep 2020 |
|  Jielai Zhang joined the room. | 08:56:39 |
| Jielai Zhang changed their display name from slack_astropy_U01AHJH463Z to Jielai Zhang. | 09:16:28 |
| Jielai Zhang set a profile picture. | 09:16:29 |
| Jielai Zhang changed their profile picture. | 09:17:36 |
 astrojuanlu | question: I am a maintaner of a certain subpackage, and two other co-maintainers have given their explicit Approval ✔️ on an apparently non-controversial pull request. should I wait for someone else to merge it, or should I merge it myself? (case in point: https://github.com/astropy/astropy/pull/10727) | 13:02:59 |
| astrojuanlu | * question: I am a maintaner of a certain subpackage, and two other co-maintainers have given their explicit Approval ✔️ on an apparently non-controversial pull request. should I wait for someone else to merge it, or should I merge it myself? (case in point: https://github.com/astropy/astropy/pull/10727) | 13:03:07 |
 adrn | I usually still wait for (or prod) someone else to merge (feel free to ping me on slack 🙂) | 13:05:37 |
| astrojuanlu | thanks adrn ! just force pushed to fix the conflict, will ping you when the CI is green | 13:06:19 |
| adrn | But if it's a non-controversial PR, I think it's ok to merge if no one else responds or takes action over a few days, or if there is some other time urgency (like, a fix needed for other PRs). All of that conditional on having a few approvals on the PR! | 13:07:02 |
| pllim | Before your CI will pass again, you need to approve and merge my https://github.com/astropy/astropy/pull/10744 first 😜 | 13:12:01 |
| astrojuanlu | will wait for a response from this comment of yours from 25 seconds ago 😂 https://github.com/mozilla/bleach/pull/558#issuecomment-694861882 | 13:17:49 |
| astrojuanlu | In reply to @slack_astropy_U774ARTKR:openastronomy.org
Before your CI will pass again, you need to approve and merge my https://github.com/astropy/astropy/pull/10744 first 😜 * will wait for a response from this comment of yours from 25 seconds ago 😂 https://github.com/mozilla/bleach/pull/558#issuecomment-694861882 | 13:17:52 |
 Cadair | In reply to @slack_astropy_U75UFQL6P:openastronomy.org
But if it's a non-controversial PR, I think it's ok to merge if no one else responds or takes action over a few days, or if there is some other time urgency (like, a fix needed for other PRs). All of that conditional on having a few approvals on the PR! imo, if it's been approved it should be merged. If you don't want it to be merged don't approve it 😛 (I see no issues with self-merge) | 13:18:29 |
 astrojuanlu | 
Download Screenshot_2020-09-18 Release v3 2 1 Security fixes · mozilla bleach.png | 13:26:40 |
| astrojuanlu | yes 😉 | 13:26:40 |
| pllim | In that case, after it is on PyPI, you can restart the jobs and see what happens. 🤞 | 13:33:32 |
| 21 Sep 2020 |
| astrojuanlu | I know there's an issue where changelog tools have been discussed recently, but can't find it now. anyway, just saw this on Twitter https://github.com/nedbat/scriv | 00:55:47 |
 astrofrog | There was a thread on astropy-dev | 12:07:43 |
| astrofrog | Sorry several threads! | 12:23:33 |
| astrofrog | Probably one of the longest running unresolved infrastructure discussions 😂 | 12:24:25 |
| astrofrog | Scirv looks similar to town crier? | 12:25:46 |
| pllim | There is also an issue at https://github.com/astropy/astropy/issues/10334 | 12:48:40 |
