24 Apr 2024 |
Kartik Soneji | * Interesting, but why would an OpenSSL bug cause the crash only when models are returned from a function? Printing the response shows the query is successful. | 14:50:58 |
Kartik Soneji | Also, looks like I can replicate the crash on the latest diesel version too. | 14:54:25 |
Kartik Soneji | I am using pg 16, let me try setting sslmode=disable | 14:55:10 |
weiznich | In that case I really would appreciate a minimal example. | 15:04:05 |
weiznich | That might be a bug but that’s hard to say without details. | 15:05:27 |
Kartik Soneji | Looks like it was the openssl bug, adding ?sslmode=disable to the connection string fixes it. | 15:07:17 |
Kartik Soneji | I'm updating to pg 16.2, thanks for the tip, would never have figured that out on my own! | 15:07:49 |
weiznich | The important bit is libpq and not all of Postgres. | 15:08:21 |
weiznich | But it’s good to know that this is resolved. | 15:08:46 |
Kartik Soneji | In reply to @weiznich-55bcb4c20fc9f982beabc3ad:gitter.im The important bit is libpq and not all of Postgres. Yeah, but the only thing worse than having a buggy version of Postgres is having both one buggy and one good version on the same system :) | 15:10:50 |
weiznich | In reply to @kartiksoneji_gitlab:gitter.im Interesting, but why would an OpenSSL bug cause the crash only when models are returned from a function? Printing the response shows the query is successful. Well it's a heap corruption somewhere, that is in this case only detected at a later point. | 15:14:36 |
weiznich | These kind of bugs are usually not localized, which means you get the crash somewhere else than where the issue was caused. | 15:15:07 |
Kartik Soneji | I see. | 15:22:40 |
Kartik Soneji | Happy to report pg 16.2 runs with ssl too. | 15:23:03 |
Kartik Soneji | Thanks again. | 15:23:06 |
25 Apr 2024 |
dlk9999 | In reply to @dlk9999:gitter.im Brand newbie here. I have (seemingly successfully) intalled diesel_cli in my Linux system, but my terminal does not seem to find the diesel command. Any ideas welcome. Got it! You were right - I needed to add my diesel directory in .cargo/bin to the path. Thanks! | 02:28:38 |
hgzimmerman (Henry Zimmerman) | Hello, about 6 months ago I contributed a tiny bugfix regarding union support with "postgres" vs "postgres_backend" feature flags, which was merged into master.
I've noticed that it hasn't been incorporated into any subsequent releases. I assume that this is a mistake due to what I assume is a more involved than usual release process, and that commit was missed.
For whatever reason it isn't in tagged release, but is on master still. https://github.com/diesel-rs/diesel/blob/master/diesel/src/query_builder/combination_clause.rs#L237 https://github.com/diesel-rs/diesel/blob/v2.1.6/diesel/src/query_builder/combination_clause.rs#L237
Is there anything I can do to get it incorporated in the next release?
| 12:32:28 |
weiznich | Well we only include fixes into patch releases that people are actively asking for at the release time or such fixes that we need on our own. That likely means we just missed that one. By default all changes are released as part of the next feature release. | 12:34:00 |
HenryZimmerman | Redacted or Malformed Event | 12:36:29 |
hgzimmerman (Henry Zimmerman) | Thanks for the clarification. | 12:37:03 |
weiznich | I will mark it as maybe-backport so that we include it if we do another patch release (I'm not sure about that). | 12:42:53 |
hgzimmerman (Henry Zimmerman) | Thanks! That sounds about right, as this isn't a critical issue for us, but is more of a "nice to have". | 12:44:39 |
weiznich | I would suggest to remind me about this in ~4weeks if we haven't cut a new release until then. | 12:46:10 |
26 Apr 2024 |
| @gabrielhansson-59cbfd39d73408ce4f77a2b5:gitter.im left the room. | 07:16:55 |
silence_zhpf | How can I build an app which is based on diesel with the target x86_64-unknown-linux-musl ? When I run the command cargo build --release --target x86_64-unknown-linux-musl , it said ld.lld: error: unable to find library -lmysqlclient ... | 09:24:36 |
weiznich | You need to provide a version of libmysqlclient that is compatible with your target. | 09:26:46 |
weiznich | That likely means you need to build libmysqlclient from scratch with the musl toolchain. | 09:27:09 |
silence_zhpf | That sounds not so good... | 09:28:18 |
weiznich | Well, to be clear here: I only consider targets that are tested in our CI as officially supported. Anything else is nice to have and might work or not. This is also the case for the musl target, so your are on your own there. | 09:29:57 |
weiznich | Although we are always open to accept fixes/improvements for those not officially supported targets. | 09:30:47 |