biemster (biemster) commented on merge request !62 in Qualcomm Snapdragon 845 Mainline / Linux: Draft: Oneplus6/nfc
I can reproduce @phodina test results on the 6.8 branch now, next test is reading a tag. If that works is there interest in an MR?

David Heidelberg (okias) opened merge request !89 drm/msm: Small uabi fixes in Qualcomm Snapdragon 845 Mainline / Linux

biemster (biemster) commented on merge request !62 in Qualcomm Snapdragon 845 Mainline / Linux: Draft: Oneplus6/nfc
Proper usage of these NXP readers seems to require libnfc-nci, and not the usual libnfc. There doesn't seem to be an aport for this (I'm wondering how the OnePlus 5 solves this, if at all)

biemster (biemster) commented on merge request !62 in Qualcomm Snapdragon 845 Mainline / Linux: Draft: Oneplus6/nfc
According to the application note AN11697 the kernel driver and dts changes are not even needed at all, just access to the correct i2c bus (/dev/i2c-3) and the enable (12) and irq (63) pins through /dev/gpio* should suffice.
Also the AUR has a PKGBUILD already for this: https://aur.archlinux.org/packages/libnfc-nci-alt
This will be my approach for now, until I get stuck / succeed.

In reply to @_discord_1021651615809286154:t2bot.io
caleb https://twitter.com/calebccff/status/1392588311298854919 What are the two specific points for grounding here? Point A is connected to point C. Point B is the ground.

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
I've been trying to revive the MR since it did not get merged, but it seems more iteration might be necessary to do this properly. Can we reopen this issue @calebccff ?
For one thing the reader in the 6T is reported as a PN80T by libnfc-nci (which might have a pn544 inside though). This lib seems to be able to actually read tags, which might not have worked in the original MR.

Also I could not find any evidence that this currently works on the OP5, apart from detecting a tag.

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
Apparently the PN80T has a pn553, but on the plus side there appears to be a driver here: https://github.com/NXPNFCProject/NXPNFC_I2CDriver/tree/master/pn8xT/pn553-i2c

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
I've started a basic userspace driver in python here: https://github.com/biemster/pmos-openbox-conky/blob/main/nxp_nci_i2c.py. It only requires https://github.com/vsergeev/python-periphery which is a pure python library (no dev env needed, just do python setup.py install on the phone)

For now it just resets the chip and requests the chip ID:

~/nfc$ sudo ./nxp_nci_i2c.py -c
>> 20 00 01 01
<< 40 00 03 00 10 01
>> 20 01 02 00 00
<< 40 01 19 00 03 0E 02 01 08 00 01 02 03 80 82 83 84 02 5C 03 FF 02 00 04 51 11 21 1F
Chip ID 0x51 (PN553 B0 + P73 , NQ440, NQ330, PN80T, PN80S, PN81F, PN81T), FW ver 11.21.1f

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
With the NFC.patch and nxp_nci_i2c.py userspace driver I guess we can set the NFC entry in the device wiki to green/works?

~/nfc$ sudo ./nxp_nci_i2c.py --listen
[sudo] password for user: 
Chip ID 0x51 (PN553 B0 + P73 , NQ440, NQ330, PN80T, PN80S, PN81F, PN81T), FW ver 11.21.1f
* Tag detected: Mifare Ultralight
* Tag detected: Mifare Ultralight
* Tag detected: ISO DEP - Type B
* Tag detected: ISO DEP - Type B
* Tag detected: Mifare Classic
* Tag detected: Mifare Classic
^CSwitching off NFCC

soyer (soyer) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
Does reading work too?

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
@soyer I wrote a bit on this in the original MR (https://gitlab.com/sdm845-mainline/linux/-/merge_requests/62#note_1807139177). I can read an ultralight using the official libnfc-nci stack and demo app, after adapting it to use libgpiod:

$ sudo nfcDemoApp poll
#########################################################################################
##                                       NFC demo                                      ##
#########################################################################################
##                                 Poll mode activated                                 ##
#########################################################################################
                              ... press enter to quit ...

Waiting for a Tag/Device...

    NFC Tag Found

        Type :         'Type A - Mifare Ul'
        NFCID1 :        '04 50 9D 7A C5 2B 80 '
        NDEF Content : NO, mode=1, tech=9

    MIFARE UL card
        Mifare Read command: 30 01 

        Mifare Read command sent
        Response : 
        04 50 9D 41 14 48 00 00 04 50 9D 41 7A C5 2B 80 

    NFC Tag Lost

Waiting for a Tag/Device...

    NFC Tag Found

        Type :         'Type A - Mifare Classic'
        NFCID1 :        'F9 C5 EF 9B '
        NDEF Content : NO, mode=1, tech=8

        Mifare Authenticate command sent
        Response : 
        40 03 

        Mifare Read command sent
        Response : 
        10 04 00 

^C

Dylan Van Assche (dylanvanassche) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
Can you do card emulation? I think not as it is TrustZone stuff?

biemster (biemster) commented on issue #31 in Qualcomm Snapdragon 845 Mainline / Linux: OnePlus6 NFC
That's next on my list, but I don't have a second reader so that might take a while. I don't think it depends on TrustZone though, for sure not the dumb cards like the ultralights.