24 Nov 2020 |
@krisastern:matrix.org | Sure, how about adapting an existing Sphinx theme from the one used in SunPy? | 17:21:49 |
@krisastern:matrix.org | I will open an issue for that soon ๐ | 17:22:06 |
@rachitt_shah:matrix.org | I haven't explored the SunPy repo.
Would like to work once I get used to the codebase ๐ | 17:22:54 |
@rachitt_shah:matrix.org | I would need to look up how to use Sphinx on a repo tho. | 17:23:25 |
@krisastern:matrix.org | Sure: https://www.sphinx-doc.org/en/master/ | 17:26:02 |
@krisastern:matrix.org | This is good for background with Sphinx themes | 17:26:31 |
@krisastern:matrix.org | This is the theme concerned: https://github.com/sunpy/sunpy-sphinx-theme | 17:28:53 |
@raahulsingh:matrix.org | Hi rachitt_shah! Welcome | 17:33:15 |
@rachitt_shah:matrix.org |
This is good for background with Sphinx themes
Surely will look it up!
| 17:34:33 |
@rachitt_shah:matrix.org |
Hi rachitt_shah! Welcome
Thank you Raahul!
| 17:34:47 |
@rachitt_shah:matrix.org | For the style guide, it's about the different cases right?
Issue 91? | 18:00:48 |
@rachitt_shah:matrix.org | Like camel case and so on? | 18:01:01 |
@krisastern:matrix.org | Sure | 20:53:08 |
@krisastern:matrix.org | Unless Raahul disagrees | 20:53:38 |
@krisastern:matrix.org | Think we will need a style guide like one after Googleโs for example: https://github.com/google/styleguide | 23:01:21 |
@krisastern:matrix.org | Letโs base our style guide discussion off that doc | 23:02:05 |
@krisastern:matrix.org | #91 | 23:02:21 |
Github | https://github.com/wildfirepy/wildfirepy/issues/91 : A style guide for docs | 23:02:22 |
@krisastern:matrix.org | In reply to @rachitt_shah:matrix.org For the style guide, it's about the different cases right?
Issue 91? Good question | 23:03:46 |
@krisastern:matrix.org | I almost forgot I wrote that issue | 23:04:07 |
@krisastern:matrix.org | ๐
| 23:05:05 |
25 Nov 2020 |
@rachitt_shah:matrix.org |
Think we will need a style guide like one after Googleโs for example: https://github.com/google/styleguide
Understood. I haven't worked on style guides before,so this would be learning for me.
| 04:44:06 |
@rachitt_shah:matrix.org | I'll try to make a PR | 04:44:19 |
@krisastern:matrix.org | No worries, a first for me too... Should be fun with additional work on package-dependencies as well as noted in the issue. Take you time ๐๐ผ | 04:45:48 |
@rachitt_shah:matrix.org | Yes! The package dependencies seems fun to work on. | 04:46:46 |
@krisastern:matrix.org | Yup ๐๐ผ agreed | 04:47:04 |
@rachitt_shah:matrix.org | Will update here as I learn and try to create the style guide | 04:47:13 |
@krisastern:matrix.org | Cool, give it at least two weeks worth of part-time work ๐๐ผ | 04:47:47 |
@rachitt_shah:matrix.org | Surely. as i'm starting from ground up,will take time | 04:48:20 |
@krisastern:matrix.org | Sure ๐ | 04:48:34 |