!hwZqSYihGPuhDdIzIP:matrix.org

cylc general

11 Members
1 Servers

Load older messages


Timestamp Message
25 Mar 2019
04:49:10@revilo666:matrix.orgHilary Oliverhttps://github.com/cylc/cylc/issues/1249
04:49:15@kinow:matrix.orgBruno P. KinoshitaWe can probably remove at least the deprecated ones I guess?
04:49:24@revilo666:matrix.orgHilary OliverYes.
04:50:03@revilo666:matrix.orgHilary Oliver Could be part of Oliver Sanders new one: https://github.com/cylc/cylc/issues/2972
04:52:33@kinow:matrix.orgBruno P. KinoshitaI like that #2972 covers more what's used to parse and call commands. While #1249 appears to be more about changes in the commands that will give a better user experience, and also simplify dev maintenance.
04:52:54@revilo666:matrix.orgHilary OliverTrue dat.
04:55:45@kinow:matrix.orgBruno P. Kinoshita

So there are 6 commands mentioned here: https://github.com/cylc/cylc/issues/2983

And one deprecated mentioned here: https://github.com/cylc/cylc/issues/2980

I could link them to another ticket, or close in favour of a single ticket... WDYT? the test-battery can be done against master, then I'd just need to rebase setup.py branch... or do it right in the setup.py branch...

04:56:38@kinow:matrix.orgBruno P. Kinoshita(not talking about removing all these commands, but about moving elsewhere... maybe remove the licence, but definitely drop the cylc cat-state I believe)
04:57:19@kinow:matrix.orgBruno P. KinoshitaMaybe move everything to https://github.com/cylc/cylc/issues/1249 ? Or create a task with check boxes and link to the existing issues
04:58:29@revilo666:matrix.orgHilary OliverI think 1249 encompasses all of that, more or less. Maybe revive that, combine with your new ones, and promote to the cylc-8 milestone?
04:59:22@kinow:matrix.orgBruno P. KinoshitaAgreed. Easier as these are all related. And users would probably prefer to read one ticket about it in the Changelog rather than 7 or 8 doing pretty much the same thing.
05:13:51@kinow:matrix.orgBruno P. Kinoshita Hilary Oliver: gave it a try: https://github.com/cylc/cylc/issues/1249 👍
05:14:18@revilo666:matrix.orgHilary Oliver👍 thanks
09:23:22@oliver-sanders:matrix.orgOliver Sanders
What if we dropped "cylc test-battery" as a top-level command, and put a test running command inside the test directory.
09:24:08@oliver-sanders:matrix.orgOliver SandersI've written a quick script which will run the cylc functional tests under pytest getting rid of the cylc test-battery command altogether.
09:24:55@oliver-sanders:matrix.orgOliver Sanders If we could do something like pytest --functional-tests that might be a viable alternative
09:25:15@revilo666:matrix.orgHilary Oliver👍
10:33:47@matthewrmshin:matrix.orgMatt Shin I am very keen to see our tests fully migrated to a pure Python framework such as Pytest and get rid of our dependency on Perl's prove command. There is a lot of history in the original decision to use a Perl command, but now that Python's own testing framework is so mature, there is no reason to not migrate any more. Resource consideration is our only barrier at the moment. (But I think we should just take a small hit for the big gain.)
10:39:13@oliver-sanders:matrix.orgOliver SandersOne advantage of moving to pytest is that test always get run in verbose mode but the output is only shown if the test fails.
19:35:11@revilo666:matrix.orgHilary Oliver 'scuse my ignorance, but presumably moving to pytest would require rewriting all of our bash test scripts as Python? That could be quite a big job, although in most cases pretty simple. There's currently 648 '.t files.
20:34:13@matthewrmshin:matrix.orgMatt Shin We can do it in steps. 1. Get pytest to do what prove does - integrate with a TAP parser. 2. Migrate any tests that can be done as unit tests to become Python tests. 3. Migrate the rest to Python. 1 should be easy. 2 will take time, but should be easy enough. 3 will take the most time and can be done when opportunity arises.
20:35:20@revilo666:matrix.orgHilary Oliver👍
20:50:31@kinow:matrix.orgBruno P. Kinoshita👍🎉
26 Mar 2019
08:50:32@kinow:matrix.orgBruno P. KinoshitaFor those using anaconda (might take a little to be available I think) or installing from sources, python 3.7.3 has been released https://docs.python.org/3.7/whatsnew/changelog.html#python-3-7-3-final
12:48:56@oliver-sanders:matrix.orgOliver Sanders
presumably moving to pytest would require rewriting all of our bash test scripts as Python
12:49:58@oliver-sanders:matrix.orgOliver SandersPytest is both a framework for running tests and a testing engine. I've written a plugin which enables it to run our current tests (written in Bash).
15:43:59@sadielbartholomew:matrix.orgSadie Bartholomew Congratulations Bruno P. Kinoshita , I have just seen you have closed the 1000th Issue on cylc/cylc: https://github.com/cylc/cylc/issues/3039 🎊 That's a nice milestone to hit!
18:00:20@kinow:matrix.orgBruno P. Kinoshita😀 thanks Sadie Bartholomew ! Not intentional but nice indeed!
18:21:41@kinow:matrix.orgBruno P. Kinoshita

Pytest is both a framework for running tests and a testing engine. I've written a plugin which enables it to run our current tests (written in Bash).

Awesome news! Happy to try that out whenever it's ready. I'm thinking in making test-profile just take the cylcdir as an argument, in order to get setup.py working.

But happy to try this plugin if it's not too hard to implement it

19:30:27@revilo666:matrix.orgHilary Oliver

I'm thinking in making test-profile just take the cylcdir as an argument,

I think that would be fine, even if an interim measure.


There are no newer messages yet.


Back to Room List