19 Apr 2024 |
corvus | https://ci.gerritcodereview.com/t/gerrit/stream/63e5fd1e5abf4154a0ee4cecfa0006d2?logfile=console.log | 21:52:18 |
corvus | https://ci.gerritcodereview.com/t/gerrit/build/63e5fd1e5abf4154a0ee4cecfa0006d2 looks good | 21:53:25 |
corvus | i think the only other thing to double check would be a real check job that used a node (since that was an executor-only job) | 21:53:42 |
Clark | maybe Paladox none has a change that can be rechecked in a plugin? | 21:54:12 |
corvus | https://gerrit-review.googlesource.com/c/plugins/metrics-reporter-prometheus/+/421158?tab=checks | 21:54:33 |
corvus | indeed i foud one :) | 21:54:38 |
Paladox none | Well I did recheck a few changes a few days after I upgraded the image node pool uses but I think one of the changes was merged? | 21:55:24 |
corvus | yeah, i skipped down a few in the build history to find one that wasn't merged | 21:55:49 |
Paladox none | I've done https://gerrit-review.googlesource.com/c/plugins/codemirror-editor/+/420617 | 21:56:05 |
corvus | there's some streaming log weirdness in https://ci.gerritcodereview.com/t/gerrit/stream/df9c8078f09b4541bd130a00612b71f9?logfile=console.log | 21:56:31 |
corvus | hrm okay it looks like we have some playbooks/tasks running out of order | 21:57:01 |
corvus | it looks like the log daemon starts late.. | 21:57:10 |
corvus | remote: https://gerrit-review.googlesource.com/c/zuul/config/+/421498 Re-order base pre-run tasks [NEW]
| 22:02:00 |
corvus | i think that's what we want | 22:02:04 |
Clark | corvus: there is a bug in that. you moved the roles to localhost but they need to be on all | 22:03:52 |
corvus | derp | 22:05:35 |
corvus | Clark: thanks, fixed. i just made a new play so no one has to go lookup whether roles or tasks run first :) | 22:07:05 |
corvus | (pretty sure it's roles, but still, explicit is better than implicit) | 22:07:20 |
Clark | ya we did the same in oepndev looks like. And I like the clarity of that | 22:08:20 |
Clark | I +2'd but didn't submit this one as I didn't see the issue so no sure I can check properly that it doesn't recur. Feel free to submit yourself | 22:09:31 |
corvus | done; i'll recheck again since that's a base-jobs change we didn't run through the base-test cycle | 22:10:13 |
corvus | https://ci.gerritcodereview.com/t/gerrit/stream/c454758484264de98cfb89aeda6d0745?logfile=console.log | 22:11:12 |
corvus | :/ | 22:11:36 |
corvus | okay second run is happier | 22:12:10 |
corvus | https://ci.gerritcodereview.com/t/gerrit/stream/93a9af145a54444d86a1fbf34e7c5c6a?logfile=console.log | 22:12:15 |
corvus | okay that looks good and it's past the part we changed | 22:13:44 |
corvus | i think we can call it done for now | 22:14:01 |
Clark | cool | 22:14:22 |
Paladox none | thank you both corvus and Clark ! | 22:31:48 |
corvus | you're welcome! | 22:32:50 |