| 22 Jul 2024 |
 Akashdeep Dhar | Mehmet Baran Geylani: Could you please resovle the merge conflicts https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/37#event-13597514058 ? | 08:34:08 |
| Akashdeep Dhar | Mehmet Baran Geylani: It seems like this PR depends on the earlier PR items and you cherry-picked one commit to be a part of the branch that the PR cane from. It is clean and all but it does make it difficult to test stuff. | 08:40:36 |
 @ghostcasper:matrix.org | In reply to @t0xic0der:fedora.im
Mehmet Baran Geylani: Could you please resovle the merge conflicts https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/37#event-13597514058 ? It seems you merged it | 08:56:12 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
It seems you merged it Ahhh my bad. That's the wrong link. I meant, the service endpoint tests, | 09:04:41 |
| @ghostcasper:matrix.org | In reply to @t0xic0der:fedora.im
Ahhh my bad. That's the wrong link. I meant, the service endpoint tests, Yeap working on it rn. | 09:05:06 |
| @ghostcasper:matrix.org | https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/38/
| 09:06:57 |
| @ghostcasper:matrix.org | Akashdeep Dhar: | 09:07:01 |
| Akashdeep Dhar | That was quick | 09:07:14 |
| @ghostcasper:matrix.org | Tried to move fixtures to conftest since they are used in different places | 09:07:18 |
| Akashdeep Dhar | Could you squash the commits pleasE? | 09:07:32 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
Tried to move fixtures to conftest since they are used in different places Good work - That should make testing easy. | 09:07:42 |
| @ghostcasper:matrix.org | Akashdeep Dhar Just rebased the branch. But some user test files are present in the PR. Can you check? | 09:14:10 |
|  Fabio Valentini 🤧 changed their display name from Fabio Valentini (back July 22) to Fabio Valentini. | 09:29:25 |
| Akashdeep Dhar | Be right back.
Lunching. | 09:35:21 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
Akashdeep Dhar Just rebased the branch. But some user test files are present in the PR. Can you check? In it goes. | 12:48:29 |
| @ghostcasper:matrix.org | What to do next | 12:49:22 |
| Akashdeep Dhar | Mehmet Baran Geylani: Awesome work so far.
Could you please start off with the tests for the messaging endpoint? | 12:49:23 |
| Akashdeep Dhar | I know it is not complete yet but you can fill in for the parts that are
Update the existing branch https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/31 | 12:50:04 |
| @ghostcasper:matrix.org | https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40
Just created the PR Akashdeep Dhar
| 21:31:33 |
| 23 Jul 2024 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40
Just created the PR Akashdeep Dhar
Mehmet Baran Geylani: I will take a look at it shortly. | 03:02:18 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40
Just created the PR Akashdeep Dhar
I just checked the time that you posted this message. I hope that you are not working too late. | 04:03:52 |
| Akashdeep Dhar | Mehmet Baran Geylani: I have suggested some changes https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40#pullrequestreview-2192926031 | 04:15:46 |
| @ghostcasper:matrix.org | Akashdeep Dhar please check
https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40
| 10:39:40 |
|  Joshua Strobl joined the room. | 10:49:00 |
| Akashdeep Dhar | In reply to @ghostcasper:matrix.org
Akashdeep Dhar please check
https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/40
On it | 10:49:06 |
| Akashdeep Dhar | Joshua Strobl: Welcome 👋 | 10:49:22 |
