| 25 Jul 2024 |
 @ghostcasper:matrix.org | Akashdeep DharAurélien B Anything for me to work on? | 13:10:51 |
 Aurélien B | I'll have a look at the PR Mehmet Baran Geylani , I'm finishing an update to another app first.
But there's always stuff to work on! You can look at your PR and ask yourself what a reviewer would say, for example.
You can make sure the methods are documented. You can build the documentation and make sure it's correct. | 14:34:19 |
 nirik | REMINDER: There will be a Fedora Infrastructure meeting today (2024-07-25 at 16:00 UTC in https://matrix.to/#/#meeting-3:fedoraproject.org). Please check the agenda at https://board.net/p/fedora-infra | 15:21:10 |
| nirik | REMINDER: Fedora Infrastructure meeting in 2 minutes in https://matrix.to/#/#meeting-3:fedoraproject.org. Please check the agenda at https://board.net/p/fedora-infra | 15:58:12 |
|  The Exorcist changed their profile picture. | 19:05:35 |
| The Exorcist removed their profile picture. | 19:05:56 |
| The Exorcist set a profile picture. | 19:06:22 |
| 26 Jul 2024 |
| Aurélien B | Mehmet Baran Geylani: Another important thing that you can do if you feel like there's nothing on your plate, is run the unit tests locally and look at the HTML generated in ./htmlcov/index.html. It will tell you which lines are covered by unit tests and which are not. The goal is to get to 100%! :-) | 07:34:29 |
| Aurélien B | OK I've made quite a few updates to the code in the webhook-to-fedora-messaging repo, please pull asap or you'll get conflicts!
The good thing is that now CI passes. | 09:47:52 |
| Aurélien B | Also, once you've pulled and rebased please run pre-commit install to have enable on-commit checks | 09:48:34 |
| The Exorcist changed their profile picture. | 14:37:05 |
| 30 Jul 2024 |
| @ghostcasper:matrix.org | https://github.com/fedora-infra/webhook-to-fedora-messaging/issues/45
Please check
Akashdeep Dhar Aurélien B
| 09:32:32 |
| @ghostcasper:matrix.org | Hey Aurélien B , seen that flask-restx requires paths to be referenced per view. Is there a way to use different routes in the same class (view)? | 11:09:04 |
| @ghostcasper:matrix.org | Also, should I remove and make the param referenced in this default or set it to an optimal value? | 11:11:42 |
| @ghostcasper:matrix.org | Redacted or Malformed Event | 11:19:32 |
| @ghostcasper:matrix.org | * Also, should I remove and make the param referenced in this default or set it to an optimal value?
https://github.com/fedora-infra/webhook-to-fedora-messaging/issues/45
Akashdeep Dhar Aurélien B
| 11:19:47 |
| @ghostcasper:matrix.org | Guess there's an issue with sending a GET request with body in flask-restx Aurélien B Akashdeep Dhar | 12:54:32 |
| @ghostcasper:matrix.org | * Guess there's an issue with sending a GET request with body in flask-restx Aurélien B Akashdeep Dhar. Should I change the endpoints and use query params for endpoints that receive GET requests? | 12:58:03 |
| Aurélien B | Mehmet Baran Geylani: are you sure? It looks like Flask-RESTX can look into the body: https://flask-restx.readthedocs.io/en/latest/parsing.html#argument-locations. Does it not work with GET requests? | 13:07:47 |
| @ghostcasper:matrix.org | https://swagger.io/docs/specification/2-0/describing-request-body/
@abompard:fedora.im guess here it says get requests can't have body | 13:12:10 |
| Aurélien B | Ah, so it's swagger that does not support it. Okay, we can maybe migrate them to query params. Flask-RestX will be able to read both locations anyway. | 13:14:21 |
| @ghostcasper:matrix.org | Sure let me change the endpoints then. @abompard:fedora.im | 13:16:44 |
| @ghostcasper:matrix.org | Tests will also need to be changed. | 13:17:07 |
| @ghostcasper:matrix.org | In reply to @ghostcasper:matrix.org
Also, should I remove and make the param referenced in this default or set it to an optimal value?
https://github.com/fedora-infra/webhook-to-fedora-messaging/issues/45
Akashdeep Dhar Aurélien B
Can you check the other ones please | 13:19:19 |
|  Anton Medvedev set a profile picture. | 14:13:52 |
|  abdel joined the room. | 21:10:51 |
| abdel set a profile picture. | 21:31:28 |
| 31 Jul 2024 |
| @ghostcasper:matrix.org | Akashdeep DharAurélien B any update guys? Is there an issue with google meet? | 07:08:43 |
 Akashdeep Dhar | Mehmet Baran Geylani: I have moved the meeting down by 30 minutes - It will now start in 20 minutes from now | 07:10:16 |
| Akashdeep Dhar | You should have received an updated invitation prior to this informing about the same | 07:10:33 |
