1 Aug 2024 |
Akashdeep Dhar | In reply to @abompard:fedora.im you don't have to make your endpoint async, in that case fastapi will call them in a threadpool Gotta read more on this before I make a comment đŸ˜… | 05:43:14 |
Akashdeep Dhar | In reply to @abompard:fedora.im https://fastapi.tiangolo.com/async/?h=threadpool#path-operation-functions Wow - Thanks for saving me the googling | 05:43:26 |
Akashdeep Dhar | Aurélien B++ | 05:43:30 |
zodbot | t0xic0der gave a cookie to abompard. They now have 112 cookies, 3 of which were obtained in the Fedora 40 release cycle
| 05:43:32 |
Aurélien B | having both a sync and async db connection is a path to madness. We tried that on FMN and had to go back | 05:43:52 |
Akashdeep Dhar | We did that on CentOS/Duffy and I was "this" close to losing my will to live. | 05:44:19 |
Aurélien B | yep. | 05:44:31 |
Akashdeep Dhar | Cool - I was halfway through with the service endpoint so - I will push the incomplete code and pause stuff for now. | 05:45:13 |
Akashdeep Dhar | Stuff = Porting to Flask-OpenAPI3 | 05:45:22 |
Aurélien B | yeah | 05:45:28 |
Akashdeep Dhar | Aurélien B: Do you want some more time to think it through or should I begin with the FastAPI port? | 05:45:42 |
Aurélien B | Nah, go ahead, I'll find a way eventually | 05:45:59 |
Akashdeep Dhar | Anything works - I will get back to Forgejo ARC then | 05:46:06 |
Akashdeep Dhar | Ok then - starting with the port | 05:46:14 |
Aurélien B | Cool | 05:46:19 |
Aurélien B | Let's do sync endpoints for now | 05:46:52 |
Akashdeep Dhar | Works | 05:47:09 |
Akashdeep Dhar | One endpoint per PR | 05:47:17 |
Aurélien B | yeah | 05:47:22 |
Akashdeep Dhar | Because one endpoint also means their request model and their response model and ... | 05:47:37 |
Aurélien B | yep! | 05:47:44 |
Akashdeep Dhar | Also let us focus on the tests once we are done with ALL the endpoints | 05:48:41 |
Akashdeep Dhar | Should keep us from slowing down more than we already are | 05:48:56 |
Aurélien B | yeah, priority is still the main message endpoint | 05:52:02 |
Akashdeep Dhar | Mehmet Baran Geylani: Draft https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/57 | 08:11:26 |
Akashdeep Dhar | Aurélien B: Are you around? I have a question regarding the creation of an object using sqlalchemy_helpers. | 11:52:17 |
Aurélien B | yes | 12:13:05 |
Aurélien B | if you're still around | 12:13:11 |
Akashdeep Dhar | I am | 12:14:44 |
Akashdeep Dhar | Wanna jump on a call ? | 12:14:54 |