Trying to run commit by myself is bad as then I would also have to take care of the rollback when abnormal states are faced.

    try:
        print("Before")
        session.flush()
        data = UserExternal.from_orm(made_user).dict()
        session.commit()
        print("After")
    except IntegrityError as expt:
        logger.logger_object.warning("Uniquness constraint failed - Please try again")
        logger.logger_object.warning(str(expt))
        raise HTTPException(HTTP_409_CONFLICT, "Uniquness constraint failed - Please try again") from expt  # noqa : E501
    return {"action": "post", "user": data}

In reply to @ghostcasper:matrix.org
Seems like we have a problem, I built the message endpoint and made some tests but it seems like FastAPI somehow converts the headers to lower-case. For example X-Github-Event > x-github-event. This is ok with the W2FM application. I made the required changes but it breaks the message schema and fails when creating objects. Should I update the message schema? Aurélien B Akashdeep Dhar

In reply to @abompard:fedora.im
Thanks! Not sure what you mean by "clean things up" though. Should I review it now or wait?

In reply to @t0xic0der:fedora.im
I will clean things up later - Mehmet Baran Geylani are you taking care of the webhook-to-fedora-messaging-messages changes?

In reply to @ghostcasper:matrix.org
Yes I can

In reply to @t0xic0der:fedora.im
Please review it!
I have some stuff left from the Flask times that are not even referenced (like validate_requests etc) that I will remove later

In reply to @ghostcasper:matrix.org
Yes request variable in verify signature seems to be one of them

In reply to @ghostcasper:matrix.org
Yes I had built some code for it but didn't push. Looking forward for your changes. Will change the message schema

In reply to @t0xic0der:fedora.im
Please review it!
I have some stuff left from the Flask times that are not even referenced (like validate_requests etc) that I will remove later

In reply to @abompard:fedora.im
Hmm OK. But you need to understand that reviewing this kind of PR is going to take me at least an hour, maybe more depending on the content, so I'd rather not start reviewing something you're not 100% happy with and that you may update while I'm reviewing, or it will just waste my time.

https://github.com/fedora-infra/webhook-to-fedora-messaging-messages/pull/18

Aurélien B Akashdeep Dhar