!eqFVNIBvaoifuUlQks:matrix.org

astroquery

8 Members
4 Servers

Load older messages


SenderMessageTime
7 May 2017
@bsipocz:matrix.org@bsipocz:matrix.org

@ayushjadav: we do the testing usually with python setup.py test from the source directory

http://docs.astropy.org/en/latest/development/testguide.html#running-tests

14:41:11
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.org @bsipocz Ok, I was unaware of this. Thanks, I will start familiarizing myself with this and get some small tests done on my system. Meanwhile, I am also going through vizier right now. 14:44:26
@bsipocz:matrix.org@bsipocz:matrix.orgUsually all the dev setup is done the same way as astropy's, e.g. installing the dev version http://docs.astropy.org/en/latest/development/workflow/get_devel_version.html?highlight=%22setup.py%20develop%22#activate-the-development-version-of-astropy14:44:45
@bsipocz:matrix.org@bsipocz:matrix.orgreading through the astropy dev guide is a good starting point. Some things may be outdated, if find any of those, please feel free to open a PR.14:47:51
@bsipocz:matrix.org@bsipocz:matrix.orgIt's actually very difficult to write these kind of docs by someone very familiar with the content, and having a new pair of eyes is super helpful to make things clearer14:48:36
@bsipocz:matrix.org@bsipocz:matrix.orgAlso you can create a new env the same way as it's done in the travis file. There basically a brand new conda env is created and only the dependencies of astroquery is installed.14:49:31
@bsipocz:matrix.org@bsipocz:matrix.org then python setup.py test is run with various settings 14:49:50
8 May 2017
@gitter_pllim:matrix.org@gitter_pllim:matrix.org set a profile picture.12:36:55
@gitter_pllim:matrix.org@gitter_pllim:matrix.org @AyushYadav , if you enable Travis CI webhook on your fork of Astroquery, you can also kick off Mac/Linux CI on your feature branch before opening a PR. Same goes for coveralls, I think. Hooking Appveyor requires an extra step of Appveyor help call to enable some sort of Windows thingy for your fork if you want that as well. But I think Travis should be sufficient on your own fork, as Python is usually OS agnostic, and coveralls probably not very accurate for Astroquery remote stuff. So: STEP 1 - local setup.py test --remote-data, STEP 2 - Travis on own fork, STEP 3 - open PR. 12:36:55
5 Jun 2017
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.org @bsi 14:35:56
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.org @pllim @keflavich @bsipocz I have sent you all a mail regarding the NOAO API that was released earlier today. Have a look at the link of their [client side API] (https://github.com/noao-datalab/datalab-client) for developing the module based on this. 14:38:39
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.org (edited) ... side API] (https://github.com/noao-datalab/datalab-client) for ... => ... side API](https://github.com/noao-datalab/datalab-client) for ... 14:39:13
@bsipocz:matrix.org@bsipocz:matrix.orgayadav: sounds good. As Adam said, it would be great to have a WIP PR for discussion, even if it doesn't do much we can see the skaleton, etc.14:55:37
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgAyushYadav: you here?22:17:13
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.orgyeah22:21:17
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgnoao is doing something pretty weird indeed22:21:55
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.orgDid you see that network console page for the POST query. 22:22:30
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgin principle this should work:22:22:37
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org result1 = S.post('http://archive.noao.edu/search/send_simple_query', data={'ra':148.888, 'dec':69.065, 'searchbox':30.0,}) 22:22:39
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org result2 = S.post('http://archive.noao.edu/search/list_resources') 22:22:39
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org but it doesn't. 22:22:42
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgwhat network console page?22:22:56
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.orgI am referring to the Network tab in the Dev tools. 22:23:50
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.orgI used POSTMAN (a client to test and run various types of web requests easily) but it is also failing to reproduce the results that we are getting on the page.22:24:38
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org I'm not familiar with POSTMAN 22:27:26
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org but I am using the network tab in Chrome's inspector 22:27:34
@gitter_ayushyadav:matrix.org@gitter_ayushyadav:matrix.orgSo how do you explain the way this query is working? Because it is not clear to me what is happening here. 22:28:30
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgnot easily22:29:19
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.orgthey are doing something incorrect.22:29:24
@gitter_keflavich:matrix.org@gitter_keflavich:matrix.org the first very weird thing is that requests is interacting… wrongly… with the page. 22:29:48

Show newer messages


Back to Room ListRoom Version: