!ePwsQChmTyRFwMijYe:matrix.org

groupincome

37 Members
www.groupincome.org16 Servers

Load older messages


Timestamp Message
3 Apr 2020
00:01:24@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p Yes I added it in its own commit
00:17:52@_slack_okturtles_U02KCCG4S:matrix.orggreg πŸ˜„πŸ˜„πŸ˜„πŸ˜„πŸ˜„πŸ˜„πŸ˜„ πŸ₯³ Merged Application Logs! πŸ˜„
00:18:28@_slack_okturtles_U02KCCG4S:matrix.orggreg great job 9SGRFKT6! phew! πŸ˜„
00:18:38@_slack_okturtles_U02KCCG4S:matrix.orggreg that was a challenging one!
00:18:52@_slack_okturtles_U02KCCG4S:matrix.orggreg thanks for bearing with me in all the back and forth of the reviews!
00:19:29@_slack_okturtles_U02KCCG4S:matrix.orggreg FYI, now there's a merge conflict with: https://github.com/okTurtles/group-income-simple/pull/879
00:28:56@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p woooow that was the most commented PR for sure! It was a challenging journey, a lot of new things learned πŸ˜„
00:36:11@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p 02KCCG4S, I fixed the conflicts with PR #879
00:36:34@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 awesome i will check it out and verify the tests pass locally since travis is (still?) broken?
00:39:38@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 it's strange, it's running it here: https://travis-ci.org/github/okTurtles/group-income-simple but for some reason it's not integrating with GH...
00:43:21@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p hum… 02KCCG4S i can see it on GH as usual, with a green pipeline.
00:43:47@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 you're right! it's magically working again... it used to link to Travis while it was building... maybe they removed that
00:44:24@_slack_okturtles_U02KCCG4S:matrix.orggreg Merged!
00:49:18@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 review done for moment removal PR too! πŸ˜„ https://github.com/okTurtles/group-income-simple/pull/880#pullrequestreview-386870964
00:49:37@_slack_okturtles_U02KCCG4S:matrix.orggreg I wasn't expecting to get this much work done today, but what do you know, miracles do happen! πŸ˜„
00:53:22@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 oh and it might be datems = Date.now instead of datems = Date.now()... not sure
01:02:05@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p I’ll check it in a bit
01:55:25@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 you've been pushing out PR after PR tonight! Amazing! And also probably way past your bedtime! πŸ˜„
01:55:32@_slack_okturtles_U02KCCG4S:matrix.orggreg make sure to get plenty of sleep ^_^
01:57:14@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p 02KCCG4S and FKBGLWCV I opened a PR to standardize our error messages. This is just a POC yet, so you can give your feedback before changing +50 files. Please let me know what you think! Also, DSJWKSG4, this may affect some UX/UI, as I explained in the respective issue. Please take a look there too! PR: https://github.com/okTurtles/group-income-simple/pull/881 Issue: https://github.com/okTurtles/group-income-simple/issues/788
02:02:42@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 cool! will have a look later tomorrow perhaps! Think I'm calling it a day for now, recommend you do too, and then tomorrow if you're around maybe have a look at travis to see why it failed. I really enjoyed our mini-hackathon session today, even though I totally forgot we were going to do it! πŸ˜„
02:03:32@_slack_okturtles_U02KCCG4S:matrix.orggreg Pretty soon the sun is going to come up in Lisbon πŸ˜† you should probably get rest before you turn into a vampire
02:03:57@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p 02KCCG4S, I also updated the PR related to moment!
02:04:00@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p And yes…
02:05:01@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p you’re totally right, it’s way too late now (3am), but it’s okay once in a while eheh. I’m calling it a day too πŸ˜‰
02:06:04@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p Oh, and the sunrise here (in Porto, not Lisbon) is around 6:30h, so yeah… in 3 hours πŸ™€
02:06:16@_slack_okturtles_U02KCCG4S:matrix.orggreg have a good night πŸ™‚ πŸ›Œ
02:06:49@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p Thanks! I’ll make sure I’ll have plenty of rest during the weekend :salute: πŸ˜›
02:10:06@_slack_okturtles_U02KCCG4S:matrix.orggreg Merged "Removed Moment usage"! 🍾 https://github.com/okTurtles/group-income-simple/pull/880
4 Apr 2020
04:46:36@_slack_okturtles_U02KCCG4S:matrix.orggreg Topic for next Monday's chat: potential virtual hackathon if lockdowns extend too far into the year

There are no newer messages yet.


Back to Room List