| 3 Apr 2020 |
| 00:01:24 |  a.sandrina.p | Yes I added it in its own commit |
| 00:17:52 |  greg | 😄😄😄😄😄😄😄
🥳 Merged Application Logs! 😄 |
| 00:18:28 | greg | great job 9SGRFKT6! phew! 😄 |
| 00:18:38 | greg | that was a challenging one! |
| 00:18:52 | greg | thanks for bearing with me in all the back and forth of the reviews! |
| 00:19:29 | greg | FYI, now there's a merge conflict with: https://github.com/okTurtles/group-income-simple/pull/879 |
| 00:28:56 | a.sandrina.p | woooow that was the most commented PR for sure! It was a challenging journey, a lot of new things learned 😄 |
| 00:36:11 | a.sandrina.p | 02KCCG4S, I fixed the conflicts with PR #879 |
| 00:36:34 | greg | 9SGRFKT6 awesome i will check it out and verify the tests pass locally since travis is (still?) broken? |
| 00:39:38 | greg | 9SGRFKT6 it's strange, it's running it here: https://travis-ci.org/github/okTurtles/group-income-simple but for some reason it's not integrating with GH... |
| 00:43:21 | a.sandrina.p | hum… 02KCCG4S i can see it on GH as usual, with a green pipeline. |
| 00:43:47 | greg | 9SGRFKT6 you're right! it's magically working again... it used to link to Travis while it was building... maybe they removed that |
| 00:44:24 | greg | Merged! |
| 00:49:18 | greg | 9SGRFKT6 review done for moment removal PR too! 😄 https://github.com/okTurtles/group-income-simple/pull/880#pullrequestreview-386870964 |
| 00:49:37 | greg | I wasn't expecting to get this much work done today, but what do you know, miracles do happen! 😄 |
| 00:53:22 | greg | 9SGRFKT6 oh and it might be datems = Date.now instead of datems = Date.now()... not sure |
| 01:02:05 | a.sandrina.p | I’ll check it in a bit |
| 01:55:25 | greg | 9SGRFKT6 you've been pushing out PR after PR tonight! Amazing! And also probably way past your bedtime! 😄 |
| 01:55:32 | greg | make sure to get plenty of sleep ^_^ |
| 01:57:14 | a.sandrina.p | 02KCCG4S and FKBGLWCV I opened a PR to standardize our error messages. This is just a POC yet, so you can give your feedback before changing +50 files. Please let me know what you think!
Also, DSJWKSG4, this may affect some UX/UI, as I explained in the respective issue. Please take a look there too!
PR: https://github.com/okTurtles/group-income-simple/pull/881
Issue: https://github.com/okTurtles/group-income-simple/issues/788 |
| 02:02:42 | greg | 9SGRFKT6 cool! will have a look later tomorrow perhaps! Think I'm calling it a day for now, recommend you do too, and then tomorrow if you're around maybe have a look at travis to see why it failed. I really enjoyed our mini-hackathon session today, even though I totally forgot we were going to do it! 😄 |
| 02:03:32 | greg | Pretty soon the sun is going to come up in Lisbon 😆 you should probably get rest before you turn into a vampire |
| 02:03:57 | a.sandrina.p | 02KCCG4S, I also updated the PR related to moment! |
| 02:04:00 | a.sandrina.p | And yes… |
| 02:05:01 | a.sandrina.p | you’re totally right, it’s way too late now (3am), but it’s okay once in a while eheh.
I’m calling it a day too 😉 |
| 02:06:04 | a.sandrina.p | Oh, and the sunrise here (in Porto, not Lisbon) is around 6:30h, so yeah… in 3 hours 🙀 |
| 02:06:16 | greg | have a good night 🙂 🛌 |
| 02:06:49 | a.sandrina.p | Thanks! I’ll make sure I’ll have plenty of rest during the weekend :salute: 😛 |
| 02:10:06 | greg | Merged "Removed Moment usage"! 🍾 https://github.com/okTurtles/group-income-simple/pull/880 |
| 4 Apr 2020 |
| 04:46:36 | greg | Topic for next Monday's chat: potential virtual hackathon if lockdowns extend too far into the year |
