| 22 Jan 2021 |
 greg | Don't know why I was assigned to the switch-to-Deno issue, but removed that so it's actually up-for-grabs | 03:19:41 |
 pdatasystems | 01DQ4JGH9A I've found something regarding the failing Cypress test in your PR:
A type errors occurs appears in the browser console, from 'GroupPledgesGraph.vue' line 51:
import distributeIncome from '@utils/distribution/group-income-distribution.js'
This distributeIncome() function is an alias for the groupIncomeDistribution({ getters, monthstamp, adjusted }),
which means that it expects an object with getters.
However, at line [118] it gets called with arguments only suitable for functions formerly imported from mincome-default.js or mincome-proportional.js :
ourIncomeToReceive = distributeIncome(incomeDistribution, mincome)
.filter(i => i.to === this.ourUsername)
.reduce((acc, cur) => cur.amount + acc, 0)
So I've tried this as a possible solution, after restoring the relevant file, and that test case passed!
import distributeIncome from '@utils/distribution/mincome-proportional.js'
| 04:11:33 |
 geometricalgorithm | Good morning.
Getting coffee and looking into, 01FNNKFJBH | 06:29:17 |
| geometricalgorithm | 01FNNKFJBH after trying to create the getters from the vue state (to no avail), I have tried your approach. | 15:15:24 |
| geometricalgorithm | It eventually ends in this error: | 15:15:47 |
| geometricalgorithm | 01FNNKFJBH and 02KCCG4S the above picture is if I use the antiquated file.
If I try to use our new distribution function (in the way pushed to the PR here: https://github.com/okTurtles/group-income-simple/commit/62ec8a35d34de678db5b733b545145d8ebe13b40), we get the same error as above: | 16:00:00 |
| geometricalgorithm | It is at least starting to pass MORE of the cypress tests. | 16:01:59 |
| geometricalgorithm | With either solution. | 16:02:08 |
| greg | 01DQ4JGH9A Just a heads up: as this week I'm mostly taking it easy to recover from a second wave of whatever it was that was getting me last year (maybe covid, maybe burnout, or maybe something else entirely) I'm going to be avoiding coding much and trusting that you and others can handle investigating these issues, and meanwhile I'll be focusing on stuff that I do have the energy for, which is reviewing PRs that have passing tests, reviewing Catarina's changes to the copy for FAQs/crowdfunding, and also figuring out the recruiting stuff | 18:06:01 |
| pdatasystems | 01DQ4JGH9A There were two antiquated distribution files to try, did you try both? | 19:35:18 |
| pdatasystems | 02KCCG4S Take care! | 19:38:36 |
| greg | Thx! | 19:38:53 |
| 24 Jan 2021 |
| geometricalgorithm | 01FNNKFJBH Good question:
No, just one, and in retrospect it might have been an older version of it...
What is the most efficient way of restoring the newest-deleted-version of a file in git? Is it git cherry-pick? | 05:51:50 |
| geometricalgorithm | Looking into.
Also: if anyone is familiar with how to use Zap wallet for Android, please let me know. | 05:57:10 |
| greg | 01DQ4JGH9A have a look at “git show” | 06:00:37 |
| geometricalgorithm | Will do! | 06:00:54 |
| geometricalgorithm | Also: looking into https://btcpayserver.org/ | 06:01:15 |
| greg | Yeah, we might pair with that later | 06:01:32 |
| greg | Calling it a night for now | 06:01:39 |
| geometricalgorithm | Get some rest, homie! | 06:01:51 |
| geometricalgorithm | We got this. | 06:01:58 |
| greg | 🙇♂️ | 06:02:12 |
| pdatasystems | 01DQ4JGH9A To restore a given file from a specific branch or commit, I commonly do git restore --source branch_or_hash -- file_path | 07:45:31 |
| pdatasystems | And you can even specify multiple files to rsetore at once - see the manual page that opens when running git help restore 🙂 | 07:48:08 |
| geometricalgorithm | Relavent links for me (and maybe others) for lightning network:
https://lightninginabox.co/2018/12/how-to-install-btcpayserver-on-raspberry-pi-3-b/
https://www.ecorobotics.com.na/collections/development-kits/products/raspberry-pi-4-model-b-8gb-kit
It will take me until the next billing cycle to fully configure this setup. | 11:41:22 |
| geometricalgorithm | I am beginning to think it is the cypress tests that are broken. This error happens no matter what. | 22:13:31 |
| geometricalgorithm | This suspicion comes after trying the old methods from the two different old files on master branch (mincome-proportional.js and mincome-default.js). | 22:21:30 |
| geometricalgorithm | Trying to use the new distribution function is yielding another problem: | 22:38:40 |
| geometricalgorithm | import { currentMonthstamp } from '@utils/time.js' doesn't seem to work inside of GroupPledgeGraph.vue | 22:39:40 |
| geometricalgorithm | I'll push this version as the new PR before bed. | 22:40:06 |
