!ePwsQChmTyRFwMijYe:matrix.org

groupincome

21 Members
www.groupincome.org1 Servers

Load older messages


Timestamp Message
13 Nov 2019
09:05:24@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p Hi everyone, Contributions PR squashed and merged 🎉 🎉
10:14:49@_slack_okturtles_UDSJWKSG4:matrix.orgmargaridambotelho I have my approval too, don’t know why it doesn’t show up there 😕
10:17:49@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p DSJWKSG4 after an approval, if the author makes changes to the PR, it automatically asks for a new approval.
10:21:31@_slack_okturtles_UDSJWKSG4:matrix.orgmargaridambotelho aaaah that’s why
12:27:54@_slack_okturtles_UDSJWKSG4:matrix.orgmargaridambotelho Just had a call with 9SGRFKT6 where we identified all the places where the success / error banner messages should be displayed and in which scenarios. I wrote a summary of our call here: https://github.com/okTurtles/group-income-simple/issues/688#issuecomment-553382576
14:22:53@_slack_okturtles_UFKBGLWCV:matrix.orgschweiger.pierre 02KCCG4S 9SGRFKT6 new PR to review: https://github.com/okTurtles/group-income-simple/pull/774
15:01:58@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p I’ll check it soon today FKBGLWCV
18:12:33@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p 02KCCG4S and FKBGLWCV 2 new PR for you: - fix minor issues related to the last PR: https://github.com/okTurtles/group-income-simple/pull/775 - improve login/signup form validations: https://github.com/okTurtles/group-income-simple/pull/776
18:13:00@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p DSJWKSG4 you can also see the 776, if there’s some error copy to improve, now it’s the time to say it! xD
18:39:04@_slack_okturtles_UDSJWKSG4:matrix.orgmargaridambotelho Will check first thing tomorrow!
22:28:08@_slack_okturtles_U02KCCG4S:matrix.orggreg thanks 9SGRFKT6, will also check tomorrow!
14 Nov 2019
06:43:23@_slack_okturtles_UFKBGLWCV:matrix.orgschweiger.pierre 9SGRFKT6: review done you request on my PR are amended
06:44:11@_slack_okturtles_UFKBGLWCV:matrix.orgschweiger.pierre Ready to be merged
06:44:17@_slack_okturtles_UFKBGLWCV:matrix.orgschweiger.pierre Probably small conflict between your and mine coming..
23:34:44@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 Approved your #775! https://github.com/okTurtles/group-income-simple/pull/775#pullrequestreview-317330026 deferring to FKBGLWCV to give his approval/disapproval on your latest changes
23:36:00@_slack_okturtles_U02KCCG4S:matrix.orggreg Also approved FKBGLWCV's changes in https://github.com/okTurtles/group-income-simple/pull/774#pullrequestreview-317317472 , that's waiting on your approval 9SGRFKT6 🙂
15 Nov 2019
01:02:05@_slack_okturtles_UFN5HBK5F:matrix.orgsongxevin DSJWKSG4 I just checked your lastest comments on my PR. Thank you for that and I will work on them soon! 🙏
15:26:04@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p 02KCCG4S FKBGLWCV, while I talked with DSJWKSG4 on our last call about the error Banners we thought it would be better to work on #768 (implement correctly the headers) so it’s easier to implement the error type 3 (App error banners). I’ll be working on that today. https://github.com/okTurtles/group-income-simple/issues/768
16:42:59@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 sounds good 👍 thanks for the update! An update on my end: I've decided that instead of coding I will be writing blog posts and doing PR reviews exclusively for the next week or two!
16:43:51@_slack_okturtles_U02KCCG4S:matrix.orggreg then after that's done i'll get back to working on the payments stuff, and probably followed by implementing low-level things to get logins actually working
16:44:03@_slack_okturtles_U02KCCG4S:matrix.orggreg (so that Sebin & others can test on their mobile devices)
19:17:51@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p Done, a new PR is ready to be reviewed! https://github.com/okTurtles/group-income-simple/pull/777
22:46:12@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 that PR has conficts
22:51:37@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p @greg It doesn’t keep you from reviewing it, tomorrow I’ll solve the conflicts ;)
22:54:59@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 indeed! am looking at it now 🙂
22:55:31@_slack_okturtles_U02KCCG4S:matrix.orggreg it's interesting how sometimes slack doesn't do its magic highlighting thing with usernames and sometimes it does
16 Nov 2019
00:29:51@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 finished review! https://github.com/okTurtles/group-income-simple/pull/777#pullrequestreview-317934486
00:50:07@_slack_okturtles_U02KCCG4S:matrix.orggreg and finished review of https://github.com/okTurtles/group-income-simple/pull/776#pullrequestreview-317937727
12:40:30@_slack_okturtles_U9SGRFKT6:matrix.orga.sandrina.p FKBGLWCV and 02KCCG4S I left 2 comments where I need your opinion to come to a decision: https://github.com/okTurtles/group-income-simple/pull/777
18:09:54@_slack_okturtles_U02KCCG4S:matrix.orggreg 9SGRFKT6 I replied to one comment. For the css class stuff, you and FKBGLWCV would know how to improve the situation better than I would. I mean, I could hunker down and become a CSS master... but I think I'd be missing the point of delegation if I was to do that

There are no newer messages yet.


Back to Room List