| 23 Sep 2023 |
 victorcrimea | Hello Everyone. I've noticed that lapce had signature pop-up from LSP, but then it was removed or not working for me. But Configuration is still there. Is it intentional or a bug? | 22:53:16 |
| victorcrimea | i see Impl displaying signature from LSP (#1720) and signature position change (#1736) but nothing about removal | 22:54:01 |
 pj (panekj) | Neither, your LSP probably doesn't work | 22:54:38 |
| victorcrimea | everything else regarding lsp works, the older version of lapce also shows the signature | 22:55:37 |
| victorcrimea | i'm typing std::cmp::min(
in 14534f4b054e6d93188a938a743d5ecbebb531c3 (0.2.8) it shows the signature
in 7f8d7bdab982d5eed5c3e35d1c0cde10ae642779 master HEAD it shows nothing | 23:00:35 |
| pj (panekj) | that's because 0.2.8 is quite different from HEAD | 23:03:01 |
 Lapce#1906 | MinusGix
The Floem (UI library) version of Lapce will be has been merged into the master branch soon. Once that occurs, bringing it completely up to feature parity with the druid version of Lapce is needed. There is a variety of missing features, some of which were skipped over and some of which have happened since the fork, that need to be reimplemented.
Easy: Features t... Created at
<t:1685623148:R> Last updated
<t:1694031776:R> Status
Open Closed at
n/a | 23:03:38 |
| victorcrimea | ok, now I understand this. I have usually rebuild lapce from latest source and I assume after this merge it became way less usable due to random crashes and awkward UI so I had to backtrack looking for stable commit to build. | 23:07:02 |
| victorcrimea | When it crashes, is backtrace the only thing that helps? | 23:07:28 |
| pj (panekj) | just use git tags | 23:08:15 |
| victorcrimea | yes, 0.2.8 is what i use daily.
now I looking for contribution possibilities, that is why I play with HEAD | 23:09:01 |
 minusgix | Confusion about diff view | 23:11:52 |
| minusgix | At a glance I don't think signature is implemented on current HEAD, so it would be a good target for something to reimplement. (Though not the easiest due to having to jump around a bunch of places) | 23:13:47 |
| victorcrimea | the other important thing is this https://github.com/lapce/lapce/issues/898
as I can see it was before merging Floem.
What handles key presses and converts them to commands? does it detect keyboard scan codes or actual characters? | 23:18:55 |
| minusgix | keypress.rs roughly, though I wouldn't be surprised if that issue is out of date | 23:21:53 |
| victorcrimea | no, i experience it daily | 23:22:11 |
| minusgix | It happens on 0.2.8 and HEAD? | 23:22:24 |
| victorcrimea | yes | 23:22:29 |
| victorcrimea | I just want to find doable thing to work on. I have to explore Floem itself before contribute anything ui-related, but maybe key handling is ui agnostic | 23:24:04 |
| minusgix | The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure | 23:26:26 |
| minusgix | * The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure. I'd suggest adding some logs to the handle_keypress function to see whether it is outputting reasonable values or not | 23:26:51 |
| minusgix | * The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure. I'd suggest adding some logs to the keypress function in keypress.rs to see whether it is outputting reasonable values or not | 23:27:09 |
| minusgix | match_keymap is also where it goes to look up whether it matches a command, I believe | 23:28:00 |
| victorcrimea | thank you for hints, | 23:29:08 |
| 24 Sep 2023 |
| minusgix | Might be better to do some automatic conversion of 'common' keys when checking it against commands? (So KeyN => "n") but I'm unsure. | 00:04:56 |
| victorcrimea changed their display name from victorcrimea to victorcrimea#0. | 00:09:59 |
| victorcrimea changed their display name from victorcrimea#0 to victorcrimea. | 00:10:02 |
| victorcrimea | I agree, while being double conversion, it helps reading the keymap | 00:10:03 |
|  umngane_wami#0 changed their profile picture. | 01:58:22 |
|  spacewarrior777#0 changed their display name from notthatguyanymore#0 to spacewarrior777#0. | 03:00:10 |
