!dwcjjfdaBLxbfGvvlO:matrix.org

Lapce #dev

3183 Members
A room bridged with Lapce Discord server's #dev channel24 Servers

Load older messages


SenderMessageTime
23 Sep 2023
@_discord_1029358785283772487:t2bot.iovictorcrimea Hello Everyone. I've noticed that lapce had signature pop-up from LSP, but then it was removed or not working for me. But Configuration is still there. Is it intentional or a bug? 22:53:16
@_discord_1029358785283772487:t2bot.iovictorcrimea i see Impl displaying signature from LSP (#1720) and signature position change (#1736) but nothing about removal 22:54:01
@_discord_854834852803903488:t2bot.iopj (panekj) Neither, your LSP probably doesn't work 22:54:38
@_discord_1029358785283772487:t2bot.iovictorcrimea everything else regarding lsp works, the older version of lapce also shows the signature 22:55:37
@_discord_1029358785283772487:t2bot.iovictorcrimea i'm typing std::cmp::min(
in 14534f4b054e6d93188a938a743d5ecbebb531c3 (0.2.8) it shows the signature
in 7f8d7bdab982d5eed5c3e35d1c0cde10ae642779 master HEAD it shows nothing
23:00:35
@_discord_854834852803903488:t2bot.iopj (panekj) that's because 0.2.8 is quite different from HEAD 23:03:01
@_discord_1031154236664332299_=4capce:t2bot.ioLapce#1906
#1736239340 Work in progress on reimplementing existing features from Druid Lapce in Floem Lapce
MinusGix

The Floem (UI library) version of Lapce will be has been merged into the master branch soon. Once that occurs, bringing it completely up to feature parity with the druid version of Lapce is needed. There is a variety of missing features, some of which were skipped over and some of which have happened since the fork, that need to be reimplemented.

Easy: Features t...

Created at
<t:1685623148:R>

Last updated
<t:1694031776:R>

Status
Open

Closed at
n/a

23:03:38
@_discord_1029358785283772487:t2bot.iovictorcrimea ok, now I understand this. I have usually rebuild lapce from latest source and I assume after this merge it became way less usable due to random crashes and awkward UI so I had to backtrack looking for stable commit to build. 23:07:02
@_discord_1029358785283772487:t2bot.iovictorcrimea When it crashes, is backtrace the only thing that helps? 23:07:28
@_discord_854834852803903488:t2bot.iopj (panekj) just use git tags 23:08:15
@_discord_1029358785283772487:t2bot.iovictorcrimea yes, 0.2.8 is what i use daily.
now I looking for contribution possibilities, that is why I play with HEAD
23:09:01
@_discord_154041590657056768:t2bot.iominusgix Confusion about diff view 23:11:52
@_discord_154041590657056768:t2bot.iominusgix At a glance I don't think signature is implemented on current HEAD, so it would be a good target for something to reimplement. (Though not the easiest due to having to jump around a bunch of places) 23:13:47
@_discord_1029358785283772487:t2bot.iovictorcrimea the other important thing is this https://github.com/lapce/lapce/issues/898
as I can see it was before merging Floem.

What handles key presses and converts them to commands? does it detect keyboard scan codes or actual characters?
23:18:55
@_discord_154041590657056768:t2bot.iominusgix keypress.rs roughly, though I wouldn't be surprised if that issue is out of date 23:21:53
@_discord_1029358785283772487:t2bot.iovictorcrimea no, i experience it daily 23:22:11
@_discord_154041590657056768:t2bot.iominusgix It happens on 0.2.8 and HEAD? 23:22:24
@_discord_1029358785283772487:t2bot.iovictorcrimea yes 23:22:29
@_discord_1029358785283772487:t2bot.iovictorcrimea I just want to find doable thing to work on. I have to explore Floem itself before contribute anything ui-related, but maybe key handling is ui agnostic 23:24:04
@_discord_154041590657056768:t2bot.iominusgix The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure 23:26:26
@_discord_154041590657056768:t2bot.iominusgix * The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure. I'd suggest adding some logs to the handle_keypress function to see whether it is outputting reasonable values or not 23:26:51
@_discord_154041590657056768:t2bot.iominusgix * The key events get fed to Lapce by Floem, but its possible our handling in lapce is the issue? Unsure. I'd suggest adding some logs to the keypress function in keypress.rs to see whether it is outputting reasonable values or not 23:27:09
@_discord_154041590657056768:t2bot.iominusgix match_keymap is also where it goes to look up whether it matches a command, I believe 23:28:00
@_discord_1029358785283772487:t2bot.iovictorcrimea thank you for hints, 23:29:08
24 Sep 2023
@_discord_154041590657056768:t2bot.iominusgix Might be better to do some automatic conversion of 'common' keys when checking it against commands? (So KeyN => "n") but I'm unsure. 00:04:56
@_discord_1029358785283772487:t2bot.iovictorcrimea changed their display name from victorcrimea to victorcrimea#0.00:09:59
@_discord_1029358785283772487:t2bot.iovictorcrimea changed their display name from victorcrimea#0 to victorcrimea.00:10:02
@_discord_1029358785283772487:t2bot.iovictorcrimea I agree, while being double conversion, it helps reading the keymap 00:10:03
@_discord_978884238499803196:t2bot.ioumngane_wami#0 changed their profile picture.01:58:22
@_discord_943669893990084669:t2bot.iospacewarrior777#0 changed their display name from notthatguyanymore#0 to spacewarrior777#0.03:00:10

There are no newer messages yet.


Back to Room ListRoom Version: 9