Sender | Message | Time |
---|---|---|
12 Feb 2019 | ||
bridge-bot | <jorge> Also added my comments in the EIP to what I think the final standard should be, although I am comfortable to push it out in the current state, specially since we can upgrade later: https://github.com/ethereum/EIPs/issues/1271#issuecomment-462719728 | 16:10:40 |
bridge-bot | <jorge> @sohkai changed the signature modes a little bit (removed Trezor’s old special case and added and invalid signature type) and refactored the tests (parametrized them to test different signature types) | 19:38:45 |
bridge-bot | <jorge> i think you should merge https://github.com/aragon/aragon-apps/pull/625 into https://github.com/aragon/aragon-apps/pull/651 and let’s get those tests in | 19:39:56 |
bridge-bot | <jorge> with this, i think we are ready for merging and releasing | 19:40:04 |
13 Feb 2019 | ||
bridge-bot | <jorge> I saw this other sig validator contract, and i am refactoring ours again :D | 08:37:41 |
bridge-bot | <jorge> | 08:37:42 |
bridge-bot | <jorge> I saw this other sig validator contract that I really liked, and i am refactoring ours again :D | 08:37:50 |
bridge-bot | <jorge> Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/2467b4dafdffae176c43239c68685e7aa7eecec2 | 09:23:11 |
bridge-bot | <jorge> now handling ERC1271 validation in the library as well | 09:23:31 |
bridge-bot | <jorge> Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/345a9d8aa4f411df6d2b5044a801b2cb7d9ca6ee | 09:26:54 |
bridge-bot | <sohkai> @jorge was running the agent coverage tests locally and for some reason the signature tests seemed to not work | 14:51:02 |
bridge-bot | <bingen> @jorge about this: | 15:54:30 |
bridge-bot | <sohkai> Might as well use | 17:12:57 |
bridge-bot | <bingen> ok, sounds good (I said 6.4 because it’s 80% of 8 and because it’s now using 6.37, but I’ll do 6.5) | 18:23:44 |
14 Feb 2019 | ||
bridge-bot | <jorge>
| 07:48:56 |
bridge-bot | <jorge> hmm but the tests were passing? | 07:49:03 |
25 Feb 2019 | ||
bridge-bot | <sohkai> @jorge Would be great if you could take a look at https://github.com/aragon/aragon-apps/pull/686 | 17:28:23 |
28 Feb 2019 | ||
bridge-bot | <sohkai> @all Does anyone using VSCode like to try out a security-oriented solidity extension? One of the AGP-18 security partners built https://github.com/tintinweb/vscode-solidity-auditor and it looks really, really helpful 🔥. Feel free to file issues on github! Installation instructions: https://github.com/tintinweb/vscode-solidity-auditor#installation | 11:51:23 |
19 Mar 2019 | ||
bridge-bot | <gabi> The next two lines give | 02:39:37 |
bridge-bot | <sohkai> Good question; the docs officially only use double quotes, so we should use those instead | 09:14:48 |
bridge-bot | <sohkai> Perhaps it was old syntax from earlier versions of Solidity that have since been removed, but the newer contracts in ENS are now using the double quotes too :shrug: | 09:18:51 |
27 Mar 2019 | ||
bridge-bot | <sohkai> https://blog.ethereum.org/2019/03/26/solidity-optimizer-and-abiencoderv2-bug/ | 09:42:12 |
28 Mar 2019 | ||
bridge-bot | <jorge> | 11:46:50 |
bridge-bot | <jorge> pretty interesting price feed for tokens that uses uniswap prices and prevents manipulation by not taking the current price but a median of checkpoints. we should check it out for payroll | 11:48:54 |
bridge-bot | <jorge> cc @sohkai @facuspagnuolo @lkngtn @bingen | 11:48:54 |
bridge-bot | <jorge> it is live actually: https://github.com/marbleprotocol/polaris | 11:49:41 |
29 Mar 2019 | ||
bridge-bot | <sohkai> https://github.com/ethereum/EIPs/pull/1884
| 12:09:02 |
30 Apr 2019 | ||
bridge-bot | <bingen> Hey guys, I need some Solidity expertise advice. I want to avoid this
| 10:48:13 |
bridge-bot | <jorge> IMO it is okey as it is, definitely cleaner than copying the entire function as in | 11:23:19 |
bridge-bot | <jorge> if this ends up being limited to just the current term (as I think we should do), then we could remove the option of doing it in the past all together and just allow linear searches | 11:24:33 |