!WutQDrNlCwVCYNngoo:matrix.org

Dev EVM

8 Members
1 Servers

Load older messages


Timestamp Message
11 Jan 2019
18:37:40@bridge-bot:matrix.orgbridge-bot [rocketchat] <bingen>

done

15 Jan 2019
19:23:51@bridge-bot:matrix.orgbridge-bot <danielconstantin>

Does anyone have any thoughts on rho-lang ? 😁

23:24:38@bridge-bot:matrix.orgbridge-bot <sohkai>

@danielconstantin Not much, except it was very hard to get into the syntax haha. Promised myself I’d spend a day on it someday, that day hasn’t occurred yet ;).

24 Jan 2019
20:18:31@bridge-bot:matrix.orgbridge-bot <jorge>

@sohkai @bingen we really need to get Actor merged tomorrow

9 Feb 2019
08:10:44@bridge-bot:matrix.orgbridge-bot <jorge>

https://twitter.com/mhswende/status/1093995835518537728

08:10:46@bridge-bot:matrix.orgbridge-bot <jorge>

Fun stuff

11 Feb 2019
23:31:39@bridge-bot:matrix.orgbridge-bot <sohkai>

@channel @aragon/os@4.1.0-rc.1 has been released with an SafeERC20 implementation

23:31:51@bridge-bot:matrix.orgbridge-bot <sohkai>

@all @aragon/os@4.1.0-rc.1 has been released with an SafeERC20 implementation

12 Feb 2019
16:09:59@bridge-bot:matrix.orgbridge-bot <jorge>

Updated ERC1271 support in the Agent app: https://github.com/aragon/aragon-apps/pull/580/commits/fe86092ed206453f66337082874ebb46fe33fb28

16:10:40@bridge-bot:matrix.orgbridge-bot <jorge>

Also added my comments in the EIP to what I think the final standard should be, although I am comfortable to push it out in the current state, specially since we can upgrade later: https://github.com/ethereum/EIPs/issues/1271#issuecomment-462719728

19:38:45@bridge-bot:matrix.orgbridge-bot <jorge>

@sohkai changed the signature modes a little bit (removed Trezor’s old special case and added and invalid signature type) and refactored the tests (parametrized them to test different signature types)

19:39:56@bridge-bot:matrix.orgbridge-bot <jorge>

i think you should merge https://github.com/aragon/aragon-apps/pull/625 into https://github.com/aragon/aragon-apps/pull/651 and let’s get those tests in

19:40:04@bridge-bot:matrix.orgbridge-bot <jorge>

with this, i think we are ready for merging and releasing

13 Feb 2019
08:37:41@bridge-bot:matrix.orgbridge-bot <jorge>

I saw this other sig validator contract, and i am refactoring ours again :D

08:37:42@bridge-bot:matrix.orgbridge-bot <jorge>

https://github.com/horizon-games/multi-token-standard/blob/0c917a439d91af7f480cd5822352a85341dab967/contracts/utils/SignatureValidator.sol#L120

08:37:50@bridge-bot:matrix.orgbridge-bot <jorge>

I saw this other sig validator contract that I really liked, and i am refactoring ours again :D

09:23:11@bridge-bot:matrix.orgbridge-bot <jorge>

Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/2467b4dafdffae176c43239c68685e7aa7eecec2

09:23:31@bridge-bot:matrix.orgbridge-bot <jorge>

now handling ERC1271 validation in the library as well

09:26:54@bridge-bot:matrix.orgbridge-bot <jorge>

Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/345a9d8aa4f411df6d2b5044a801b2cb7d9ca6ee

14:51:02@bridge-bot:matrix.orgbridge-bot <sohkai>

@jorge was running the agent coverage tests locally and for some reason the signature tests seemed to not work

15:54:30@bridge-bot:matrix.orgbridge-bot <bingen>

@jorge about this:
https://github.com/aragon/aragon-apps/pull/657#discussion_r255435114
Tests are not passing now. Do you want me to raise it to 6.4e6, which would be closer to 80% of current limit, or to lower down the number of max allowed tokens?

17:12:57@bridge-bot:matrix.orgbridge-bot <sohkai>

Might as well use 6.5e6 and give that a shot

18:23:44@bridge-bot:matrix.orgbridge-bot <bingen>

ok, sounds good (I said 6.4 because it’s 80% of 8 and because it’s now using 6.37, but I’ll do 6.5)

14 Feb 2019
07:48:56@bridge-bot:matrix.orgbridge-bot <jorge>

for some reason the signature tests seemed to not work

07:49:03@bridge-bot:matrix.orgbridge-bot <jorge>

hmm but the tests were passing?

25 Feb 2019
17:28:23@bridge-bot:matrix.orgbridge-bot <sohkai>

@jorge Would be great if you could take a look at https://github.com/aragon/aragon-apps/pull/686

28 Feb 2019
11:51:23@bridge-bot:matrix.orgbridge-bot <sohkai>

@all Does anyone using VSCode like to try out a security-oriented solidity extension? One of the AGP-18 security partners built https://github.com/tintinweb/vscode-solidity-auditor and it looks really, really helpful 🔥. Feel free to file issues on github!

Installation instructions: https://github.com/tintinweb/vscode-solidity-auditor#installation

19 Mar 2019
02:39:37@bridge-bot:matrix.orgbridge-bot <gabi>

The next two lines give File import callback not supported when compiling using 0x dev-tools: https://github.com/aragon/aragonOS/blob/dev/contracts/lib/ens/ENS.sol#L4
https://github.com/aragon/aragonOS/blob/dev/contracts/lib/ens/PublicResolver.sol#L3
I fixed it using double quotes. Is this a bug?

09:14:48@bridge-bot:matrix.orgbridge-bot <sohkai>

Good question; the docs officially only use double quotes, so we should use those instead

09:18:51@bridge-bot:matrix.orgbridge-bot <sohkai>

Perhaps it was old syntax from earlier versions of Solidity that have since been removed, but the newer contracts in ENS are now using the double quotes too :shrug:


There are no newer messages yet.


Back to Room List