!WutQDrNlCwVCYNngoo:matrix.org

Dev EVM

8 Members
1 Servers

Load older messages


Timestamp Message
2 Jan 2019
16:59:38@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> @jorge @bingen Our `KitBase` in the boilerplate (https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L25) is slightly different than the dao-kits' `KitBase` (https://github.com/aragon/dao-kits/blob/master/kits/base/contracts/KitBase.sol). I think we could just use the dao-kits' `KitBase` if aragonCLI passed the `DAOFactory` argument to its constructor (which should be at a constant address in aragen)?
3 Jan 2019
12:00:22@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> yup
12:00:25@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> that makes sense
13:02:11@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> got the bare kit ready for publishing
13:02:12@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> https://github.com/aragon/dao-kits/pull/60
13:02:23@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> @bingen @sohkai @jvluso
13:02:40@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> can you take a quick look? will start publishing in less than 2h
13:03:33@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> can you take a quick look? will publish before EOD
13:06:34@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> done
4 Jan 2019
15:57:10@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> @bingen getting this error running the tests on the staking PR #1
15:57:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> going to try cleaning node modules
16:04:54@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> oops, let me try and fix it
16:23:25@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Done, you can pull now
16:23:29@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Sorry about that
17:35:24@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> kk
18:07:11@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> submitted some initial comments
18:07:37@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> i will finish it on monday @5881
18:07:40@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> i will finish it on monday @bingen
18:07:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> https://github.com/aragon/staking/pull/1#pullrequestreview-189410489
5 Jan 2019
10:20:34@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Thanks Jorge!
8 Jan 2019
09:26:39@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> still getting some failing tests in the latest embark branch @bingen
09:27:01@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> ``` 1) Checkpointing fails if set value is too high: Error: invalid number value (arg="time", coderType="uint256", value="ffffffffffffffffffffffffffffffffffffffffffffffff") at Object.throwError (node_modules/web3-eth-contract/node_modules/ethers/utils/errors.js:68:17) at CoderNumber.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:353:20) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:605:59 at Array.forEach (<anonymous>) at pack (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:604:12) at CoderTuple.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:764:16) at AbiCoder.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:897:77) at ABICoder.encodeParameters (node_modules/web3-eth-contract/node_modules/web3-eth-abi/src/index.js:96:27) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/src/index.js:426:24 at Array.map (<anonymous>) at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12) at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39) at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54) at Context.it (test_embark/checkpointing.js:110:84) at <anonymous> at process._tickCallback (internal/process/next_tick.js:189:7) 2) Checkpointing fails if set time is too high: Error: invalid number value (arg="value", coderType="uint256", value="ffffffffffffffff") at Object.throwError (node_modules/web3-eth-contract/node_modules/ethers/utils/errors.js:68:17) at CoderNumber.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:353:20) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:605:59 at Array.forEach (<anonymous>) at pack (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:604:12) at CoderTuple.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:764:16) at AbiCoder.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:897:77) at ABICoder.encodeParameters (node_modules/web3-eth-contract/node_modules/web3-eth-abi/src/index.js:96:27) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/src/index.js:426:24 at Array.map (<anonymous>) at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12) at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39) at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54) at Context.it (test_embark/checkpointing.js:118:83) at <anonymous> at process._tickCallback (internal/process/next_tick.js:189:7) 3) Checkpointing fails if requested time is too high: Error: invalid number value (arg="time", coderType="uint256", value="ffffffffffffffff") at Object.throwError (node_modules/web3-eth-contract/node_modules/ethers/utils/errors.js:68:17) at CoderNumber.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:353:20) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:605:59 at Array.forEach (<anonymous>) at pack (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:604:12) at CoderTuple.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:764:16) at AbiCoder.encode (node_modules/web3-eth-contract/node_modules/ethers/utils/abi-coder.js:897:77) at ABICoder.encodeParameters (node_modules/web3-eth-contract/node_modules/web3-eth-abi/src/index.js:96:27) at /Users/jorge/provident/staking/node_modules/web3-eth-contract/src/index.js:426:24 at Array.map (<anonymous>) at Object._encodeMethodABI (node_modules/web3-eth-contract/src/index.js:425:12) at Object._processExecuteArguments (node_modules/web3-eth-contract/src/index.js:741:39) at Object._executeMethod (node_modules/web3-eth-contract/src/index.js:766:54) at Context.it (test_embark/checkpointing.js:128:93) at <anonymous> at process._tickCallback (internal/process/next_tick.js:189:7) ````
09:27:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> all in `Checkpointing`: `fails if set value is too high`, `fails if set time is too high` and `fails if requested time is too high`
11:37:30@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Sorry again, @jorge , it is fixed now, you can pull
14:36:36@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> no worries :D
14:36:39@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> thx for the quick fix
9 Jan 2019
12:46:00@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> @bingen @sohkai would love to get your thoughts on Triggers, and the potential needed addition/modification of EVMScript executors: https://www.notion.so/aragon/Aragon-Triggers-61da083dbac548a1aa0781622422dfa4
11 Jan 2019
18:37:40@bridge-bot:matrix.orgbridge-bot [rocketchat] <bingen>

done

15 Jan 2019
19:23:51@bridge-bot:matrix.orgbridge-bot <danielconstantin>

Does anyone have any thoughts on rho-lang ? 😁

23:24:38@bridge-bot:matrix.orgbridge-bot <sohkai>

@danielconstantin Not much, except it was very hard to get into the syntax haha. Promised myself I’d spend a day on it someday, that day hasn’t occurred yet ;).


There are no newer messages yet.


Back to Room List