| 17 Dec 2018 |
|  geleeroyale changed the history visibility to "world_readable" from "shared". | 21:36:41 |
|  bridge-bot joined the room. | 21:38:25 |
| geleeroyale invited  Jorge Izquierdo. | 21:38:44 |
| geleeroyale invited  lkngtn. | 21:38:44 |
| geleeroyale invited  Tatu. | 21:38:54 |
| geleeroyale invited  @lightcoin:matrix.org. | 21:39:40 |
| bridge-bot | [rocketchat] <geleeroyale> `bridgin` | 21:53:55 |
| geleeroyale | yeah! | 21:54:13 |
|  gabi joined the room. | 22:00:37 |
| @lightcoin:matrix.org joined the room. | 22:30:22 |
| 18 Dec 2018 |
|  griffgreen joined the room. | 04:06:00 |
|  brettsun joined the room. | 12:21:51 |
| Tatu joined the room. | 12:58:38 |
| bridge-bot | [rocketchat] <bingen> hey @jorge Staking is ready for you to re-review except for:
https://github.com/aragon/staking/pull/1#discussion_r241538035
I don't think I fully get it. How would would that front-running attack work? If we use a none wouldn't we be relying on order too?
And:
https://github.com/aragon/staking/pull/1#discussion_r241534907
I'll try to think about how to improve it, but let's discuss it before making any change. | 14:02:13 |
| bridge-bot | [rocketchat] <bingen> hey @jorge Staking is ready for you to re-review except for:
https://github.com/aragon/staking/pull/1#discussion_r241538035
I don't think I fully get it. How would would that front-running attack work? If we use a nonce wouldn't we be relying on order too?
And:
https://github.com/aragon/staking/pull/1#discussion_r241534907
I'll try to think about how to improve it, but let's discuss it before making any change. | 14:05:41 |
| bridge-bot | [rocketchat] <gabi> Great decision to open this channel 💪 | 14:25:21 |
| bridge-bot | [rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19
I'm using cli v5.2.1 and ganache-core v3.2.1 . Also I update to the new voting and token-manager beta.2
I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80
I updated to the new initalization constructor in this way:
`tokenManager.initialize(token, true, 0)`
But the VM still returned exception. I'm lost here, could be related to the MiniMe token?
By the way, the voting app works perfect | 14:45:07 |
| bridge-bot | [rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19
I'm using cli v5.2.1 and ganache-core v2.3.2 . Also I update to the new voting and token-manager beta.2
I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80
I updated to the new initalization constructor in this way:
`tokenManager.initialize(token, true, 0)`
But the VM still returned exception. I'm lost here, could be related to the MiniMe token?
By the way, the voting app works perfect | 14:47:05 |
| bridge-bot | [rocketchat] <sohkai> @gabi Hmm, weird, the only require should be that the token's controller is the token manager, but that's already done in https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L77 | 15:25:41 |
| bridge-bot | [rocketchat] <sohkai> It might be worth upgrading to the `2.0.0` version (non-beta) and see what happens, although the interfaces should be exactly the same | 15:26:11 |
| bridge-bot | [rocketchat] <sohkai> It works without the token manager being initialized? | 15:27:10 |
| bridge-bot | [rocketchat] <gabi> Ok I'll check with 2.0.0 | 15:29:30 |
