18 Dec 2018 |
bridge-bot | [rocketchat] <bingen> hey @jorge Staking is ready for you to re-review except for:
https://github.com/aragon/staking/pull/1#discussion_r241538035
I don't think I fully get it. How would would that front-running attack work? If we use a nonce wouldn't we be relying on order too?
And:
https://github.com/aragon/staking/pull/1#discussion_r241534907
I'll try to think about how to improve it, but let's discuss it before making any change. | 14:05:41 |
bridge-bot | [rocketchat] <gabi> Great decision to open this channel 💪 | 14:25:21 |
bridge-bot | [rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19
I'm using cli v5.2.1 and ganache-core v3.2.1 . Also I update to the new voting and token-manager beta.2
I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80
I updated to the new initalization constructor in this way:
`tokenManager.initialize(token, true, 0)`
But the VM still returned exception. I'm lost here, could be related to the MiniMe token?
By the way, the voting app works perfect | 14:45:07 |
bridge-bot | [rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19
I'm using cli v5.2.1 and ganache-core v2.3.2 . Also I update to the new voting and token-manager beta.2
I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80
I updated to the new initalization constructor in this way:
`tokenManager.initialize(token, true, 0)`
But the VM still returned exception. I'm lost here, could be related to the MiniMe token?
By the way, the voting app works perfect | 14:47:05 |
bridge-bot | [rocketchat] <sohkai> @gabi Hmm, weird, the only require should be that the token's controller is the token manager, but that's already done in https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L77 | 15:25:41 |
bridge-bot | [rocketchat] <sohkai> It might be worth upgrading to the `2.0.0` version (non-beta) and see what happens, although the interfaces should be exactly the same | 15:26:11 |
bridge-bot | [rocketchat] <sohkai> It works without the token manager being initialized? | 15:27:10 |
bridge-bot | [rocketchat] <gabi> Ok I'll check with 2.0.0 | 15:29:30 |
bridge-bot | [rocketchat] <gabi> If I remove all thing related to token manager it works just fine | 15:30:13 |
bridge-bot | [rocketchat] <sohkai> Really weird... I don't think there should be anything related to the version bump but I'm pretty sure the aragen snapshot is using `2.0.0` | 15:34:26 |
bridge-bot | [rocketchat] <gabi> I'll review it again in case I'm missing something | 15:39:33 |
| gabi removed their profile picture. | 16:19:07 |
| gabi set a profile picture. | 16:19:34 |
bridge-bot | [rocketchat] <sohkai> `truffle@5.0.0` finally released! https://github.com/trufflesuite/truffle/releases/tag/v5.0.0 | 21:50:30 |
19 Dec 2018 |
| geleeroyalechanged room power levels. | 13:54:05 |
23 Dec 2018 |
bridge-bot | [rocketchat] <bgits> Moving the discussion from #general regarding EVMScriptRunner to this channel as it seems more relevant. Regarding @jvluso last comment, I see this function in Voting.sol: https://github.com/aragon/aragon-apps/blob/master/apps/voting/contracts/Voting.sol#L187 - What would be helpful is seeing a client side example of how the `_evmScript` param is generated. My guess is it would require a 1) contract ABI, 2) function name, 3) function parameters? Seeing an actual example would be helpful. | 16:57:10 |
bridge-bot | [rocketchat] <jvluso> I'll be able to answer this better once I'm at my computer, but iirc it's 4 bytes of the number of commands (00000001) the target address, 4 bytes of the number of bytes of data, and then the data. The best way however would be to use the aragon wrapper in aragon.js similar to https://github.com/jvluso/eth-aragon-keyring | 21:18:08 |
24 Dec 2018 |
bridge-bot | [rocketchat] <bingen> Hi, @bgits you can find a simple example here:
https://github.com/aragon/aragon-apps/blob/master/apps/voting/test/voting.js#L168 | 14:03:03 |
bridge-bot | [rocketchat] <bingen> Another one here:
https://github.com/aragon/dao-kits/blob/master/kits/democracy/test/democracy.js#L330 | 14:04:31 |
27 Dec 2018 |
bridge-bot | [rocketchat] <bgits> thanks | 14:20:24 |
bridge-bot | [rocketchat] <bgits> @jvluso This looks great: https://twitter.com/izqui9/status/1076013068616908800 - is there a public repo for it? | 14:22:14 |
28 Dec 2018 |
bridge-bot | [rocketchat] <jvluso> https://github.com/jvluso/frame/tree/keyring - it's still being worked on here | 02:52:41 |
2 Jan 2019 |
bridge-bot | [rocketchat] <jorge> Pretty interesting hack https://etherscan.io/address/0x3e8b42754c8eafdc8e732f4346126e920ede8548#code | 10:22:01 |
| Jorge Izquierdo joined the room. | 15:02:15 |
bridge-bot | [rocketchat] <sohkai> @jorge @bingen Our `KitBase` in the boilerplate (https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L25) is slightly different than the dao-kits' `KitBase` (https://github.com/aragon/dao-kits/blob/master/kits/base/contracts/KitBase.sol).
I think we could just use the dao-kits' `KitBase` if aragonCLI passed the `DAOFactory` argument to its constructor (which should be at a constant address in aragen)? | 16:59:38 |
3 Jan 2019 |
bridge-bot | [rocketchat] <jorge> yup | 12:00:22 |
bridge-bot | [rocketchat] <jorge> that makes sense | 12:00:25 |
bridge-bot | [rocketchat] <jorge> got the bare kit ready for publishing | 13:02:11 |
bridge-bot | [rocketchat] <jorge> https://github.com/aragon/dao-kits/pull/60 | 13:02:12 |
bridge-bot | [rocketchat] <jorge> @bingen @sohkai @jvluso | 13:02:23 |