| 20 Feb 2024 |
 asd | After displaying "Dependency postinstall check passed", it doesn't just exit with a successful return value | 14:11:19 |
| asd | Instead it does
process.exitCode =
spawnSync('node_modules/.bin/patch-package', ['--error-on-fail', '--error-on-warn'], {
stdio: ['ignore', 'inherit', 'inherit'],
}).status ?? 1;
| 14:11:31 |
| asd | Can you figure out whether that would work in the setup we have? (See if node_modules/.bin/patch-package works/exists/etc...
(An ultimate workaround might be to just patch this line and have it exit nicely, considering we're doing everything manually and patch-package shouldn't have to run) | 14:13:10 |
| asd | (We also have to verify whether the security issue that patch-package is trying to solve is already solved in our case) | 14:14:41 |
| asd | Let me know if that's clear, or if you need any more help. Bye for now | 14:16:20 |
| 21 Feb 2024 |
 mrwinz | In reply to @rob-in-son:matrix.org
Pirate Praveen_: the contents of the file /tmp/xfs-ad5415cc/build.log https://paste.debian.net/1307793 how about running it with sudo | 00:06:50 |
| mrwinz | In reply to @_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.org
it can be the same test you did with pretty-ms ok | 00:07:14 |
| mrwinz | MR: https://salsa.debian.org/js-team/yarn-plugin-apt/-/merge_requests/28 | 03:24:44 |
| mrwinz | Autopkgtest: https://salsa.debian.org/mr.winz/yarn-plugin-apt/-/commit/c4484bc2cb3e84b57ba4a31ca2bc504faafb00ab | 03:28:36 |
 Pirate Praveen_ | mrwinz, I have merged your first MR, please rebase and keep only one change in one MR | 11:30:59 |
| Pirate Praveen_ | > > <@rob-in-son:matrix.org> Pirate Praveen_: the contents of the file /tmp/xfs-ad5415cc/build.log https://paste.debian.net/1307793
>
> how about running it with sudo
mrwinz why do you think it is a permission issue? sudo is not a solution to all the problems. We should be able to run yarn apt-install as a normal user | 11:32:55 |
| Pirate Praveen_ | > Can you figure out whether that would work in the setup we have? (See if node_modules/.bin/patch-package works/exists/etc...
Running that command shows this error https://paste.debian.net/1308070/ - we have to figure out why they are missing - if these modules are resolved by apt, we may have to fix our packages | 11:36:07 |
| Pirate Praveen_ | it looks like these modules are not installed, we have to figure out why | 11:38:45 |
| Pirate Praveen_ | https://paste.debian.net/1308071/ so these are coming from devDependencies | 11:40:47 |
| Pirate Praveen_ | so may be we need to tell patch-package to ignore those? | 11:41:10 |
| Pirate Praveen_ | asd, Uche mrwinz ^ | 11:41:19 |
| Pirate Praveen_ | > mrwinz, I have merged your first MR, please rebase and keep only one change in one MR
also make a different branch for each Merge Request/feature/change | 11:48:32 |
| asd | If they're Dev dependencies they can be ignored, yes | 11:49:11 |
| Pirate Praveen_ | easier option would be for me remove the patch files for devDependencies | 11:51:55 |
| Pirate Praveen_ | Uche, https://salsa.debian.org/js-team/yarn-plugin-apt/-/issues/20 | 11:57:17 |
| Pirate Praveen_ | Uche, for now remove those patches from the patches directory (those that are failing with module not found in patch-package output) | 12:10:09 |
| Pirate Praveen_ | also make sure to use the node_modules linker | 13:33:05 |
| Pirate Praveen_ | see https://salsa.debian.org/js-team/node-yarnpkg/-/blob/master/debian/README.Debian?ref_type=heads | 13:33:51 |
| Pirate Praveen_ | after making these changes (removing unnecessary patches and adding node-modules linker) yarnpkg apt-install is succeeding | 13:36:38 |
| Pirate Praveen_ | if you are able to reach that much, then try the remaining commands in https://salsa.debian.org/ruby-team/gitlab/-/blob/master/debian/rake-tasks.sh?ref_type=heads (pre compiling assets and running webpack) | 13:38:11 |
| Pirate Praveen_ | I was able to proceed till running webpack, but it fails with https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064411 | 17:16:10 |
| Pirate Praveen_ | asd, any ideas https://salsa.debian.org/js-team/node-neo-async/-/blob/master/package.json?ref_type=heads#L22 lists only a small number of files which we include in the package, there are no other hints for generating the other files | 17:25:12 |
|  psy32nd joined the room. | 18:18:38 |
| asd | https://salsa.debian.org/js-team/node-neo-async/-/blob/master/gulp/tasks/npm.js?ref_type=heads | 18:56:28 |
| asd | This generates each function as a file | 18:56:47 |
