!WaYPjxOMzwGsYOUWvX:matrix.org

Debian JS Mentors (was Debian Browserify)

290 Members
Mentoring Newbies in node/js packaging | Pre requisites  https://wiki.debian.org/Packaging/Pre-Requisites (Gives you instructions to setup a development environment)27 Servers

Load older messages


SenderMessageTime
21 Feb 2024
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_> mrwinz, I have merged your first MR, please rebase and keep only one change in one MR also make a different branch for each Merge Request/feature/change11:48:32
@akshay:matrix.orgasdIf they're Dev dependencies they can be ignored, yes 11:49:11
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_easier option would be for me remove the patch files for devDependencies11:51:55
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_Uche, https://salsa.debian.org/js-team/yarn-plugin-apt/-/issues/2011:57:17
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_Uche, for now remove those patches from the patches directory (those that are failing with module not found in patch-package output)12:10:09
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_also make sure to use the node_modules linker13:33:05
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_see https://salsa.debian.org/js-team/node-yarnpkg/-/blob/master/debian/README.Debian?ref_type=heads13:33:51
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_after making these changes (removing unnecessary patches and adding node-modules linker) yarnpkg apt-install is succeeding13:36:38
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_if you are able to reach that much, then try the remaining commands in https://salsa.debian.org/ruby-team/gitlab/-/blob/master/debian/rake-tasks.sh?ref_type=heads (pre compiling assets and running webpack)13:38:11
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_I was able to proceed till running webpack, but it fails with https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=106441117:16:10
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_asd, any ideas https://salsa.debian.org/js-team/node-neo-async/-/blob/master/package.json?ref_type=heads#L22 lists only a small number of files which we include in the package, there are no other hints for generating the other files17:25:12
@_bifrost_psy32nd=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgpsy32nd joined the room.18:18:38
@akshay:matrix.orgasdhttps://salsa.debian.org/js-team/node-neo-async/-/blob/master/gulp/tasks/npm.js?ref_type=heads18:56:28
@akshay:matrix.orgasdThis generates each function as a file 18:56:47
@akshay:matrix.orgasd Pirate Praveen_: 18:57:05
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_asd, we run that in the build already https://salsa.debian.org/js-team/node-neo-async/-/blob/master/debian/nodejs/build?ref_type=heads#L219:06:19
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_is it expecting a different option to be passed?19:06:59
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_ok it does create it in build directory19:08:11
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_but since package.json#files don't mention it, this is not getting included19:09:37
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_fixed, thanks asd !19:18:17
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_now there are many errors about not finding jquery Module not found: Error: Can't resolve 'jquery' in '/usr/share/gitlab/app/assets/javascripts/vue_shared/components/notes' though jquery is present20:07:56
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_# yarnpkg why jquery └─ root-workspace-0b6124@workspace:. └─ jquery@aptr:3.6.1 (via aptr:^3.6.0)20:13:33
23 Feb 2024
@mrwinz:matrix.orgmrwinz
In reply to @_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.org
> mrwinz, I have merged your first MR, please rebase and keep only one change in one MR
also make a different branch for each Merge Request/feature/change
should i do the rebase now or next time i change stuff
01:38:25
@mrwinz:matrix.orgmrwinz
In reply to @_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.org
> mrwinz, I have merged your first MR, please rebase and keep only one change in one MR
also make a different branch for each Merge Request/feature/change
* should i do the rebase now or next time i change stuff
https://salsa.debian.org/js-team/yarn-plugin-apt has all the changes
01:47:00
@_oftc_felipegmaia41:matrix.orgfelipegmaia41 left the room.02:44:29
@_oftc_felipegmaia41:matrix.orgfelipegmaia41 joined the room.02:44:41
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_mrwinz, I merged all, but see my last commits16:51:26
24 Feb 2024
@mrwinz:matrix.orgmrwinz
In reply to @_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.org
mrwinz, I merged all, but see my last commits
okwy, the merge conflict right
12:34:07
@_bifrost_Pirate=20Praveen_=2fdebian-js-mentors=40chat.disroot.org:aria-net.orgPirate Praveen_> > <Pirate Praveen_> mrwinz, I merged all, but see my last commits > > okwy, the merge conflict right and removing generated files, we don't commit generated files in git.15:36:16
@mrwinz:matrix.orgmrwinzokay thanks15:55:44

There are no newer messages yet.


Back to Room ListRoom Version: