|23 Jan 2020|
Right. Will switch them back,
|04:48:02||gargantua_kerr||In terms of build variables|
|04:58:39||Pirate Praveen||gargantua_kerr: did you check if it build depends on cdbs ?|
|04:59:00||Pirate Praveen||Which is completely different from debhelper|
|04:59:41||Pirate Praveen||You will have to learn how to use cdbs for packaging first|
Alrighty. This is interesting. Would you have a documentation for it?
This doesn't seem to exist, anymore.
|05:07:28||Pirate Praveen||gargantua_kerr: check in cdbs package itself|
|24 Jan 2020|
Pirate Praveen: Noted, and reading.
This further explains it. I feel that the test isn't robust enough, like it is mentioned in the thread.
|16:42:05||gargantua_kerr||Also opened an issue to request for the same, but it seems unmaintained,|
|18:52:26||Pirate Praveen||gargantua_kerr: we can disable now|
|20:32:33||Pirate Praveen||gargantua_kerr: I think yadd fixed it now, it'd be a good idea to add your name in the wiki when taking a package|
|20:37:53||yadd||Pirate Praveen: Hi, there is a bug in node-lodash that makes node-grunt-legacy-util build fails|
|20:38:03||gargantua_kerr||Pirate Praveen: yep. I updated the wiki with a PR I made. He pulled in my PR, fixed and uploaded. He's fast!|
|20:39:07||Pirate Praveen||gargantua_kerr: good!|
|20:39:20||gargantua_kerr||yadd: yeah, runInContext() doesn't seem to work.|
|20:39:35||Pirate Praveen||yadd: I'm traveling, see if you can find a way|
|20:40:40||Pirate Praveen||Some steps we miss in lodash build?|
Also found a fix for the earlier error with grunt-legacy-util.
|20:52:59||Pirate Praveen||gargantua_kerr: I think that is hiding or work around, not a fix|
|20:54:47||gargantua_kerr|| Pirate Praveen: The tests were taking stdout for comparing the values.|
While the stdout results were OK, there are several deprecation warnings about Buffer() from upstream itself.
So the warnings too were concatenated in the variables making the tests fail.
|20:58:28||gargantua_kerr||The warnings are not an issue with upstream results, so I was guessing maybe this is a fix.|
|20:58:52||gargantua_kerr||I'll check in if something else can be a better way|
|21:11:14||Pirate Praveen||gargantua_kerr: the fix is to not have the warnings in the first place|
|21:12:09||Pirate Praveen||ie, change the usage as suggested in the warnings|
|21:14:27||gargantua_kerr||Redacted or Malformed Event|
|21:16:18||gargantua_kerr|| Pirate Praveen: Right.|
They are however warnings from upstream code itself. I'll try fixing them, then.
I have opened an issue upstream too,
|21:56:04||gargantua_kerr||Fixed the warnings, tests pass. Made a PR upsteam, all checks pass. That should, hopefully fix the error as the lodash thing is resolved.|
|25 Jan 2020|
|06:57:03||Pirate Praveen||gargantua_kerr: 👍|