| 18 Feb 2019 |
| 14:56:13 |  Pirate Praveen | and follow https://wiki.debian.org/Javascript/Nodejs#Rollup to run rollup during package build |
| 14:56:59 |  sumedhpatkar | "rollup -c" has to be run only once right? |
| 14:58:13 | Pirate Praveen | it should be in debian/rules like in that wiki |
| 14:58:29 | Pirate Praveen | I said to run that manually to see if the command is actually working before we add to rules |
| 14:58:56 | sumedhpatkar | Oh. So if it is in debian/rules, then dpkg-buildpackage considers it and runs it, right? |
| 14:59:06 | Pirate Praveen | yes |
| 14:59:34 | Pirate Praveen | you have to add it correctly, rules follows gnu make syntax |
| 14:59:50 | sumedhpatkar | Okay |
| 15:02:02 |  nickdex | Question, do we package dist (or any built files)?
Or do we build them fresh for user installs package? |
| 15:02:13 | nickdex | *when |
| 15:02:39 | Pirate Praveen | sumedhpatkar: see https://salsa.debian.org/js-team/node-chart.js/blob/master/debian/rules |
| 15:03:30 | Pirate Praveen | here you need just rollup -c (no need to pass the config file as rollup.config.js is in the root directory of the package) |
| 15:03:46 | Pirate Praveen | nickdex: we generate during build |
| 15:03:53 | Pirate Praveen | see the link I shared above |
| 15:04:09 | sumedhpatkar | and not even uglifyjs, right?
What about dh_auto_clean? |
| 15:04:17 | Pirate Praveen | and follow https://wiki.debian.org/Javascript/Nodejs#Rollup to run rollup during package build nickdex ^ |
| 15:05:59 | nickdex | In reply to @praveen:poddery.com
nickdex: we generate during build Good :) |
| 15:10:15 | sumedhpatkar | In reply to @sumedhpatkar:poddery.com
dpkg-buildpackage is done.
.deb file is created in parent directory.
It gave a little warning at the end
"dpkg-buildpackage: warning: not signing UNRELEASED build; use --force-sign to override"
Can it be ignored? Or I do as it says? I followed the process again. I am at this step now |
| 15:10:18 | Pirate Praveen | In reply to @sumedhpatkar:poddery.com
and not even uglifyjs, right?
What about dh_auto_clean? just follow the format, you only need one command there. clean also you need |
| 15:10:51 | Pirate Praveen | sumedhpatkar: did you remove dist? |
| 15:12:52 | sumedhpatkar | Redacted or Malformed Event |
| 15:18:35 | sumedhpatkar | In reply to @praveen:poddery.com
sumedhpatkar: did you remove dist? Do i need to remove it manually? Or dh_auto_clean will take care of that? |
| 15:18:47 | sumedhpatkar | I can still see it after dpkg-buildpackage |
| 15:26:04 | sumedhpatkar | Okay, I just understood. debclean follows dh_auto_clean commands. |
| 15:27:14 | sumedhpatkar | Do I need to run debclean after dpkg-buildpackage ? |
| 15:45:40 | Pirate Praveen | In reply to @praveen:poddery.com
see https://wiki.debian.org/Javascript/Repacking sumedhpatkar: did you follow these? |
| 15:46:36 | sumedhpatkar | No. I'll see now |
| 15:47:14 | sumedhpatkar | What does it contain? |
| 15:47:39 | Pirate Praveen | it has instructions to properly remove dist |
| 15:47:49 | sumedhpatkar | Okay |
