| 8 Apr 2021 |
|  Aman Goel set a profile picture. | 23:24:13 |
| 30 Apr 2021 |
|  @server_stats:nordgedanken.dev joined the room. | 07:08:09 |
| @server_stats:nordgedanken.dev changed their display name from Server Stats Discoverer (bot) to Server Stats Discoverer (traveler bot). | 17:17:44 |
| 11 May 2021 |
| @server_stats:nordgedanken.dev set a profile picture. | 12:39:21 |
| 16 May 2021 |
 astrojuanlu | woops, the docs are broken https://github.com/poliastro/poliastro/issues/1229 | 15:46:08 |
|  dhruvSondhi joined the room. | 15:46:13 |
| astrojuanlu | I was too fast merging some of the pull requests I think | 15:46:14 |
| dhruvSondhi | the tests should also have failed but it doesn't seems so that way 🤔 | 15:47:30 |
| dhruvSondhi | astrojuanlu: error in PR 1184 | 15:51:35 |
| dhruvSondhi | changing of the values | 15:51:46 |
| dhruvSondhi | the values have been entered in degree without units | 15:51:59 |
| dhruvSondhi | Computation & Condition checking being done in radians | 15:52:13 |
| dhruvSondhi | https://github.com/poliastro/poliastro/pull/1190/files | 15:52:25 |
| dhruvSondhi | * astrojuanlu error in PR 1184 | 15:52:42 |
 jorgepiloto | That PR is the cause. The validation repo also got affected by this | 15:54:05 |
| dhruvSondhi | Just a minute jorgepiloto checking for the actual code ... where it may be broken 🤔 | 15:55:49 |
| astrojuanlu | we need two things:
- to fix the code
- to understand why Read the Docs failed, but the Azure Pipelines didn't
| 15:56:25 |
| astrojuanlu | also, there's no need to turn this chat into a stream of consciousness. it's not urgent or anything :) | 15:56:41 |
| astrojuanlu | if you find anything insightful, please update the issue #1229 | 15:56:51 |
| astrojuanlu | dhruvSondhi just for clarification: yes, the tests have failed, I'm reading https://github.com/poliastro/poliastro/runs/2594411686 | 15:58:06 |
| dhruvSondhi | Yes its absolutely https://github.com/poliastro/poliastro/pull/1190/files ... found where the issue is ... actual code converts value to radian then to degree (older implementation) ... newer implementation doesn't account for that change | 15:59:15 |
| dhruvSondhi | hence all the values are in a mixed unit ... its a mess of degree & radians | 15:59:40 |
| dhruvSondhi | I can make a PR fixing it if its ok? | 15:59:58 |
|  yash-10 joined the room. | 16:01:13 |
| yash-10 | Sorry astrojuanlu ! I had planned to convert that PR into draft since I suspected some problems in the units, but as time passed by, I forgot to do so. I will fix it soon and send a PR!
Again, sorry!!
| 16:08:46 |
| astrojuanlu | hah, no problem! don't say sorry, I reviewed and merged those pull requests :) so I was as responsible as you yash-10 ! | 16:15:05 |
| astrojuanlu | also, it turns out that this was not our fault! a new astroquery release broke the world | 16:15:18 |
| astrojuanlu | but now it's fixed 💪 | 16:15:25 |
| yash-10 | Oh! Good to hear that it is fixed now!! | 16:16:40 |
| 17 May 2021 |
|  abdulmoiz37 joined the room. | 07:20:56 |
