!VxymBsrMGuogkycwNa:matrix.org

poliastro-ci

20 Members
Testing, infrastructure, Continuous Integration problems, pytest regressions, Windows rants6 Servers

Load older messages


SenderMessageTime
8 Apr 2021
@amangoel185:matrix.orgAman Goel set a profile picture.23:24:13
30 Apr 2021
@server_stats:nordgedanken.devServer Stats Discoverer (traveler bot) joined the room.07:08:09
@server_stats:nordgedanken.devServer Stats Discoverer (traveler bot) changed their display name from Server Stats Discoverer (bot) to Server Stats Discoverer (traveler bot).17:17:44
11 May 2021
@server_stats:nordgedanken.devServer Stats Discoverer (traveler bot) set a profile picture.12:39:21
16 May 2021
@astrojuanlu:matrix.orgastrojuanluwoops, the docs are broken https://github.com/poliastro/poliastro/issues/122915:46:08
@gladiator54:matrix.orgdhruvSondhi joined the room.15:46:13
@astrojuanlu:matrix.orgastrojuanluI was too fast merging some of the pull requests I think15:46:14
@gladiator54:matrix.orgdhruvSondhithe tests should also have failed but it doesn't seems so that way 🤔15:47:30
@gladiator54:matrix.orgdhruvSondhi astrojuanlu error in PR 1184 15:51:35
@gladiator54:matrix.orgdhruvSondhichanging of the values 15:51:46
@gladiator54:matrix.orgdhruvSondhithe values have been entered in degree without units 15:51:59
@gladiator54:matrix.orgdhruvSondhiComputation & Condition checking being done in radians 15:52:13
@gladiator54:matrix.orgdhruvSondhihttps://github.com/poliastro/poliastro/pull/1190/files15:52:25
@gladiator54:matrix.orgdhruvSondhi * astrojuanlu error in PR 1184 15:52:42
@jorgepiloto:matrix.orgjorgepilotoThat PR is the cause. The validation repo also got affected by this15:54:05
@gladiator54:matrix.orgdhruvSondhi Just a minute jorgepiloto checking for the actual code ... where it may be broken 🤔 15:55:49
@astrojuanlu:matrix.orgastrojuanlu

we need two things:

  • to fix the code
  • to understand why Read the Docs failed, but the Azure Pipelines didn't
15:56:25
@astrojuanlu:matrix.orgastrojuanlualso, there's no need to turn this chat into a stream of consciousness. it's not urgent or anything :)15:56:41
@astrojuanlu:matrix.orgastrojuanluif you find anything insightful, please update the issue #122915:56:51
@astrojuanlu:matrix.orgastrojuanlu dhruvSondhi just for clarification: yes, the tests have failed, I'm reading https://github.com/poliastro/poliastro/runs/2594411686 15:58:06
@gladiator54:matrix.orgdhruvSondhi Yes its absolutely https://github.com/poliastro/poliastro/pull/1190/files ... found where the issue is ... actual code converts value to radian then to degree (older implementation) ... newer implementation doesn't account for that change 15:59:15
@gladiator54:matrix.orgdhruvSondhi hence all the values are in a mixed unit ... its a mess of degree & radians 15:59:40
@gladiator54:matrix.orgdhruvSondhiI can make a PR fixing it if its ok?15:59:58
@yash-10:matrix.orgyash-10 joined the room.16:01:13
@yash-10:matrix.orgyash-10

Sorry astrojuanlu ! I had planned to convert that PR into draft since I suspected some problems in the units, but as time passed by, I forgot to do so. I will fix it soon and send a PR!

Again, sorry!!

16:08:46
@astrojuanlu:matrix.orgastrojuanlu hah, no problem! don't say sorry, I reviewed and merged those pull requests :) so I was as responsible as you yash-10 ! 16:15:05
@astrojuanlu:matrix.orgastrojuanlualso, it turns out that this was not our fault! a new astroquery release broke the world16:15:18
@astrojuanlu:matrix.orgastrojuanlubut now it's fixed 💪16:15:25
@yash-10:matrix.orgyash-10Oh! Good to hear that it is fixed now!!16:16:40
17 May 2021
@abdulmoiz37:openastronomy.orgabdulmoiz37 joined the room.07:20:56

There are no newer messages yet.


Back to Room List