31 Dec 2023 |
| forecasterweatherwax joined the room. | 23:34:25 |
| lichtvii joined the room. | 23:49:32 |
1 Jan 2024 |
| blackh0lesun joined the room. | 13:39:03 |
.omid.n | Redacted or Malformed Event | 15:12:24 |
2 Jan 2024 |
| swoller22 joined the room. | 16:24:13 |
5 Jan 2024 |
| liquid_berny joined the room. | 04:14:19 |
| genshin007 joined the room. | 23:57:29 |
6 Jan 2024 |
| proconsule joined the room. | 07:16:14 |
7 Jan 2024 |
| akraxial joined the room. | 16:47:23 |
8 Jan 2024 |
| Incubo_ changed their profile picture. | 21:02:39 |
9 Jan 2024 |
codav | Anyone have time to review the PR? | 16:45:42 |
sofloppy | I've looked at it but can't test atm as my test suite uses the emscripten build | 17:02:21 |
codav | The GLES fixes are still in the queue for merge, after this PR, so it's basically about any obvious mistakes I made with the waveform refactoring 😄 | 17:57:52 |
sofloppy | I've pulled those fixes and built and it's just a black screen | 20:30:33 |
sofloppy | The console.logs show its playing but nothing but black 😄 | 20:30:50 |
sofloppy | I promise to review and sign-off on it after work today ❤️ | 20:31:11 |
sofloppy | * I promise to review and sign-off on the waveform pr after work today ❤️ | 20:31:37 |
10 Jan 2024 |
sofloppy | Hey codav , so im reviewing the Waveforms PR, and i have a question.
Ive noticed that all the other namespaces are fully capitalized, except libprojectM, why? | 13:36:20 |
codav | Just ordered two RPi 5's, will see that I build projectM and test it on those ASAP. | 13:36:21 |
sofloppy | Lol you sending me 1? | 13:36:31 |
sofloppy | 😉 jk | 13:36:33 |
codav | Mainly because "libprojectM" or "projectM" is basically how it's spelled. "LibProjectM" or similar just looks... wrong IMO. | 13:37:20 |
codav | Besides that, I generally prefer PascalCase namespace names. Some like other spellings like lowerPascalCase or even lower_snake_case (which is rather something used in C than C++). | 13:38:42 |
codav | Main reason here was to make the topmost namespace as unique as possible, which is what "libprojectM" will do in any case/casing 😄 | 13:39:32 |
sofloppy | Makes since, thats what I had assumed but wanted to know for sure 😄 | 13:43:22 |
sofloppy | Alright, Ive scanned over the PR and signed off | 13:43:47 |
sofloppy | Sorry for the delay on my part 😛 | 13:44:23 |
codav | No problem, new year's always stuffed to the brim with appointments, vacation, work and so on, same for me. Won't have time to work on projectM until next week anyway. | 13:47:34 |
11 Jan 2024 |
| _haydan joined the room. | 00:20:19 |
| puigru joined the room. | 22:48:14 |