16 Dec 2019 |
| santam joined the room. | 16:09:37 |
santam | Hey this is Santam..I would like to contribute to this project.. Is there any new issue that I can work on | 16:11:23 |
santam | ? | 16:11:25 |
philomath | Hey..
Welcome..
Look at this repository: https://github.com/LakshyAAAgrawal/Space_B__ars | 16:41:51 |
27 Dec 2019 |
Piyush Kumar | Hi @LakshyAAAgrawal sorry for being inactive as I was having my exams. | 10:33:29 |
Piyush Kumar | I've made the required changes | 10:33:39 |
Piyush Kumar | Is good time for making a pull request? | 10:34:06 |
philomath | In reply to Piyush Kumar Hi @LakshyAAAgrawal sorry for being inactive as I was having my exams. No problem. Hope your exams went well.. | 10:34:55 |
philomath | In reply to Piyush Kumar I've made the required changes That's great | 10:34:59 |
philomath | In reply to Piyush Kumar Is good time for making a pull request? Any time is good time for a contribution in OSS | 10:35:17 |
Piyush Kumar | Thank you I'll be making the changes | 10:39:21 |
Piyush Kumar | I've made the pr please look into it | 14:08:40 |
30 Dec 2019 |
| weirdsmiley changed their display name from Manas to weirdsmiley. | 07:36:41 |
31 Dec 2019 |
Piyush Kumar | Hi @LakshyAAAgrawal please review the pr named patch 2 | 16:17:23 |
philomath | Hey really sorry. I am running busy since the past few days and for some more days. Would be able to review only after that.
Can somebody volunteer to take this up?
If not, I would do it in some days | 17:13:29 |
Bhavya | Yes, I can take it up | 17:16:23 |
philomath | Thanks | 17:17:59 |
Bhavya | @Kpiyush04 could you please provide a brief description for your pull request, elaborating the changes and their implementation? | 17:18:54 |
Piyush Kumar | Hi @BhavyaC16 I've made the pr for background music as well as I've added pause feature in the PR named "patch 2". | 17:50:37 |
Piyush Kumar | You can have a look if any changes are required please do let me know | 17:51:18 |
Bhavya | In reply to Piyush Kumar Hi @BhavyaC16 I've made the pr for background music as well as I've added pause feature in the PR named "patch 2". Add this to the PR at https://github.com/NJACKWinterOfCode/Space_B__ars/pull/10 itself as the PR description.
It's a good practice to describe the changes you've made and the approach for implementation of those changes for the community members to understand your contribution. | 17:54:11 |
Bhavya | For instance, have a look at the description for this PR: https://github.com/mozilla/thimble.mozilla.org/pull/2474 | 17:57:50 |
Piyush Kumar | I've updated the discription. Please have a look | 19:27:10 |
Bhavya | That's great!
I'll review the modifications and notify you soon | 19:35:00 |
1 Jan 2020 |
Piyush Kumar | Sure | 09:33:28 |
Bhavya | @Kpiyush04 I have made a few comments on the PR.. kindly look into them. Thanks! | 13:40:15 |
Bhavya | Please feel free to reply or enquire in case of any doubts | 13:41:32 |
Piyush Kumar | Sure I'll do the changes | 21:18:16 |
6 Jan 2020 |
philomath | I am very sorry to all the NWoC contributers here. I have yet to receive the merge access from the NWoC people, and will accept the pull requests as soon as I get the access. | 13:55:39 |
philomath | I appreciate the work you all have done.. | 13:56:11 |