 | Dev Frontend | 22 Members |
| 1 Servers |
| Dev Frontend | 22 Members |
| 1 Servers |
| Sender | Message | Time |
|---|---|---|
| 9 Oct 2019 | ||
 bridge-bot | <chadoh>I don’t remember the last time I had a web app “randomly select elements”, but I can remember multiple times when I tried to select text but couldn’t because the app developer decided I shouldn’t be allowed.
Seems like we interact with apps pretty differently! I concede that I’m probably a less prototypical user, so I’ll defer to the “make interactive elements unselectable” decision. | 18:08:45 |
| bridge-bot | <chadoh>
I wonder if it will make sense to revisit this discussion once deep linking has been fully baked and implemented in a few apps, to see if tabs can push app developers toward making proper deep links to their tabbed content. | 18:14:38 |
| bridge-bot | <bpierre>Yes absolutely, we might find a way to conciliate the two needs! | 21:09:33 |
| 10 Oct 2019 | ||
| bridge-bot | <sohkai>@bpierre The tab bar in the fundraising onboarding does look kind of funny, since the rest of it doesn’t sit on a surface | 10:27:49 |
| bridge-bot | <sohkai>@bpierre The tab bar in the fundraising onboarding does look a bit out of place, since the rest of the components don’t sit on a surface | 10:28:46 |
| bridge-bot | <sohkai>Not a big problem for now, but perhaps something we can think about later | 10:28:57 |
| bridge-bot | <bpierre>Yes I agree, this was meant as a temporary solution on this form (see the Figma file for the different iterations), but I think having a different style for tabs on background (without a surface maybe) could work well | 10:34:34 |
| bridge-bot | <bpierre>Yes I agree, this was meant as a temporary solution on this form (see the Figma file for the different iterations), but I think having a different style for tabs on background (without a surface maybe) could work well /cc @owisixseven @dizzypaty | 10:34:53 |
| bridge-bot | <sohkai>Yeah, that’s what I was initially thinking too | 12:06:22 |
| bridge-bot | <sohkai>Btw @bpierre, will be submitting a few PRs to fix/clean some things up on the templates; otherwise I think we’re quite good to go for fundraising. | 12:06:54 |
| bridge-bot | <sohkai>Olivier said he was able to create the org on Rinkeby without a problem on the branch, and we can start getting a bit more testing in with the nightly build :) | 12:07:28 |
| bridge-bot | <bpierre>@sohkai Could you check this PR whenever you can? So that we can release & merge this one right after | 12:46:56 |
| bridge-bot | <bpierre>@sohkai Could you check this PR whenever you can? So that we can release aragonUI & merge this one right after | 12:47:41 |
| bridge-bot | <sohkai>@bpierre Should we merge https://github.com/aragon/aragon/pull/1116 into its parent (https://github.com/aragon/aragon/pull/1092)?
I'm going to finish https://github.com/aragon/aragon/pull/1117 and then get back to updating the fundraising’s review screen, but let me know if that’s something you might be able to get to first :). | 16:32:04 |
| bridge-bot | <sohkai>We are definitely going to have to merge https://github.com/aragon/aragon/pull/1092 tonight | 16:32:48 |
| bridge-bot | <bpierre>Yes all good for merging #1116 | 16:33:01 |
| bridge-bot | <bpierre>Cool, I can work on the fundraising review screen yes 👍 | 16:34:33 |
| bridge-bot | <dizzypaty>I removed the white bg on the tabs and I think it looks a bit better, but probably we’ll need to rethink this at some point | 16:39:21 |
| bridge-bot | <bpierre>Yes! I plan to add this as an internal component for now, so we can play a bit with it before moving it to aragonUI | 16:40:25 |
| bridge-bot | <sohkai>@bpierre https://github.com/aragon/aragon/pull/1117 now ready for review | 17:17:03 |
| bridge-bot | <bpierre>@sohkai I added the review layout for Fundraising https://github.com/aragon/aragon/pull/1092/commits/73a63e7f6fae8377e47dd3c3197cb220edfd1ca8 | 18:50:03 |
| bridge-bot | <sohkai>@bpierre Added a few more commits to the PR:
| 20:48:43 |
| bridge-bot | <bpierre>@sohkai Cool! I think we have everything from the design tweaks then 👍 | 21:11:59 |
| bridge-bot | <sohkai>Yep, I think so too! | 21:12:08 |
| bridge-bot | <bpierre>This one is ready to get in too https://github.com/aragon/aragon/pull/1077 | 21:15:10 |
| bridge-bot | <sohkai>Let’s merge! | 21:20:57 |
| bridge-bot | <bpierre>Done 👍 | 21:24:26 |
| bridge-bot | <sohkai>Let’s merge 1092 and then I’ll merge 1117? | 21:27:51 |
| bridge-bot | <bpierre>Cool yes! | 21:29:52 |
| bridge-bot | <bpierre>@sohkai 1092 merged | 21:30:45 |