| 28 Nov 2017 |
 Ross Schulman | Right, for sure. | 14:48:58 |
 MTRNord | !github create "use own repo for the proto files" | 14:49:07 |
 Github | Created issue: https://github.com/MTRNord/MatrixProtoBuf/issues/2 | 14:49:08 |
 Github [@MTRNord:matrix.org] (deprecated) | [MTRNord/MatrixProtoBuf] MTRNord opened issue #2: use own repo for the proto files [open] - https://github.com/MTRNord/MatrixProtoBuf/issues/2 | 14:49:08 |
| Ross Schulman | I was just thinking about trying to implement some more and was like "oh... I need to clone this whole repo" | 14:49:17 |
| MTRNord | give me a minute i factor them out if you need them. ;) | 14:50:18 |
| Ross Schulman | Oh, I don't NEED them. | 14:51:23 |
| Ross Schulman | I can't work on it right this instant anyway. :) | 14:51:29 |
| MTRNord | done anyways. I will make them a submodule later in the example repo :) | 14:52:40 |
| MTRNord | https://github.com/Nordgedanken/MatrixProtoFiles | 14:52:43 |
| Ross Schulman | Cool, thanks! | 14:52:55 |
| MTRNord changed the room topic to "Matrix Protobuf/gRPC Proxy Repo: https://github.com/MTRNord/MatrixProtoBuf Proto Files only repo at: https://github.com/Nordgedanken/MatrixProtoFiles" from "Matrix Protobuf/gRPC Proxy Repo: https://github.com/MTRNord/MatrixProtoBuf". | 14:53:05 |
| MTRNord changed the room topic to "Matrix Protobuf/gRPC Proxy Repo: https://github.com/MTRNord/MatrixProtoBuf --- Proto Files only repo at: https://github.com/Nordgedanken/MatrixProtoFiles" from "Matrix Protobuf/gRPC Proxy Repo: https://github.com/MTRNord/MatrixProtoBuf Proto Files only repo at: https://github.com/Nordgedanken/MatrixProtoFiles". | 14:53:23 |
| Ross Schulman | I really feel like at least the server<->server federation communication should be done with something other than json" | 14:53:26 |
| Ross Schulman | Just too much opportunity for trickery with type checking. | 14:53:42 |
| MTRNord | I agree. but this currently focused on client server communitcation. One of the examples should in the future get a lib anyways so that when dendrite is fully done I could implement protobuf and gRPC easily in dendrite. Currently I work on a proxy that can run on client side as well as on server side which converts between json and proto/gRPC | 14:56:13 |
| MTRNord | after the theoretical working proxy is build I will propably implement this as a Labs function in my client Morpheus too xD but this isn't a project I focus on. | 14:57:20 |
| Ross Schulman | 👍 | 14:58:45 |
| MTRNord | (this was a "I have nothing else to do" project anyways in the first place :) ) | 14:59:27 |
| Ross Schulman | No, but its a good idea. | 15:00:09 |
| Ross Schulman | Having matrix-official protobuf files could be useful in a ton of ways. | 15:00:35 |
| MTRNord | yeah :) | 15:01:07 |
| MTRNord | also worth noting this is my firsrt time doing protobuf and gRPC so if someone knows better tell me ;P | 15:02:26 |
| MTRNord | also I am not sure if this is the best design. all requests contain the adress of the wanted HS means these requests work with any proxy to any HS which might be a bad design when wanting to integrate it into dendrite later | 15:03:40 |
| Github [@MTRNord:matrix.org] (deprecated) | [MTRNord/MatrixProtoBuf] MTRNord opened issue #3: Use consistent naming of adress or home_server [open] - https://github.com/MTRNord/MatrixProtoBuf/issues/3 | 15:18:27 |
| Ross Schulman | I'm not sure I understood that last bit. All requests contain the wanted HS? | 15:31:35 |
| MTRNord | yes all request proto definitions for gRPC contain the HS adress. so that the proxy knows where to send the request. as soon this is inside the HS implemented that param makes no sense of course | 15:33:07 |
| MTRNord | Ross Schulman: see https://github.com/MTRNord/MatrixProtoBuf/blob/d3ed542e7c5744e51dbba96776eb48e7a91fa73b/src/github.com/Nordgedanken/MatrixProtoBuf/matrixProtos/matrix.proto#L29 | 15:33:50 |
| Ross Schulman | Ah, I see. | 15:40:55 |
| Ross Schulman | It might be better to move that out to a settings file or command line flag. | 15:41:24 |
