| 3 May 2018 |
 charlag | Like, even for your PR it's fine, I don't get it... | 20:23:36 |
| charlag | Maybe there was a different build tools version in that PR. I've changed container version to 27, maybe that was the case | 20:24:48 |
 Tak! | the bottom sheet change seems ok, but do we want to move the bottom sheet setup/management back to BaseActivity then? | 20:32:44 |
 connyduck | yes, as @charlag:matrix.org | 20:35:59 |
| connyduck | mentioned, my current solution breaks encapsulation | 20:36:34 |
| connyduck | I will try to improve it tommorow | 20:37:25 |
| connyduck | after the scrolling is fixed and the notification PR is merged I would like to release 1.8.0 | 20:38:24 |
| Tak! | 👍 | 20:40:09 |
| charlag | what if we make activity implement interface which provides (or manipulates) bottom sheet? | 20:43:43 |
| charlag | onAttach() would check that activity conforms to it | 20:43:59 |
| Tak! | but BaseActivity is already basically that | 20:45:31 |
| charlag | well, yeah, you're right | 20:46:12 |
| 4 May 2018 |
| charlag | I'm sorry, but I'm not sure what wrong with CI. We should probably add some command to accept licenses. Not sure why it only breaks for PRs | 21:19:19 |
| charlag | Stupid question: how do you run parametrized tests from IDE? It skips them unless I press them one by one | 21:26:27 |
| 5 May 2018 |
| charlag | 
Download Screenshot_20180505-154335.png | 12:44:03 |
| charlag | 
Download Screenshot_20180505-154350.png | 12:44:09 |
| charlag | I've got a slight problem with the menu... | 12:44:18 |
| charlag | Any ideas how to fix it? I've removed theming for manifest and from layout but it still does that. No idea why | 12:51:42 |
| Tak! |
Stupid question: how do you run parametrized tests from IDE? It skips them unless I press them one by one
android studio seems a little stupid about them - you can manually modify one of the configs it autocreates to set the test class to be specifically the class that's parameterized | 17:59:25 |
| charlag | Last time I run all tests it figured it out | 18:10:17 |
| charlag | Some much for "we are pro testing" | 18:10:30 |
| 6 May 2018 |
| charlag | I think I may try to hack around that bug with menu later. I've made it behave at work before in a similar situation... | 10:27:55 |
| connyduck | https://github.com/tuskyapp/Tusky/pull/628 is the last thing needed for 1.8, once it is merged I will start testing and then its release time | 12:19:54 |
| charlag | looking at it.. | 13:34:53 |
| charlag | Sorry for being slow | 13:34:57 |
| charlag | connyduck there are some minor things about it | 13:58:19 |
 nailyk | PR is coming | 14:40:36 |
| nailyk | https://github.com/tuskyapp/Tusky/pull/632 | 14:48:39 |
| nailyk | Redacted or Malformed Event | 14:48:59 |
| nailyk | Dunno whats happend. Not able to find thoses to strings into values/strings.xml recent history | 14:49:10 |
