!PWkUGGpeMZWDPmdfRE:matrix.org

Tusky

170 Members
49 Servers

Load older messages


SenderMessageTime
19 Sep 2022
@mcc111:matrix.orgmcc111Found it under "build variants", thanks so much19:55:36
@mcc111:matrix.orgmcc111Focus selector PR is merged, tested, has some new bug/ui fixes and I think this is a candidate for merge. https://github.com/tuskyapp/Tusky/pull/2620 Two outstanding ambiguous "issues" are in the final comment. https://github.com/tuskyapp/Tusky/pull/2620#issuecomment-1251505159 (I tried adding "Tap or drag the circle to choose the focal point which will always be in view in thumbnails." to dialog_focus.xml just to test but got only errors. Sorry, that xml file was contributed by a Conny commit I think and I'm not familiar with this system... it's hard to come up with an explanation tag for that dialog which is not very wordy.)20:26:12
@mcc111:matrix.orgmcc111What should next steps with the PR be?20:26:27
20 Sep 2022
@mcc111:matrix.orgmcc111 Android Studio wants me to add performClick() to FocusIndicatorView in case someone activates that widget in an accessibility mode, but there seems to legitimately be no way to make that widget accessible. My intuition is to override it and return false (to indicate "not handled") but I'm not sure if that would do what I think it would. What's the correct thing to do there?
It seems like the ideal thing would be to hide the entire menu item in screen reader mode...
22:13:29
@mcc111:matrix.orgmcc111Updated the PR.22:29:29
21 Sep 2022
@adou:matrix.orgadou joined the room.12:29:10
@connyduck:matrix.orgconnyduckLet's merge it?18:01:55
@mcc111:matrix.orgmcc111 connyduck: Sounds good! 18:27:46
@mcc111:matrix.orgmcc111Yay. Thanks so much for the help!18:35:09
@mcc111:matrix.orgmcc111

connyduck professorneurus : So with the basic focus pr merged-- I'm still interested in trying out adding a line above-- I'd be happy to implement this if I understood what to do, the one thing I don't get, it seems like I'd need a LinearLayout followed by a FrameLayout because we don't know how big the text is?

Could that be done by editing the xml or would there need to be a manual "Make a linearlayout, inflate the framelayout as an element inside it" step? https://github.com/tuskyapp/Tusky/pull/2620/commits/d345e62e9f8e5822691ad1968850a16142bb756b#diff-f6f6f7e69e7c20bae3246de87e2e867be67e5414fceff3e1845901a4352e5757

Conny when you created that xml did you do it in the Android Studio gui editor or edit it by hand?

18:51:16
@mcc111:matrix.orgmcc111Filed 3 issues about scheduled posts ui19:42:58
25 Sep 2022
@connyduck:matrix.orgconnyduckYou want to add a text above? That should be doable with just a TextView, those can change their size according to their content.09:12:30
@connyduck:matrix.orgconnyduckI always write layouts by hand, the Gui editor usually makes stuff way too complicated.09:13:19
@connyduck:matrix.orgconnyduck

com/keylesspalace/tusky/db/TimelineDao.java:27: warning: com.keylesspalace.tusky.db.TimelineStatusWithAccount has some fields [language] which are not returned by the query.

Should be easy to fix by adding language to the query, can someone send a PR please?

11:23:00
@charlag:m.charlag.spacecharlagI can try to check tonight if no one else gets to it first11:31:20
@eviltak:matrix.orgTak!ugh sorry, I missed this in the language support PR12:07:51
@riedler:matrix.orgRiedler joined the room.19:12:37
@riedler:matrix.orgRiedlerahoy, ik there's a separate github issue regarding this, but I just wanted to ask if you think implementing reddit-style indented replies would be doable & good19:16:16
@riedler:matrix.orgRiedlerif it's easy and nonproblematic, I'd want to contribute that within a month or so19:17:26
@riedler:matrix.orgRiedler set a profile picture.19:18:06
@charlag:m.charlag.spacecharlagwhat exactly you have in mind? I have my doubt about this, we are a masto client and masto is generally very flat19:18:16
@riedler:matrix.orgRiedlerjust like reddit handles replies19:18:47
@riedler:matrix.orgRiedlerI don't see why mastodon should be flat tbh, and I don't really see how that could be incompatible with the website either - tusky doesn't have to mirror the UI of the website, no?19:20:07
@riedler:matrix.orgRiedlerIn any case, my reason why I'd like to have this is that it gets crowded very quickly when a post has 10+ replies19:20:48
@riedler:matrix.orgRiedlerand seeing which post an answer belongs to sometimes requires me to click on the answer, because the line thingy on the side is just not very informative in such cases19:21:44
@riedler:matrix.orgRiedlerbut that's just my side of things19:21:59
@charlag:m.charlag.spacecharlagthis is like changing half of the app tbh, I personally would be cool with having some action to collapse the branch of posts somehow but I don't know about indented branches19:23:53
@riedler:matrix.orgRiedlerfair; I think boost for reddit does collapsing with a long-press. Would that be desireable?19:25:40
@charlag:m.charlag.spacecharlag Maybe? I'd wait for connyduck 19:26:25
@charlag:m.charlag.spacecharlag
In reply to @connyduck:matrix.org

com/keylesspalace/tusky/db/TimelineDao.java:27: warning: com.keylesspalace.tusky.db.TimelineStatusWithAccount has some fields [language] which are not returned by the query.

Should be easy to fix by adding language to the query, can someone send a PR please?

https://github.com/tuskyapp/Tusky/pull/2710
19:27:03

There are no newer messages yet.


Back to Room List