1 May 2018 |
charlag | `void isRefence() { return !s.isEmpty() && s.charAt(0) == '@'; }` | 17:39:53 |
Constantin A. | EmojiCompat should be fixed now. | 17:40:08 |
Constantin A. | Tak!: It should work now. As I expected there was a NullPointerException which could easily be solved by adding an additional check. | 17:44:22 |
Tak! | oh right, npe - now I've outed myself as a .net developer 😝 | 17:48:00 |
charlag | :oh_noes: | 17:50:36 |
charlag | I'm not the person who easily gives up but I gave up to test timeline through Robolectric. It would be okay if I didn't have to fight million bugs but not this way. So I just went and fixed some things. https://github.com/tuskyapp/Tusky/pull/562 | 20:06:47 |
2 May 2018 |
Tak! | ok, I've separated out the SpanUtils refactorings on https://github.com/Tak/Tusky/commits/issue-573 | 07:59:52 |
charlag | great! | 08:50:20 |
charlag | connyduck: do I need your approval for merging Tak's tests? | 08:51:00 |
charlag | I cannot check why CI build fails... | 09:12:46 |
charlag | Okay, I've set up a CircleCI https://github.com/tuskyapp/Tusky/pull/621 | 10:05:37 |
connyduck | you can merge it | 18:33:06 |
connyduck | Is it ok if I give you owner access so you can set up circle ci? If it has public build logs its probably better than bitrise | 18:34:35 |
connyduck | build on #562 fails because "src/app/src/main/java/com/keylesspalace/tusky/fragment/SearchFragment.kt: (126, 5): 'removeAllByAccountId' overrides nothing" | 18:40:24 |
charlag | I think it's okay!
Thanks, I'll fix it, wonder why it builds locally, maybe some cache | 19:45:39 |
charlag | I think they should be public Technomancy works there and offered their help so we're cool! | 19:48:00 |
connyduck | you have an invitation | 20:03:59 |
charlag | Thx! | 20:25:28 |
charlag | I don't see an invitation anywhere... | 20:45:23 |
connyduck | should be in your emails | 20:46:12 |
connyduck | or maybe on https://github.com/tuskyapp | 20:46:21 |
charlag | I see now! Thanks | 20:48:30 |
3 May 2018 |
| rubah joined the room. | 02:10:16 |
charlag | Can anyone confirm that they can see circleci logs here? https://github.com/tuskyapp/Tusky/pull/623 | 06:35:04 |
charlag | I think we may even have 3 containers because we're FLOSS projects. It is now set up to build all commits, not only PR but we can change that if it becomes too busy. | 06:37:06 |
Tak! | I guess that would be a good problem to have ☺ | 14:33:10 |
connyduck | circleci fails because licenses not accepted lol https://circleci.com/gh/tuskyapp/Tusky/3?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link | 17:54:41 |
connyduck | https://github.com/tuskyapp/Tusky/issues/625 | 18:34:19 |
connyduck | Tak!: please have a look https://github.com/tuskyapp/Tusky/pull/628 | 20:17:14 |
charlag | They're failing only for PRs?... | 20:23:12 |