17 Sep 2022 |
Moses Turner | I don't think it matters, it's very easy to change | 00:42:25 |
Moses Turner | I'd pick somewhere, write the code, then open a MR and see if people want you to stick the file somewhere else | 00:42:27 |
happysmash27#7060 | Good point. This reminds me, that I always seem to act as if everything is and will be set in stone, when in many cases, and in this case, it most likely will not be. | 00:42:28 |
Moses Turner | yeah, no, work on Monado or in the OpenXR WG for a while and see how not set in stone things are :) | 00:42:36 |
Moses Turner | You can totally write mediocre code, get somebody to say "yeah looks useful enough" and merge it, then come back later and make it really nice | 00:43:05 |
Moses Turner | for me there's a bit of mythology to it lol, that's the way I do everything | 00:44:04 |
Moses Turner | our hand tracking, a solution to what really is a very hard problem came into existence because of moses writing bad code at 3am for months | 00:44:41 |
happysmash27#7060 | Ooh, just realised there is an entire doc directory with files like conventions.md . Reading that now as it seems it may be very useful. | 00:50:21 |
happysmash27#7060 | That very document even answers me question on what XRT stands for, heh. This should be very useful indeed. | 00:51:56 |
| It's A Freaking Penguin joined the room. | 16:40:27 |
18 Sep 2022 |
| 0ups joined the room. | 21:04:50 |
19 Sep 2022 |
| Gank joined the room. | 03:43:55 |
20 Sep 2022 |
| tokeiyo joined the room. | 03:10:33 |
| EthnikaMpoutia joined the room. | 13:36:13 |
| HHH joined the room. | 22:33:14 |
21 Sep 2022 |
| TeH_Venom joined the room. | 01:37:16 |
22 Sep 2022 |
happysmash27#7060 | Download 2022-09-21-232243_1280x998_scrot.png | 06:24:54 |
happysmash27#7060 | I'm pleasantly surprised that the compiler is smart enough to know that "start" and "init" are synonyms! | 06:24:54 |
happysmash27#7060 | Though, in this case it's actually the header file that's wrong, I think. I renamed it in the main source without renaming it in the cooresponding header. | 06:24:55 |
| mhuzai joined the room. | 19:13:55 |
mhuzai | Is there a design document for the compositor (swapchains, rendering, display, etc.)? | 19:13:58 |
pblack#8962 | Redacted or Malformed Event | 19:52:14 |
pblack#8962 | As far as I am aware, the short answer is no - however the areas you mentioned aren't particularly mysterious once you attach a debugger and follow your nose around the code. There may be some high level module diagrams, or autogenerated code structure diagrams floating around but I don't have any links close to hand.
Familiarity with Vulkan is going to be very helpful in the parts of the monado code you mention - as it will be quite hard to fully grok the rendering code without knowledge of the API it is based on, and things such as swapchains are heavily influenced/inspired by the Vulkan implementation of this functionality.
If you have specific questions on things that defy your attempts to understand them, then you can ask here and usually you will get assistance from the people who wrote or maintain the code in question, but due to the resource constraints that affect all such projects managed by a small team, and the fact that various pieces of monado are not considered 'fully done' or are subject to change/rearchitecture - there is less formal documentation than there could be. I am sure any contributions of such would be gratefully accepted. | 20:03:39 |
Supreme#9828 | there are doxygen docs at least | 20:10:59 |
mhuzai | Thank you for that detailed response! | 22:19:58 |
23 Sep 2022 |
happysmash27#7060 | In which types of contexts would oxr_xrCreateInstance in oxr_api_instance.c /oxr_api_funcs.h be used? Since that calls oxr_instance_create() which calls xrt_instance_create_system() , which needs autorunner info to determine whether to warm start or cold start from ipc_server_process.c , I need to figure out how to deal with the autorunner struct there too. | 19:59:24 |
Supreme#9828 | that would be called whenever xrCreateInstance is called wouldn't it? and that's called directly by apps | 20:14:15 |
Moses Turner | I think you may be mis-parsing the structure - xrCreateInstance only creates an xrt_instance if you're in non-service/in-process mode | 20:19:25 |
Moses Turner | In which case an autorun app would not be possible or desired | 20:19:26 |
24 Sep 2022 |
| Gold John King joined the room. | 14:44:43 |