| 8 Aug 2018 |
|  Philippe Camacho joined the room. | 02:35:10 |
| Philippe Camacho changed their display name from leloup to Philippe Camacho. | 02:53:16 |
| Philippe Camacho set a profile picture. | 02:54:16 |
| Philippe Camacho | Hello, I ran the tests of in the master branch and this is the result:
=== 229 passed, 9 skipped, 49 error in 10.34 seconds ==============
On the other hand on branch fea/sprite-eth we have
================ 320 passed, 11 skipped in 25.03 seconds =============== | 04:30:17 |
| Philippe Camacho | Why not update the master branch? | 04:30:49 |
| Philippe Camacho | Also when I rerun the test on the fea branch I get some errors:
================= 318 passed, 11 skipped, 2 error in 24.12 seconds =============== | 04:32:05 |
 @mathis:matrix.org | Thanks for trying it out. I think there shouldn't be any failures on the master branch so will check. The branch fea/sprite-eth is something sunnycyk worked on for another project, basically removing the tokens and just using ether as currency for the payment channels. I haven't looked at it in detail but think we can merge it into master eventually. | 04:41:05 |
| @mathis:matrix.org | If you remove the PisaChannel.sol the tests on master pass so I think it's related to the failing compiliation of that file. I will try to find some time this week to set up continuous integration so at least we know about the build status. | 04:43:47 |
 sunnycyk | Which tests failed? | 04:44:09 |
| @mathis:matrix.org | Redacted or Malformed Event | 04:45:08 |
| @mathis:matrix.org | I also have the tests passing on fea/sprite-eth. | 04:45:16 |
| Philippe Camacho | mathis: I just sent you the trace of execution of the tests by email. | 04:49:00 |
| @mathis:matrix.org | Ok I'll have a look, please also feel free to open issues on github. | 04:52:52 |
| Philippe Camacho | @sun | 05:04:15 |
| Philippe Camacho | sunnycyk: I created ticket https://github.com/enumatech/sprites-python/issues/6 | 05:04:27 |
| sunnycyk | ok thanks. i will take a look. | 05:04:47 |
| @mathis:matrix.org | Thanks. Based on a quick look I think it's related to some contracts not being compiled. | 05:08:35 |
| @mathis:matrix.org | The trace in the email I mean. | 05:08:43 |
| Philippe Camacho | mathis: after removing contract PisaChannel.sol, all tests pass for me as well | 05:08:51 |
| Philippe Camacho | (on master) | 05:08:55 |
| @mathis:matrix.org | ok thanks! | 05:08:56 |
| Philippe Camacho | yw | 05:09:02 |
| @mathis:matrix.org | I updated the nixpkgs tarball and increased the minimum solidity version to 0.4.24 on master. All tests should pass now. We were just using a solidity version that didn't support some of the features the PisaChannel contract used. | 09:48:09 |
| 20 Aug 2018 |
| sunnycyk | David Leung: https://en.bitcoin.it/wiki/Hashed_Timelock_Contracts | 03:20:24 |
| 27 Aug 2018 |
|  @lionello:matrix.orgchanged room power levels. | 09:36:24 |
| 2 Sep 2018 |
| @lionello:matrix.org | Redacted or Malformed Event | 08:14:51 |
| 14 Nov 2018 |
| @lionello:matrix.org | Tamas Herman: Let's keep this group alive with updates | 08:31:25 |
| 11 Jan 2019 |
|  @jasonzhouu:matrix.org left the room. | 05:11:21 |
| 21 May 2019 |
| @lionello:matrix.org | FYI, Sprites has been released here https://github.com/enumatech/sprites | 03:37:04 |
| 25 Aug 2019 |
|  @fernducdiawar5:matrix.org joined the room. | 11:23:10 |
