!NasysSDfxKxZBzJJoE:matrix.org

#matrix-spec

1052 Members
Discussion of specific Matrix Spec Change proposals | https://matrix.org/docs/spec/proposals | Design draft folder at: https://drive.google.com/drive/folders/0B4wHq8qP86r2ck15MHEwMmlNVUk 336 Servers

Load older messages

SenderMessageTime
14 Jan 2020
@andrewm:amorgan.xyzanoa Sorunome: are you providing your session ID as a query param? 14:30:31
@andrewm:amorgan.xyzanoa session? 14:30:34
@sorunome:sorunome.deSorunomeyes14:30:37
@andrewm:amorgan.xyzanoahuh14:30:54
@sorunome:sorunome.deSorunomethe internel server error is after accepting the terms, so on the POST step14:31:09
@andrewm:amorgan.xyzanoa

The traceback is:

2020-01-14 14:19:53,169 - synapse.access.http.8080 - 233 - INFO - POST-1176632 - 93.241.62.202 - 8080 - Received request: POST /_matrix/client/r0/auth/m.login.terms/fallback/web
2020-01-14 14:19:53,169 - synapse.http.server - 109 - ERROR - POST-1176632 - Failed handle request via 'AuthRestServlet': <XForwardedForRequest at 0x7fecb71c5860 method='POST' uri='/_matrix/client/r0/auth/m.login.terms/fallback/web' clientproto='HTTP/1.1' site=8080>
Capture point (most recent call last):
  File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/synapse/src/synapse/app/homeserver.py", line 639, in <module>
    main()
  File "/home/synapse/src/synapse/app/homeserver.py", line 635, in main
    run(hs)
  File "/home/synapse/src/synapse/app/homeserver.py", line 626, in run
    logger=logger,
  File "/home/synapse/src/synapse/app/_base.py", line 137, in start_reactor
    daemon.start()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/daemonize.py", line 248, in start
    self.action(*privileged_action_result)
  File "/home/synapse/src/synapse/app/_base.py", line 114, in run
    run_command()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py", line 1283, in run
    self.mainLoop()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py", line 1295, in mainLoop
    self.doIteration(t)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/epollreactor.py", line 235, in doPoll
    log.callWithLogger(selectable, _drdw, selectable, fd, event)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/log.py", line 103, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/log.py", line 86, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/posixbase.py", line 614, in _doReadOrWrite
    why = selectable.doRead()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/tcp.py", line 243, in doRead
    return self._dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/tcp.py", line 249, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2985, in dataReceived
    return self._channel.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2266, in dataReceived
    return basic.LineReceiver.dataReceived(self, data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/protocols/basic.py", line 579, in dataReceived
    why = self.rawDataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2273, in rawDataReceived
    self._transferDecoder.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 1754, in dataReceived
    finishCallback(data[contentLength:])
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2170, in _finishRequestBody
    self.allContentReceived()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2245, in allContentReceived
    req.requestReceived(command, path, version)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 945, in requestReceived
    self.process()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/server.py", line 235, in process
    self.render(resrc)
  File "/home/synapse/src/synapse/http/site.py", line 132, in render
    Request.render(self, resrc)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/server.py", line 302, in render
    body = resrc.render(self)
  File "/home/synapse/src/synapse/http/server.py", line 298, in render
    defer.ensureDeferred(self._async_render(request))
  File "/home/synapse/src/synapse/logging/context.py", line 560, in g
    return run_in_background(f, *args, **kwargs)
  File "/home/synapse/src/synapse/logging/context.py", line 591, in run_in_background
    res = defer.ensureDeferred(res)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 911, in ensureDeferred
    return _cancellableInlineCallbacks(coro)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
    _inlineCallbacks(None, g, status)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/synapse/src/synapse/http/server.py", line 204, in wrapped_async_request_handler
    await h(self, request)
Traceback (most recent call last):
  File "/home/synapse/src/synapse/http/server.py", line 77, in wrapped_request_handler
    await h(self, request)
  File "/home/synapse/src/synapse/http/server.py", line 326, in _async_render
    callback_return = await callback_return
  File "/home/synapse/src/synapse/rest/client/v2_alpha/auth.py", line 212, in on_POST
    session = request.args["session"][0]
KeyError: 'session'
14:31:25
@andrewm:amorgan.xyzanoa ...and right above that is if "session" not in request.args: raise ... o_o 14:32:14
@krille:ubports.chatkrilleafter accepting the terms, the page is redirected to the same page without the session query parameter14:32:25
@krille:ubports.chatkrilleLooks like this is another bug14:32:33
@sorunome:sorunome.deSorunome
In reply to @andrewm:amorgan.xyz

The traceback is:

2020-01-14 14:19:53,169 - synapse.access.http.8080 - 233 - INFO - POST-1176632 - 93.241.62.202 - 8080 - Received request: POST /_matrix/client/r0/auth/m.login.terms/fallback/web
2020-01-14 14:19:53,169 - synapse.http.server - 109 - ERROR - POST-1176632 - Failed handle request via 'AuthRestServlet': <XForwardedForRequest at 0x7fecb71c5860 method='POST' uri='/_matrix/client/r0/auth/m.login.terms/fallback/web' clientproto='HTTP/1.1' site=8080>
Capture point (most recent call last):
  File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/synapse/src/synapse/app/homeserver.py", line 639, in <module>
    main()
  File "/home/synapse/src/synapse/app/homeserver.py", line 635, in main
    run(hs)
  File "/home/synapse/src/synapse/app/homeserver.py", line 626, in run
    logger=logger,
  File "/home/synapse/src/synapse/app/_base.py", line 137, in start_reactor
    daemon.start()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/daemonize.py", line 248, in start
    self.action(*privileged_action_result)
  File "/home/synapse/src/synapse/app/_base.py", line 114, in run
    run_command()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py", line 1283, in run
    self.mainLoop()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/base.py", line 1295, in mainLoop
    self.doIteration(t)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/epollreactor.py", line 235, in doPoll
    log.callWithLogger(selectable, _drdw, selectable, fd, event)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/log.py", line 103, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/log.py", line 86, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/context.py", line 122, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/python/context.py", line 85, in callWithContext
    return func(*args,**kw)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/posixbase.py", line 614, in _doReadOrWrite
    why = selectable.doRead()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/tcp.py", line 243, in doRead
    return self._dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/tcp.py", line 249, in _dataReceived
    rval = self.protocol.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2985, in dataReceived
    return self._channel.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2266, in dataReceived
    return basic.LineReceiver.dataReceived(self, data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/protocols/basic.py", line 579, in dataReceived
    why = self.rawDataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2273, in rawDataReceived
    self._transferDecoder.dataReceived(data)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 1754, in dataReceived
    finishCallback(data[contentLength:])
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2170, in _finishRequestBody
    self.allContentReceived()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 2245, in allContentReceived
    req.requestReceived(command, path, version)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/http.py", line 945, in requestReceived
    self.process()
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/server.py", line 235, in process
    self.render(resrc)
  File "/home/synapse/src/synapse/http/site.py", line 132, in render
    Request.render(self, resrc)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/web/server.py", line 302, in render
    body = resrc.render(self)
  File "/home/synapse/src/synapse/http/server.py", line 298, in render
    defer.ensureDeferred(self._async_render(request))
  File "/home/synapse/src/synapse/logging/context.py", line 560, in g
    return run_in_background(f, *args, **kwargs)
  File "/home/synapse/src/synapse/logging/context.py", line 591, in run_in_background
    res = defer.ensureDeferred(res)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 911, in ensureDeferred
    return _cancellableInlineCallbacks(coro)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 1529, in _cancellableInlineCallbacks
    _inlineCallbacks(None, g, status)
  File "/home/synapse/env-py37/lib/python3.7/site-packages/twisted/internet/defer.py", line 1418, in _inlineCallbacks
    result = g.send(result)
  File "/home/synapse/src/synapse/http/server.py", line 204, in wrapped_async_request_handler
    await h(self, request)
Traceback (most recent call last):
  File "/home/synapse/src/synapse/http/server.py", line 77, in wrapped_request_handler
    await h(self, request)
  File "/home/synapse/src/synapse/http/server.py", line 326, in _async_render
    callback_return = await callback_return
  File "/home/synapse/src/synapse/rest/client/v2_alpha/auth.py", line 212, in on_POST
    session = request.args["session"][0]
KeyError: 'session'
well, that code seems wrong 		14:32:33
@sorunome:sorunome.deSorunome

a bit above you have

        session = parse_string(request, "session")
        if not session:
            raise SynapseError(400, "No session supplied")
14:32:42
@andrewm:amorgan.xyzanoahttps://github.com/matrix-org/synapse/blob/9c41ba4c5fe6e554bc885a1bef8ed51d14ec0f3e/synapse/rest/client/v2_alpha/auth.py#L21214:32:46
@sorunome:sorunome.deSorunomehttps://github.com/matrix-org/synapse/blob/master/synapse/rest/client/v2_alpha/auth.py#L17414:32:48
@andrewm:amorgan.xyzanoalol, duplicated check14:33:08
@sorunome:sorunome.deSorunome
In reply to @andrewm:amorgan.xyz
https://github.com/matrix-org/synapse/blob/9c41ba4c5fe6e554bc885a1bef8ed51d14ec0f3e/synapse/rest/client/v2_alpha/auth.py#L212
resulting in incorrectly re-defining the session there 		14:33:16
@sorunome:sorunome.deSorunome
In reply to @andrewm:amorgan.xyz
lol, duplicated check
prolly an old one that was forgotten to remove 		14:33:26
@sorunome:sorunome.deSorunomehence the internel server error14:33:31
@andrewm:amorgan.xyzanoayep, will make a pr14:33:43
@krille:ubports.chatkrillethis has propably nothing to do with the problem, that recaptcha cant be done with the web fallback14:33:57
@sorunome:sorunome.deSorunome
In reply to @krille:ubports.chat
this has propably nothing to do with the problem, that recaptcha cant be done with the web fallback
was about to say this 		14:34:06
@andrewm:amorgan.xyzanoa krille: you're facing a separate problem 14:34:14
@sorunome:sorunome.deSorunome the only thing soru can think of right now is that somehow the session is invalid resulting in here a new session being created 14:34:29
@sorunome:sorunome.deSorunome meaning that this somehow doesn't correctly fetch the session 14:34:47
@andrewm:amorgan.xyzanoaOh, so you're saying that no fallback POSTs are working?14:35:57
@sorunome:sorunome.deSorunomewell, there are two currently: the recaptcha one which isn't working and the terms one which internal server errors. Hard to try any more :D14:36:19
@sorunome:sorunome.deSorunome(without setting that stuffs up locally)14:36:44
@andrewm:amorgan.xyzanoaI'd be surprised if it was parse_string's fault. We use it everywhere.14:37:08
@sorunome:sorunome.deSorunomemaybe some variable passing around is off then.....FIIIIIINE soru'll debug locally14:37:27
@sorunome:sorunome.deSorunome but, just to be clear, whcih is why soru recommended krille to ask in here....that is actually how you are supposed to do it as per spec? 14:37:44
* @andrewm:amorgan.xyzanoa refreshes himself on what the spec says14:38:28

Show newer messages

Back to Room ListRoom Version: 5