| 2 Jul 2020 |
 Sorunome | PLs | 21:28:17 |
| 3 Jul 2020 |
 reivilibre | Anyone know off the top of their head whether an event's content field is always a dict if it's provided? | 08:49:08 |
 Timo | 
Download image.png | 08:51:20 |
| Timo | Spec calls it object which JSON's name for dicts afaik | 08:51:39 |
| reivilibre | Thanks, perfect. I was searching for 'EventContent' as it's called in other parts of the spec, oups | 08:52:16 |
| Timo | * Spec calls it object which JSON's name for dicts afaik | 08:52:15 |
| Timo | https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-rooms-roomid-state | 08:52:46 |
| reivilibre | by the way, I believe you are responsible for Conduit, which makes me happy inside, so thanks for doing that :) | 08:56:15 |
 richvdh | In reply to @reivilibre:librepush.net
Anyone know off the top of their head whether an event's content field is always a dict if it's provided? as a rule: applications need to treat event data as untrusted | 08:56:20 |
| richvdh | ie, they should not segfault if they get a content which turns out to be an int | 08:57:04 |
| Timo | Yeah, not segfault, but it's okay to reject, right? | 08:57:28 |
| richvdh | as a client: I'd have thought you should just ignore it | 08:57:48 |
| reivilibre | yes true (and somewhat 'of course', but if we complain and don't handle it in an innocent way I think that'd be OK? | 08:57:57 |
| * Timo doesn't need to worry about segfaults, he uses rust | 08:58:00 |
| richvdh | :) | 08:58:16 |
| reivilibre | I've made Python segfault doing semi-innocent stuff before now o.O | 08:58:57 |
| richvdh | (sending malformed events is a good way to make everyone's riot-web stop working. so yeah, not segfault, but...) | 08:59:42 |
 JulianF | Redacted or Malformed Event | 09:39:10 |
| JulianF | * | 09:40:22 |
| reivilibre | Is this a spec bug? actions should probably not be [enum] as each action could have parameters at which point it should be a dict e.g.
{
"set_tweak": "sound",
"value": "bing!"
}
| 13:14:26 |
| reivilibre | in: https://matrix.org/docs/spec/client_server/r0.6.1#put-matrix-client-r0-pushrules-scope-kind-ruleid-actions | 13:14:31 |
| reivilibre | welp, I jjust misclicked 'Search' instead of 'Copy' when copying my access token to test something :/ | 13:22:57 |
 anoa | whoopsie | 13:23:23 |
| reivilibre | In reply to @reivilibre:librepush.net
in: https://matrix.org/docs/spec/client_server/r0.6.1#put-matrix-client-r0-pushrules-scope-kind-ruleid-actions I think this is probably a spec bug; how to handle it?
Synapse implements what I would consider 'what should have been specced', i.e. returns
{
"actions": [
"notify",
{
"set_tweak": "highlight",
"value": true
}
]
}
even though the set_highlight is not a string...
| 14:02:33 |
| anoa | If it's one or two instances that are typos, then file a bug at https://github.com/matrix-org/matrix-doc/issues and/or feel free to submit a PR with a fix. But... if it's intended and Synapse acts a different way, an MSC is in order. | 14:05:31 |
| reivilibre | I think it's a typo because it makes no sense otherwise (you can't properly represent an action as a string or enum) | 14:06:23 |
 davo | I think the examples also have set_tweak objects as well | 14:07:09 |
| anoa | Probably a spec bug then and you can submit a PR | 14:46:19 |
|  MichaelRaskin joined the room. | 19:51:44 |
|  sbug changed their profile picture. | 22:48:48 |
