!NasysSDfxKxZBzJJoE:matrix.org

#matrix-spec

1052 Members
Discussion of specific Matrix Spec Change proposals | https://matrix.org/docs/spec/proposals | Design draft folder at: https://drive.google.com/drive/folders/0B4wHq8qP86r2ck15MHEwMmlNVUk 336 Servers

Load older messages


SenderMessageTime
17 Jan 2020
@richvdh:sw1v.orgrichvdh
In reply to @sorunome:sorunome.de
also, how come synapse implements m.login.jwt? Don't see anything of that in the specs, either
because it got implemented by a community contribution. I'm not sure if it works or if it has ever been tested
10:56:55
@sorunome:sorunome.deSorunome
In reply to @richvdh:sw1v.org
which doc

https://github.com/matrix-org/synapse/blob/master/docs/password_auth_providers.md

"get_supported_login_types" and "check_auth" specify any type, not just m.login.password

10:57:12
@sorunome:sorunome.deSorunome
In reply to @richvdh:sw1v.org
well, the only thing that is valid to pass into m.login.token is something that synapse has generated
just tested and it seems to be fully functional. However, it seems more like it should be part of m.login.token, as, in essence, it is just a token
10:57:42
@richvdh:sw1v.orgrichvdhno, that's really not how token login is meant to work10:57:57
@richvdh:sw1v.orgrichvdhit sounds like you're implementing something which isn't m.login.token, which means you should use a different auth type10:59:24
@sorunome:sorunome.deSorunomehttps://matrix.org/docs/spec/client_server/latest#token-based doesn't say anywhere at all what type of token the token is supposed to be10:59:45
@sorunome:sorunome.deSorunomesounds like the spec is incomplete, then10:59:51
@sorunome:sorunome.deSorunome

The server must encode the user id in the token. There is therefore no need for the client to submit a separate username.

Doesn't specify how at all

11:00:28
@richvdh:sw1v.orgrichvdhit's up to the server implementation11:01:02
@sorunome:sorunome.deSorunome richvdh: exactly. Which means the docs for synapse auth provider is wrong, then, if it expects macrons and not any tokens 11:01:19
@sorunome:sorunome.deSorunome either way, something doesn't add up here 11:01:32
@sorunome:sorunome.deSorunomeeither the spec, or synapse, or both11:01:41
@jan.christian:gruenhage.xyzjcgruenhageOkay, so m.login.token tokens are supposed to be created and consumed by the homeserver, with the delivery being via some third party means?11:01:42
@richvdh:sw1v.orgrichvdh jcgruenhage: at the moment the only specced use of m.login.token is in https://matrix.org/docs/spec/client_server/latest#module-sso-login 11:02:47
@richvdh:sw1v.orgrichvdhbut the intention is that maybe there could be other ways of getting hold of a login token in the future, which is why the docs on token-based login are a little vague11:03:24
* @sorunome:sorunome.deSorunome has the feeling we are drifting away from what soru was originally asking11:03:31
* @sorunome:sorunome.deSorunome wonders if synapse-dev is a more accurate channel for one of the two questions11:03:56
@richvdh:sw1v.orgrichvdhthe is that you can't just go and implement your own auth provider which claims to implement m.login.token but uses your own style of tokens11:04:49
@richvdh:sw1v.orgrichvdh * the point is that you can't just go and implement your own auth provider which claims to implement m.login.token but uses your own style of tokens11:05:00
@sorunome:sorunome.deSorunome
In reply to @richvdh:sw1v.org
the point is that you can't just go and implement your own auth provider which claims to implement m.login.token but uses your own style of tokens
why? Which part of the spec prohibits that?
11:05:31
* @sorunome:sorunome.deSorunome read it through multiple times and couldn't find any such segment 11:05:46
@richvdh:sw1v.orgrichvdhthe spec should say that m.login.token is for tokens generated by the homeserver11:06:51
@richvdh:sw1v.orgrichvdhI agree that https://matrix.org/docs/spec/client_server/latest#token-based is a bit misleading11:07:20
@sorunome:sorunome.deSorunome
In reply to @richvdh:sw1v.org
the spec should say that m.login.token is for tokens generated by the homeserver
"should" say isn't the same as "does" say. So, consider this a spec bug report?
11:08:05
@richvdh:sw1v.orgrichvdhfile an issue then11:08:30
@sorunome:sorunome.deSorunomehttps://github.com/matrix-org/matrix-doc/issues/241211:11:25
@jan.christian:gruenhage.xyzjcgruenhageThat means that there currently is no way to log in to a spec compliant homeserver by possession of a token signed by a third party, because m.login.token is specifically a token created by the homeserver?11:11:43
@jan.christian:gruenhage.xyzjcgruenhage"spec compliant homeserver" is intentionally abstract, because (afaict) one like that can't exist, I'm not referring to any specific implementation there11:12:59
@richvdh:sw1v.orgrichvdh jcgruenhage: well, you'd have to make assumptions about the format of the token, which you can't do while conforming to the spec 11:13:36
@richvdh:sw1v.orgrichvdhit begins to feel like you're looking for something like oauth, which is certainly a thing that the spec should support11:14:42

There are no newer messages yet.


Back to Room ListRoom Version: 5