Sender | Message | Time |
---|---|---|
19 Apr 2024 | ||
L3MON4D3 | Bets put that whole block into "if current", as before, but apart from that this looks sound👍 I think true is correct, could you check how jump is specified in DOC.md? It should be somewhere near the end :D Now all that's missing is the conditional on a new config-variable (exit_roots?) and that this variable defaults to `history`. For an example of that, I think the big commit that broke the behaviour has some changes to config.lua that should be similar to what you have to do :) | 10:45:36 |
gokberkgunes | jump(direction): returns true if the jump was successful. Alright, this is correct. Working on new variable, and documentation. | 11:02:32 |
gokberkgunes | *
Working on new variable, and documentation. | 11:02:43 |
gokberkgunes | *
Working on the new variable and the documentation. | 11:02:54 |
gokberkgunes | L3MON4D3: should we not always exit when reaching $0? I am confused right now. Was not the old behavior like this? | 11:08:17 |
gokberkgunes | Or was this only the case when history was set to false? | 11:08:49 |
L3MON4D3 | Yeah exactly, only if history is false, which was the default | 11:10:26 |
L3MON4D3 | With history=true the snippet remained active | 11:10:46 |
gokberkgunes | 👍️ | 11:10:52 |
gokberkgunes | Does setting When This simulates old behavior, correctly, does it not? | 11:29:41 |
gokberkgunes | Secondly, do you think it is good idea to leave the outer if statement as it is?
Naturally, can take it into the inner if statement, but it appears harder to read. | 11:31:22 |
L3MON4D3 | In reply to @gokberkgunes:matrix.orgAhh right, yes👍👍 | 18:44:31 |
L3MON4D3 | In reply to @gokberkgunes:matrix.orgI'd agree that leaving the config-setting in its own if is more readable👍 Leave it like that :D | 18:46:30 |
gokberkgunes | I have pushed the new commit though there is a single test failing right now. | 19:57:09 |
20 Apr 2024 | ||
L3MON4D3 | Mhmm, I'm pretty sure that's unrelated to your change, and I thought one very recent commit to master fixed this. Are your commits based on current master? | 08:44:36 |
gokberkgunes | Download image.png | 09:30:03 |
gokberkgunes | Yes, they are based on current master | 09:30:18 |
21 Apr 2024 | ||
gokberkgunes | L3MON4D3: Are you available to check the test I have generated? It appears to be working good so far. | 10:12:31 |
gokberkgunes | Here is the file
| 10:13:41 |
L3MON4D3 | I'll check this evening :) | 11:10:18 |
gokberkgunes | Alright. I thought if there should be more actions in the test but current actions appears to be enough. Let me know if you have any feedback. | 11:11:25 |
gokberkgunes | * Alright. I thought if there should be more actions in the test but current actions appears to be enough. Let me know if you have any feedback. Maybe a test case where exit_roots set to false could also be useful. What do you say? | 11:26:42 |
L3MON4D3 | I think the test looks good👍 +1 for another test with exit_roots false :D | 17:12:09 |
gokberkgunes | I'm on it | 18:04:25 |
23 Apr 2024 | ||
gokberkgunes | Redacted or Malformed Event | 11:51:00 |
gokberkgunes | L3MON4D3: While adding exit_roots = false to tests, options set by ls_helpers.session_setup_luasnip({ hl_choiceNode = true }) appears to get overwritten. Is there any tips that I can just set exit_roots to false without affecting other settings? Currently, I'm trying to alter failing tests in luasnip/tests/integration/session_spec.lua | 12:18:42 |
gokberkgunes | Using I guess it's possible using session. I got it I guess. | 12:27:00 |
L3MON4D3 | Uh, there's an option to that function that controls the values in ls.setup, check tests/helpers.lua | 12:27:16 |
gokberkgunes | Any preferences to use in a test function below? Additionally, is there any difference in changing setup as given in 2nd case? I am worried if first approach will alter behavior of other tests.
| 13:21:16 |
L3MON4D3 | I'd prefer the first; tests that require a clean slate should reset the entire state anyway (mostly done in `before_each`) | 13:34:49 |