13 Aug 2024 |
nex (she/it) | oh thank god, I didn't know if it was worth opening an issue about dependency blocks lol | 18:45:18 |
nex (she/it) | @Paarth Shah - Github Maintainer What's breaking about #489? The changes aren't described | 19:07:24 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk @Paarth Shah - Github Maintainer What's breaking about #489? The changes aren't described Darn I knew I was missing something in that changelog lol. I'll update it later to be clearer, but #489 resolves this issue Which was technically a Matrix spec v1.1 support issue, relating to the use of /r0/ vs /v3 in endpoints (and for newer endpoints such as threading, /v2 ... which was very fun to parse through lol)
TLDR: if you have a matrix homeserver that isn't compatible with Matrix v1.1 of the matrix spec, matrix-nio 0.25.0 (nor 0.25.0rc1 or beyond) would work for you. If you've already been using an RC without issue, then there's no problem. If you aren't using a spec-noncompliant homeserver, then there's also no problem.
Realistically, I'm not even expecting anyone to be affected by this, hence why I was lazy about the full cause of the "break"... but it seemed intellectually honest to include it.
| 19:53:49 |
nex (she/it) | I think even Dendrite supports v1.2, so afaik all four major homeserver implementations are unaffected by this | 19:55:05 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk oh thank god, I didn't know if it was worth opening an issue about dependency blocks lol Funny thing is that the original reason I became a maintainer was so that I could get in and fix dependency blocks... so maybe I need to think about a way to make the dependencies a lot more flexible to make this stop being a problem. Maybe this is my excuse to get rid of poetry :^) | 19:55:43 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk oh thank god, I didn't know if it was worth opening an issue about dependency blocks lol * Funny thing is that the original reason I became a maintainer was so that I could get in and fix dependency blocks... so maybe I need to think about a way to make the dependencies a lot more flexible to make this stop being a problem. Maybe this is my excuse to get rid of poetry :^)
Anyway, always feel free to make an issue for that, it's one of the easier things to do and I'm happy to handle it/accept PRs for it
| 19:56:07 |
nex (she/it) | Don't you make use of GitHub's dependabot? that would probably make most dependency updates an one-click solution in most cases | 19:56:29 |
nex (she/it) | I'll open an issue for it so it doesnt get lost | 19:56:44 |
nex (she/it) | Opened #515 | 19:59:51 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk Don't you make use of GitHub's dependabot? that would probably make most dependency updates an one-click solution in most cases I do, and there's even a PR it opened as recently as 3 days ago. I think the issue with it is twofold:
- it only automatically modifies
rtd-requirements.txt , while actual package requirements are set within pyproject.toml
- even with modifying
pyproject.toml , we'd still need to bump the package version + add a git tag to trigger an automatic publish to pypi (which is still a vast improvement on what we had to do pre 0.25.0rc1 , which was manually do python -m build . and manually upload to pypi).
Basically, I have it on my personal todo list to configure dependabot to work better, and to add a github action to automatically bump versions and do things. Once that's in place, this all gets a lot easier to do on a whim
| 20:00:04 |
nex (she/it) | Oh yeah, I forgot there's a bunch of different requirements files in the repo | 20:01:08 |
Paarth Shah - Github Maintainer | Perfect world solution is that the pyproject.toml itself gets modified by dependabot/used by readthedocs , and all is well | 20:02:11 |
nex (she/it) | Doesn't rtd require a seperate requirements.txt file in its configuration? | 20:03:54 |
nex (she/it) | Oh actually | 20:04:44 |
nex (she/it) | https://docs.readthedocs.io/en/stable/config-file/v2.html#packages | 20:04:45 |
nex (she/it) | version: 2
python:
install:
- method: pip
path: .
extra_requirements:
- docs
Looks like you can install an extra from pyproject.toml, which might make that a lot easier | 20:05:07 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk
version: 2
python:
install:
- method: pip
path: .
extra_requirements:
- docs
Looks like you can install an extra from pyproject.toml, which might make that a lot easier And immediately I know exactly how I'm going to do this lol | 20:15:21 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk
version: 2
python:
install:
- method: pip
path: .
extra_requirements:
- docs
Looks like you can install an extra from pyproject.toml, which might make that a lot easier * And immediately I know exactly how I'm going to do this lol Ty for finding this! | 20:15:36 |
nex (she/it) | no worries. I'm keeping the github issue updated in line with the stuff here | 20:16:26 |
Paarth Shah - Github Maintainer | In reply to @nex:nexy7574.co.uk no worries. I'm keeping the github issue updated in line with the stuff here Yep I saw, and I appreciate it! Was about to do it until I saw you beat me to it 🙂 | 20:17:00 |
nex (she/it) | I'm good at being everywhere at once | 20:18:05 |
14 Aug 2024 |
HarHarLinks | I was about to ask about this but then I duckduckgo'd 👀
https://github.com/matrix-nio/vodozemac-python | 14:45:22 |
| @tleydxdy:tlebear.win left the room. | 14:58:02 |
15 Aug 2024 |
nex (she/it) | moving nio into an src/ layout appears to be one hell of a refactor task 😟 | 13:59:40 |