In reply to @fabian:alertrix.net

I am trying to implement a custom store class but after registering a new user I always end up with

Traceback (most recent call last):
…
    self._handle_register(response)
…
    self.restore_login(response.user_id, response.device_id, response.access_token)
…
    self.load_store()
…
    self.olm = Olm(self.user_id, self.device_id, self.store)
…
    account = self.store.load_account()  # type: ignore
…
    return OlmAccount.from_pickle(account.account, self.pickle_key, account.shared)
…
    account = super().from_pickle(pickle, passphrase)
…
  File "[…]/lib64/python3.12/site-packages/olm/account.py", line 149, in from_pickle
    raise ValueError("Pickle can't be empty")
ValueError: Pickle can't be empty

I think I need to create a default value for the Accounts.account attribute in my Store(MatrixStore)s _get_account. How do I do that?

In reply to @anton:rendezvous.anton.molyboha.me

As far as I know, you should be able to just throw from inside on_sync_error:

def on_sync_error(response: SyncError):
    if response.status_code >= 500:
        throw response

but I don't know for sure, you need to try and check.

Another question I have is about the expression response.status_code >= 500. What will it do if the server is fully offline (does not accept tcp connections)? Will there be any status_code at all? Will it equal None and cause your code throw some other exception because you cannot compare None >= 500?

Thanks to nex's feedback, I think this should actually be:

class MatrixServerOffline(RuntimeError):
    pass

async def on_sync_error(error: matrix.SyncError):
    if error.transport_response.status >= 500:
        raise MatrixServerOffline()

Hey Everyone!

I wanted to discuss the use of Access Tokens in query parameters and headers. 
Starting with v1.11, this method was deprecated for valid reasons (see the spec: https://spec.matrix.org/v1.11/client-server-api/#using-access-tokens). 
Unfortunately, Nio sends this token as a query parameter.

I found an existing issue from April 2020: Pass access_token as Authorization Bearer token? #118 which outlines the challenges involved. These challenges are indeed difficult, as addressing them might result in breaking changes to the API layer, which would be critical in my case.

Are there currently any efforts underway towards a change or solution on the Nio side? Given that many of us need to adhere to certain (security) policies, there's some pressure to comply with the spec as fast as possible. I wanted to check in before implementing something on our layer or creating a new Nio ticket for this.

Cheers!

In reply to @winduu:matrix.org

Hey Everyone!

I wanted to discuss the use of Access Tokens in query parameters and headers. 
Starting with v1.11, this method was deprecated for valid reasons (see the spec: https://spec.matrix.org/v1.11/client-server-api/#using-access-tokens). 
Unfortunately, Nio sends this token as a query parameter.

I found an existing issue from April 2020: Pass access_token as Authorization Bearer token? #118 which outlines the challenges involved. These challenges are indeed difficult, as addressing them might result in breaking changes to the API layer, which would be critical in my case.

Are there currently any efforts underway towards a change or solution on the Nio side? Given that many of us need to adhere to certain (security) policies, there's some pressure to comply with the spec as fast as possible. I wanted to check in before implementing something on our layer or creating a new Nio ticket for this.

Cheers!

Some options I could imagine:

1. A breaking change is introduced in version 0.26.0
2. The API class is unchanged, but a new API2 class is created with the new interface; the rest of the code (slowly?) migrates to API2
3. A breaking change is introduced in version 0.26.0, but instead of changing the API completely, the methods that currently return the 2-tuple (HTTP method, path) will now return a 3-tuple (HTTP method, path, HTTP headers). Such change is still breaking, but the migration is supposedly easier?

(Disclaimer: I don't have any authority in this project, just another user. I might have some free time over the next month-ish to work on this, though)

In reply to @winduu:matrix.org

Hey Everyone!

I wanted to discuss the use of Access Tokens in query parameters and headers. 
Starting with v1.11, this method was deprecated for valid reasons (see the spec: https://spec.matrix.org/v1.11/client-server-api/#using-access-tokens). 
Unfortunately, Nio sends this token as a query parameter.

I found an existing issue from April 2020: Pass access_token as Authorization Bearer token? #118 which outlines the challenges involved. These challenges are indeed difficult, as addressing them might result in breaking changes to the API layer, which would be critical in my case.

Are there currently any efforts underway towards a change or solution on the Nio side? Given that many of us need to adhere to certain (security) policies, there's some pressure to comply with the spec as fast as possible. I wanted to check in before implementing something on our layer or creating a new Nio ticket for this.

Cheers!

Hey everyone,

Thanks for the responses! 😉

Sure:

Critical in the case that we are using Nio in the realms of a testing framework, synchronous (not using async functionality).

We mainly use the API directly to generate METHOD, PATH, and DATA, then create the requests and hand the response back over to Nio to do its thing (kind of like a man in the middle). Any substantial change to the API would break that, especially any change described in the 2020 ticket.

Regarding anton third point, returning METHOD, PATH, DATA, and HEADERS was something I was thinking about and definitely a preferred way of dealing with it. The amount of breaking changes and reimplementation is absolutely manageable, I'd say.

nex (she/it) - Roger, Roger. I'll summarize our conversation here and bump the 2020 ticket for further discussion.

Hello. I just upgrade the bot because reasons and now I get this

CyberBrain [WARNING]

21:04:07 | nio.client.async_clientTimed out, sleeping for 0s

21:04:23 | nio.client.async_clientTimed out, sleeping for 0s

21:04:39 | nio.client.async_clientTimed out, sleeping for 0s

21:04:55 | nio.client.async_clientTimed out, sleeping for 0s

21:05:11 | nio.client.async_clientTimed out, sleeping for 1s

21:05:28 | nio.client.async_clientTimed out, sleeping for 3s

21:05:47 | nio.client.async_clientTimed out, sleeping for 6s

21:06:09 | nio.client.async_clientTimed out, sleeping for 12s

21:06:37 | nio.client.async_clientTimed out, sleeping for 25s

21:07:18 | nio.client.async_clientTimed out, sleeping for 51s

When it connects