28 Aug 2024 |
ifiguero | the "leave" event and the "join" event happen by themselves. But this is probably related with the "sliding sync" and how you get new events in the sync_forever method. | 19:13:24 |
ifiguero | I think that nio just poll the server so you get updated status. I imagine that has more to do with how the server decide what to send, than the client library (nio ) not using the callback. | 19:15:15 |
29 Aug 2024 |
| sents ꙮ changed their display name from sents to sents ꙮ. | 12:42:06 |
1 Sep 2024 |
| Matthew changed their display name from Matthew (away) to Matthew. | 17:20:30 |
5 Sep 2024 |
| nex (she/it) changed their profile picture. | 02:13:54 |
| nex (she/it) | 12:40:44 |
| nex (she/it) | 12:40:44 |
nex (she/it) | @Paarth Shah - Github Maintainer Just opened a PR to fix authenticated media :) | 17:54:29 |
| Alex joined the room. | 18:14:18 |
Alex | ah, i found the room, hi there. i added some comments on the PR for authenticated media, i think the fix needs some additional adjustments. i could make another PR with my adjustments (working for the moment client), if that helps. there are some open questions though | 18:16:52 |
nex (she/it) | In reply to@timegrid:matrix.c3s.cc ah, i found the room, hi there. i added some comments on the PR for authenticated media, i think the fix needs some additional adjustments. i could make another PR with my adjustments (working for the moment client), if that helps. there are some open questions though Hi, sorry, I didn't see your comments, I was too busy watching a movie lol | 19:14:42 |
nex (she/it) | as mentioned, I'm adjusting now | 19:14:45 |
nex (she/it) | I'm implementing it in a way that it will not be a breaking change, so a review once I've pushed would be nice | 19:15:03 |
nex (she/it) | le sigh | 19:18:01 |
nex (she/it) | Download Screenshot_20240905_201752.webp | 19:18:01 |
nex (she/it) | I wish git wasn't such a pain | 19:18:06 |
nex (she/it) | just do what I want not what you're supposed to, smh | 19:18:14 |
Alex | k, shall i make a PR anyway? there are quite some changes needed, also to the tests, maybe it's an easier start for you? | 19:18:44 |
nex (she/it) | Oh its a pre-commit error | 19:18:43 |
nex (she/it) | 🥴 | 19:18:45 |
nex (she/it) | In reply to@timegrid:matrix.c3s.cc
k, shall i make a PR anyway? there are quite some changes needed, also to the tests, maybe it's an easier start for you? its fine, once I've fixed this pre-commit issue all should be good | 19:19:04 |
nex (she/it) | Just pushed, feel free to take a look @Alex | 19:19:56 |
Alex | k | 19:22:38 |
Alex | still not enough i'm afraid | 19:23:28 |
nex (she/it) | Looking at the spec, it should be? | 19:23:46 |
nex (she/it) | what's missing? | 19:23:47 |
Alex | i don't see, that the access token is passed in download/thumbnail by the async_client. also there's the http client. and the tests will fail | 19:26:13 |
Alex | might really be easier, if you could take a look at my solution | 19:26:39 |
nex (she/it) | HTTPClient is effectively deprecated, and afaik it should be passed down if they're running through mxctohttp | 19:27:09 |
nex (she/it) | https://github.com/matrix-nio/matrix-nio/issues/511 and https://github.com/matrix-nio/matrix-nio/issues/404 | 19:27:32 |