| 5 Sep 2024 |
 Alex | still the test for http client will fail, if you adjust the download/thumbnail function | 19:27:35 |
 nex (she/it) | * https://github.com/matrix-nio/matrix-nio/issues/511 and https://github.com/matrix-nio/matrix-nio/issues/404 may be relevant | 19:27:37 |
| nex (she/it) | There are no tests for http client, and they're all passing with the latest commit | 19:27:58 |
| Alex | In reply to @nex:nexy7574.co.uk
HTTPClient is effectively deprecated, and afaik it should be passed down if they're running through mxctohttp that might be, i did not fully understand the context of that function | 19:28:15 |
| nex (she/it) | Oh hang on | 19:28:15 |
| Alex | i'll try your solution with my moment test case | 19:29:18 |
| nex (she/it) | The API class doesn't call mxctohttp | 19:28:23 |
| nex (she/it) | how whack | 19:28:26 |
| nex (she/it) | I wonder why | 19:29:07 |
| nex (she/it) | I just patched HTTPClient too, pending tests | 19:32:42 |
| nex (she/it) | I'm trying to find my demo client to test this with but I cannot find the gist for the life of me | 19:33:01 |
| Alex | your code unfortunately does not work, i get 401s: MatrixError 401,M_MISSING_TOKEN,Missing access token,{"errcode":"M_MISSING_TOKEN","error":"Missing access token"} | 19:34:57 |
| Alex | which is at least a different error as the former 404s yesterday | 19:36:12 |
| nex (she/it) | Updating the tests now | 19:40:06 |
| nex (she/it) | 
Download Screenshot_20240905_203954.webp | 19:40:07 |
| nex (she/it) | fingers crossed | 19:40:09 |
| nex (she/it) | COME ON | 19:40:25 |
| nex (she/it) | 
Download Screenshot_20240905_204019.webp | 19:40:25 |
| nex (she/it) | I missed ONE | 19:40:26 |
| Alex | this is, what worked for me: https://github.com/timegrid/matrix-nio/commit/255a5f561fc97f209ba54859d85d8327ebdd0e6c | 19:42:49 |
| Alex | just tell me, when i should test your PR again | 19:43:30 |
| nex (she/it) | will do :) and thanks, I shall compare | 19:44:31 |
| Alex | i also added another test for authenticated mxc_to_http, which probably makes sense | 19:48:57 |
| nex (she/it) | Alright @Alex , CI is passing, feel free to give it another test | 19:51:56 |
| Alex | k | 19:52:05 |
| nex (she/it) | wrong alex 🙏 | 19:52:06 |
| Alex | because the http urls won't make sense anymore, as soon as token auth in query strings are removed? | 19:54:20 |
| Alex | looks like it's working | 19:55:35 |
| nex (she/it) | In reply to@timegrid:matrix.c3s.cc
because the http urls won't make sense anymore, as soon as token auth in query strings are removed? https://github.com/matrix-nio/matrix-nio/issues/404 is being used to track the replacement of the query string auth tokens. Its gonna be a pretty big change, which is out of scope for this | 19:56:01 |
| Alex | yup, thought so. do you know, when this will happen? i mean the removal in the specs and the implementation in the servers | 19:57:07 |
