for moment it will be ok, i already made an MR to remove the sharing functionality. i'm just thinking of the others

i also don't find sharing useful, but i have to live with the fact, that moment implemented a function for it and users might use it for whatever reason :P

In reply to @tulir:maunium.net
why don't you just add the header in the send function that makes the http request, rather than immediately making breaking changes and refactoring all methods to return a map of headers?

In reply to @nex:nexy7574.co.uk
afaik the access token is only added to requests that actually need it

but i can't think of any concerns against it either

but servers wouldn't deny a request with an unspecified auth header present, would they?

actually, patching AsyncClient._send() seems to work out of the box for moment. no problems with logins / media (on first sight at least).
the poc based on the current pull request:

diff --git a/src/nio/client/async_client.py b/src/nio/client/async_client.py
index 712f17e..e2da743 100644
--- a/src/nio/client/async_client.py
+++ b/src/nio/client/async_client.py
@@ -799,6 +799,18 @@ class AsyncClient(Client):
             if content_type
             else {"Content-Type": "application/json"}
         )
+        if self.access_token:
+            # add header
+            headers['Authorization'] = f"Bearer {self.access_token}"
+            # remove access token in query string
+            from urllib.parse import urlencode, urlunparse, parse_qs
+            url = list(urlparse(path))
+            qs = parse_qs(url[4])
+            if "access_token" in qs:
+                del(qs["access_token"])
+            url[4] = urlencode(qs, doseq=True)
+            path = urlunparse(url)
+        print(f"{method}: {path}")

         if content_length is not None:
             headers["Content-Length"] = str(content_length)

also added the patch to my normal client i'm using now. so far no problems/errors (beyond broken avatars due to old servers not supporting the authenticated media api yet, but that's not resolvable without adding complexity like e.g. a retry with the old api on fail)

In reply to @nex:nexy7574.co.uk
I actually had an idea at one point to query /_matrix/client/versions before using authed media to see if >1.11 was supported, but I couldn't figure out how to do that without requiring another network request (aside from caching it on first sync or something like that)

i don't know enough about what happens under the hood to resolve this confusion, probably it does not matter anyway, but i'm refering to those messages:

GET: /_matrix/client/v1/media/thumbnail/<OTHERSERVER>/<ID>?width=14&height=14&method=scale&allow_remote=true
~ 18:28:33 | Error retrieving mxc://<OTHERSERVER>/<ID> (user_<USERID>): MatrixError 404,,invalid content type: application/json,{"errcode":"M_UNRECOGNIZED","error":"Unrecognized request"}

i assume, that using the new api, the server also tries to request the thumbnail from the other server and fails