| 7 Sep 2024 |
 Alex | via the new api i mean | 17:41:26 |
 nex (she/it) | In reply to@tulir:maunium.net
are there any benefits to the sans-io architecture or does it just make everything harder? :P From what I understand, its mostly just an old thing, as AsyncClient is the only one that's been updated in years (see https://github.com/matrix-nio/matrix-nio/pull/404) | 17:59:50 |
| nex (she/it) | It'd be a rather pointless task to change it though, if it ain't broke don't fix it | 18:00:11 |
| nex (she/it) | In reply to@timegrid:matrix.c3s.cc
i don't know enough about what happens under the hood to resolve this confusion, probably it does not matter anyway, but i'm refering to those messages: GET: /_matrix/client/v1/media/thumbnail/<OTHERSERVER>/<ID>?width=14&height=14&method=scale&allow_remote=true
~ 18:28:33 | Error retrieving mxc://<OTHERSERVER>/<ID> (user_<USERID>): MatrixError 404,,invalid content type: application/json,{"errcode":"M_UNRECOGNIZED","error":"Unrecognized request"}
i assume, that using the new api, the server also tries to request the thumbnail from the other server and fails I can't see why that'd 404 | 18:01:32 |
| nex (she/it) | This is the S2S API version | 18:02:11 |
| nex (she/it) | which is a completely different endpoint | 18:02:17 |
| nex (she/it) | I don't think the server-server api should matter though given nio is a client | 18:02:58 |
| Alex | ah - my current account is on a server, which probably doesn't speak the new api as well | 18:04:40 |
| nex (she/it) | Yeah, your server only supports up to v1.10 | 18:05:21 |
| nex (she/it) | v1.11 is the minimum for authenticated media | 18:05:30 |
| nex (she/it) | \!admin debug ping matrix.c3s.cc | 18:06:00 |
| nex (she/it) | Got response which took 110.191251ms time:
{
"name": "Synapse",
"version": "1.108.0"
}
| 18:06:00 |
| nex (she/it) | yikes, that's ancient in synapse time | 18:06:10 |
| nex (she/it) | 1.118 is out :^) | 18:06:18 |
| Alex | yes, i'm on it, already talked to the admin today :P ok, then there are no errors with that patch yet (i also tested images with two matrix.org accounts capable of authenticated media) and this probably might be the best option to fix both issues at the same time. are you sure, paarth won't merge it after his review now? | 18:14:33 |
| nex (she/it) | The review was two hours ago, so if it was going to be merged it would've been by now. I've marked it as a draft until I've given it a proper once-over just to make sure there's no confusion | 18:16:23 |
| nex (she/it) | just waiting until I get home so I can get an IDE | 18:16:53 |
| nex (she/it) | which will be any minute now | 18:17:05 |
| nex (she/it) | * The review was two hours ago, so if it was going to be merged on a whim it would've been by now. I've marked it as a draft until I've given it a proper once-over just to make sure there's no confusion | 18:18:10 |
| nex (she/it) | Ouch | 18:32:20 |
| nex (she/it) | 
Download image.png | 18:32:21 |
| nex (she/it) | looks like the tests are expecting the access_token query string | 18:40:04 |
| nex (she/it) | 
Download image.png | 18:40:04 |
| nex (she/it) | that's gonna be a pain to fix | 18:40:12 |
| Alex | sorry, can't see the image :P just read the github comments. i meant the url adjustment more like a temporary test and thought, that api.py was going to be adjusted (all access_tokens removed) | 18:41:16 |
| nex (she/it) | sorry, can't see the image
This quote is starting to become more popular than the "unable to decrypt" meme | 18:43:37 |
| Alex | ^^ | 18:43:45 |
| nex (she/it) | Also yes, hopefully the access tokens will be removed entirely soon:tm:, but for now I just want to get something that works | 18:44:36 |
| Alex | the newest commit also works for me, tested image sharing with a matrix.org account in both encrypted and unencrypted rooms | 19:15:02 |
| nex (she/it) | Yeah, it was just your patch plus the removal of the prior warning I put in | 19:20:52 |
