was more convincing myself, as i'm already struggling with the test environment combinatorials of account/server version * moment version * nio version/patch :P have you tried your client yet?

my matrix.org test account on moment/nio with that patch is also able to display your images

probably also a good idea to add tests for the new header btw. i'm out for today, but i can test again tomorrow, if needed. thx for your efforts :)

In reply to @nex:nexy7574.co.uk
The review was two hours ago, so if it was going to be merged on a whim it would've been by now. I've marked it as a draft until I've given it a proper once-over just to make sure there's no confusion

In reply to @nex:nexy7574.co.uk
that's gonna be a pain to fix

In reply to @nex:nexy7574.co.uk
that's gonna be a pain to fix

In reply to @me:shahpaarth.com
Huge thanks to nex (she/it) for doing the hard work, and Alex, tulir, and whoever else for testing! I'm glad I could help contribute to bring it over the finish line 🙂

In reply to @me:shahpaarth.com
nex (she/it): I've pushed directly to your branch for https://github.com/matrix-nio/matrix-nio/pull/520. I've gotten all tests passing, and I'll be adding tests for the new headers as well. Unless you have objections, I'll be merging this as soon as I have that done.

In reply to @nex:nexy7574.co.uk
Ah well, i could not object at 4am, but I didn't have any objections anyway 😂

it's a really dirty hack, but if someone has to support both media apis for a while, this works for me:

diff --git a/src/nio/client/async_client.py b/src/nio/client/async_client.py
index 730bc6b..2e3c4d5 100644
--- a/src/nio/client/async_client.py
+++ b/src/nio/client/async_client.py
@@ -877,6 +877,17 @@ class AsyncClient(Client):
                 logger.warning("Timed out, sleeping for %ds", wait)
                 await asyncio.sleep(wait)

+        if transport_resp.status == 404 and (  # retry unauthed media
+            path.startswith("/_matrix/client/v1/media")
+        ):
+            path = "/_matrix/media/v3/" + path[25:]
+            resp = await self._send(
+                response_class, method, path, data, response_data,
+                content_type, trace_context, data_provider, timeout,
+                content_length, save_to
+            )
+            return resp
+
         await self.receive_response(resp)
         return resp